jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
Files
33c9d349273e973fe8d1d08ee2de846de697dcfe
danbooru/test/unit
History
evazion 0be0395776 BURs: fix validation of multi-step BURs. 
Bug: When validating a BUR, we didn't properly simulate running each
line of the BUR in order, which could cause validation to incorrectly
fail in multi-line BURs where some lines depended on previous lines.

This bug meant you couldn't reverse an alias in a single BUR. The old
alias wasn't removed before validating the new alias, so the BUR would
fail with an alias conflict.

This bug also meant that BURs containing duplicate aliases or
redundant implications weren't caught.

The fix is for BUR validation to actually simulate creating and removing
aliases in sequential order, just as they would be when the BUR is
approved. This is done by running the BUR in a transaction, then
rolling back the transaction at the end. This is hacky but it works.
2020-12-01 18:58:45 -06:00
..
downloads
tests: fix broken source tests.
2020-11-10 14:52:54 -06:00
moderator
tests: fix unit tests.
2020-03-21 21:07:35 -05:00
post_sets
tests: fix tests.
2020-07-13 19:30:40 -05:00
sources
tests: fix broken source tests.
2020-11-10 14:52:54 -06:00
api_key_test.rb
users: refactor login and authentication logic.
2020-03-25 18:48:43 -05:00
apng_inspector_test.rb
rubocop: fix various style issues.
2019-12-22 21:23:37 -06:00
application_record.rb
Raise error on unpermitted params.
2018-04-06 18:09:57 -07:00
approver_pruner_test.rb
approver pruner: send weekly warning dmails to inactive approvers.
2020-02-27 00:19:16 -06:00
artist_commentary_test.rb
rubocop: fix various style issues.
2019-12-22 21:23:37 -06:00
artist_test.rb
aliases/implications: remove 'pending' state.
2020-12-01 18:58:45 -06:00
artist_url_test.rb
Merge pull request #4487 from BrokenEagle/fix-invalid-url
2020-06-29 17:46:13 -05:00
ban_test.rb
pundit: convert bans to pundit.
2020-03-20 18:03:00 -05:00
bulk_update_request_pruner_test.rb
BURs: remove old single alias/implication pruning code.
2020-03-10 21:23:46 -05:00
bulk_update_request_test.rb
BURs: fix validation of multi-step BURs.
2020-12-01 18:58:45 -06:00
cloudflare_service_test.rb
gems: drop webmock.
2020-06-20 00:20:39 -05:00
comment_test.rb
comments: allow new users to comment.
2020-03-21 23:06:47 -05:00
current_user_test.rb
app controller: move safe mode from app controller to SessionLoader.
2019-08-24 22:55:36 -05:00
d_text_test.rb
BURs: fix rewriting wiki links with qualifiers.
2020-08-28 13:57:18 -05:00
danbooru_http_test.rb
tests: fix artstation download tests.
2020-07-06 17:23:53 -05:00
danbooru_maintenance_test.rb
appeals: crosspost appeals to deletion appeal thread.
2020-08-16 17:19:04 -05:00
dmail_test.rb
dmails: add dmail sending rate limits.
2020-08-28 12:36:42 -05:00
email_validator_test.rb
email validator: fix undeliverable? method always returning false.
2020-03-27 12:47:35 -05:00
favorite_group_test.rb
models: remove belongs_to_creator macro.
2020-01-21 00:09:38 -06:00
favorite_test.rb
Fix #3813: Favorite limit can be bypassed.
2018-08-12 14:22:08 -05:00
forum_post_test.rb
pundit: convert forum topics / forum posts to pundit.
2020-03-20 18:03:00 -05:00
forum_topic_test.rb
forum: fix topics being incorrectly marked as unread (again).
2020-01-22 21:09:32 -06:00
ip_ban_test.rb
test: fix broken tests.
2020-04-21 00:31:16 -05:00
media_file_test.rb
media file: fix exception on empty files.
2020-06-22 18:49:36 -05:00
mod_action_test.rb
models: set more creator names explicitly.
2020-02-23 17:26:08 -06:00
moderation_reports_test.rb
mod reports: include reported user and message in forum post.
2020-02-03 04:52:12 -06:00
note_sanitizer_test.rb
config: eliminate hostnames config option.
2020-01-11 00:59:25 -06:00
note_test.rb
notes: clean up note-locked validation.
2020-02-16 23:19:49 -06:00
paginator_test.rb
pagination: refactor to avoid counting pages in API.
2019-10-07 22:01:37 -05:00
pool_test.rb
tests: fix unit tests.
2020-03-21 21:07:35 -05:00
post_appeal_test.rb
appeals: raise appeal limits.
2020-08-08 12:39:20 -05:00
post_approval_test.rb
flags: raise flag limits.
2020-08-08 15:22:13 -05:00
post_disapproval_test.rb
disapprovals: don't dmail uploaders about disapprovals.
2020-06-28 01:51:41 -05:00
post_event_test.rb
Fix #4568: Send appealed posts back to the mod queue
2020-08-06 20:55:45 -05:00
post_flag_test.rb
Fix #4587: "Max 5 flags per 3 days" should account for reapproved flags.
2020-08-14 21:57:08 -05:00
post_pruner_test.rb
Fix #4568: Send appealed posts back to the mod queue
2020-08-06 20:55:45 -05:00
post_query_builder_test.rb
search: fix parsing of quoted metatag values.
2020-08-12 18:12:16 -05:00
post_test.rb
tests: fix artist ban tests.
2020-12-01 14:16:47 -06:00
post_version_test.rb
tests: fix unit tests.
2020-03-21 21:07:35 -05:00
post_vote_test.rb
Remove super voters.
2020-02-23 17:52:38 -06:00
related_tag_calculator_test.rb
tests: fix various broken tests.
2020-05-13 00:15:04 -05:00
related_tag_query_test.rb
tests: fix unit tests.
2020-03-21 21:07:35 -05:00
reportbooru_service_test.rb
Fix #4522: Sidebar doesn't show most searched tags at certain times of day.
2020-06-19 14:00:50 -05:00
saved_search_test.rb
Fix #4599: Editing saved search fails when user has maximum saved searches.
2020-08-27 22:25:16 -05:00
session_loader_test.rb
tests: fix session loader tests.
2019-11-19 00:06:20 -06:00
spam_detector.rb
users: move emails to separate table.
2020-03-12 21:18:53 -05:00
storage_manager_test.rb
tests: possible fix for images getting nuked by tests.
2020-06-17 12:30:37 -05:00
string_test.rb
…
tag_alias_test.rb
aliases/implications: remove 'error' state.
2020-12-01 18:58:45 -06:00
tag_autocomplete_test.rb
tests: eliminate as_user helper.
2020-06-11 01:02:01 -05:00
tag_implication_test.rb
implications: don't update posts that already have the new tag.
2020-12-01 18:58:45 -06:00
tag_relationship_retirement_service_test.rb
test: move test/models/* to test/unit/*.
2020-01-21 00:09:38 -06:00
tag_set_presenter_test.rb
Fix #3937: Blank lines in tagbox if certain taggroups are absent
2018-10-01 19:47:39 -05:00
tag_test.rb
search: move misc search parsing helpers to PostQueryBuilder.
2020-04-23 01:51:30 -05:00
token_bucket_test.rb
rubocop: fix various style issues.
2019-12-22 21:23:37 -06:00
upload_limit_test.rb
uploads: make early deletions cost more upload slots.
2020-08-12 21:31:30 -05:00
upload_service_test.rb
tests: fix broken source tests.
2020-11-10 14:52:54 -06:00
user_deletion_test.rb
user deletions: fix error when given incorrect password.
2020-04-03 23:44:23 -05:00
user_feedback_test.rb
pundit: convert user feedbacks to pundit.
2020-03-20 18:03:00 -05:00
user_mailer_test.rb
tests: add more controller tests.
2020-03-31 19:00:32 -05:00
user_name_change_request_test.rb
user name changes: don't create feedback or modaction.
2019-09-25 21:43:01 -05:00
user_test.rb
Fix #4540: Demotion sends "You have been promoted" dmail.
2020-07-13 19:25:29 -05:00
wiki_page_test.rb
pundit: convert wiki pages to pundit.
2020-03-20 18:03:00 -05:00