`normalize_for_source` was used to convert image URLs to page URLs when displaying sources on the post show page. Move all the code for converting image URLs to page URLs from `Sources::Strategies#normalize_for_source` to `Source::URL#page_url`. Before we had to be very careful in source strategies not to make any network calls in `normalize_for_source`, since it was used in the view for the post show page. Now all the code for generating page URLs is isolated in Source::URL, which makes source strategies simpler. It also makes it easier to check if a source is an image URL or page URL, and if the image URL is convertible to a page URL, which will make autotagging bad_link or bad_source feasible. Finally, this fixes it to generate better page URLs in a handful of cases: * https://www.artstation.com/artwork/qPVGP instead of https://anubis1982918.artstation.com/projects/qPVGP * https://yande.re/post/show?md5=b4b1d11facd1700544554e4805d47bb6s instead of https://yande.re/post?tags=md5:b4b1d11facd1700544554e4805d47bb6 * http://gallery.minitokyo.net/view/365677 instead of http://gallery.minitokyo.net/download/365677 * https://valkyriecrusade.fandom.com/wiki/File:Crimson_Hatsune_H.png instead of https://valkyriecrusade.wikia.com/wiki/File:Crimson_Hatsune_H.png * https://rule34.paheal.net/post/view/852405 instead of https://rule34.paheal.net/post/list/md5:854806addcd3b1246424e7cea49afe31/1
157 lines
6.5 KiB
Ruby
157 lines
6.5 KiB
Ruby
require 'test_helper'
|
|
|
|
module Sources
|
|
class MastodonTest < ActiveSupport::TestCase
|
|
context "The source site for a https://pawoo.net/web/status/$id url" do
|
|
setup do
|
|
skip "Pawoo keys not set" unless Danbooru.config.pawoo_client_id
|
|
@site = Sources::Strategies.find("https://pawoo.net/web/statuses/1202176")
|
|
end
|
|
|
|
should "get the profile" do
|
|
assert_equal("https://pawoo.net/@9ed00e924818", @site.profile_url)
|
|
end
|
|
|
|
should "get the artist name" do
|
|
assert_equal("9ed00e924818", @site.artist_name)
|
|
end
|
|
|
|
should "get the image url" do
|
|
assert_equal(["https://img.pawoo.net/media_attachments/files/000/128/953/original/4c0a06087b03343f.png"], @site.image_urls)
|
|
end
|
|
|
|
should "get the commentary" do
|
|
desc = '<p>a mind forever voyaging through strange seas of thought alone <a href="https://pawoo.net/media/9hJzXvwxVl1CezW0ecM" rel="nofollow noopener noreferrer" target="_blank"><span class="invisible">https://</span><span class="ellipsis">pawoo.net/media/9hJzXvwxVl1Cez</span><span class="invisible">W0ecM</span></a></p>'
|
|
assert_equal(desc, @site.artist_commentary_desc)
|
|
end
|
|
|
|
should "get the dtext-ified commentary" do
|
|
desc = 'a mind forever voyaging through strange seas of thought alone'
|
|
assert_equal(desc, @site.dtext_artist_commentary_desc)
|
|
end
|
|
end
|
|
|
|
context "The source site for a https://pawoo.net/$user/$id url" do
|
|
setup do
|
|
skip "Pawoo keys not set" unless Danbooru.config.pawoo_client_id
|
|
@site = Sources::Strategies.find("https://pawoo.net/@evazion/19451018")
|
|
end
|
|
|
|
should "get the profile" do
|
|
profiles = %w[https://pawoo.net/@evazion https://pawoo.net/web/accounts/47806]
|
|
assert_equal(profiles.first, @site.profile_url)
|
|
assert_equal(profiles, @site.profile_urls)
|
|
end
|
|
|
|
should "get the artist name" do
|
|
assert_equal("evazion", @site.artist_name)
|
|
end
|
|
|
|
should "get the image urls" do
|
|
urls = %w[
|
|
https://img.pawoo.net/media_attachments/files/001/297/997/original/c4272a09570757c2.png
|
|
https://img.pawoo.net/media_attachments/files/001/298/028/original/55a6fd252778454b.mp4
|
|
https://img.pawoo.net/media_attachments/files/001/298/081/original/2588ee9ba808f38f.webm
|
|
https://img.pawoo.net/media_attachments/files/001/298/084/original/media.mp4
|
|
]
|
|
|
|
assert_equal(urls, @site.image_urls)
|
|
end
|
|
|
|
should "get the tags" do
|
|
assert_equal(%w[foo bar baz], @site.tags.map(&:first))
|
|
end
|
|
|
|
should "get the commentary" do
|
|
desc = "<p>test post please ignore</p><p>blah blah blah</p><p>this is a test 🍕</p><p><a href=\"https://pawoo.net/tags/foo\" class=\"mention hashtag\" rel=\"tag\">#<span>foo</span></a> <a href=\"https://pawoo.net/tags/bar\" class=\"mention hashtag\" rel=\"tag\">#<span>bar</span></a> <a href=\"https://pawoo.net/tags/baz\" class=\"mention hashtag\" rel=\"tag\">#<span>baz</span></a></p>"
|
|
|
|
assert_nil(@site.artist_commentary_title)
|
|
assert_equal(desc, @site.artist_commentary_desc)
|
|
end
|
|
|
|
should "get the dtext-ified commentary" do
|
|
desc = <<-DESC.strip_heredoc.chomp
|
|
test post please ignore
|
|
|
|
blah blah blah
|
|
|
|
this is a test 🍕
|
|
|
|
"#foo":[https://pawoo.net/tags/foo] "#bar":[https://pawoo.net/tags/bar] "#baz":[https://pawoo.net/tags/baz]
|
|
DESC
|
|
|
|
assert_equal(desc, @site.dtext_artist_commentary_desc)
|
|
end
|
|
end
|
|
|
|
context "The source site for a https://img.pawoo.net/ url" do
|
|
setup do
|
|
skip "Pawoo keys not set" unless Danbooru.config.pawoo_client_id
|
|
@url = "https://img.pawoo.net/media_attachments/files/001/298/028/original/55a6fd252778454b.mp4"
|
|
@ref = "https://pawoo.net/@evazion/19451018"
|
|
@site = Sources::Strategies.find(@url, @ref)
|
|
end
|
|
|
|
should "fetch the source data" do
|
|
assert_equal("evazion", @site.artist_name)
|
|
end
|
|
|
|
should "correctly get the page url" do
|
|
assert_equal(@ref, @site.page_url)
|
|
end
|
|
end
|
|
|
|
context "A baraag url" do
|
|
setup do
|
|
skip "Baraag keys not set" unless Danbooru.config.baraag_client_id
|
|
@url = "https://baraag.net/@bardbot/105732813175612920"
|
|
@site1 = Sources::Strategies.find(@url)
|
|
|
|
@img = "https://baraag.net/system/media_attachments/files/105/803/948/862/719/091/original/54e1cb7ca33ec449.png"
|
|
@ref = "https://baraag.net/@Nakamura/105803949565505009"
|
|
@site2 = Sources::Strategies.find(@img, @ref)
|
|
end
|
|
|
|
should "work" do
|
|
assert_equal("https://baraag.net/@bardbot", @site1.profile_url)
|
|
assert_equal(["https://baraag.net/system/media_attachments/files/105/732/803/241/495/700/original/556e1eb7f5ca610f.png"], @site1.image_urls)
|
|
assert_equal("bardbot", @site1.artist_name)
|
|
assert_equal("🍌", @site1.dtext_artist_commentary_desc)
|
|
|
|
assert_equal([@img], @site2.image_urls)
|
|
end
|
|
end
|
|
|
|
context "generating page urls" do
|
|
should "work" do
|
|
assert_equal("https://pawoo.net/@evazion/19451018", Source::URL.page_url("https://pawoo.net/@evazion/19451018/"))
|
|
assert_equal("https://pawoo.net/web/statuses/19451018", Source::URL.page_url("https://pawoo.net/web/statuses/19451018/favorites"))
|
|
assert_equal("https://baraag.net/@bardbot/105732813175612920", Source::URL.page_url("https://baraag.net/@bardbot/105732813175612920/"))
|
|
end
|
|
|
|
should "handle inconvertible urls" do
|
|
assert_nil(Source::URL.page_url("https://img.pawoo.net/media_attachments/files/001/297/997/original/c4272a09570757c2.png"))
|
|
assert_nil(Source::URL.page_url("https://pawoo.net/@evazion/media"))
|
|
assert_nil(Source::URL.page_url("https://baraag.net/system/media_attachments/files/105/732/803/241/495/700/original/556e1eb7f5ca610f.png"))
|
|
end
|
|
end
|
|
|
|
context "A deleted or invalid source" do
|
|
setup do
|
|
skip "Pawoo keys not set" unless Danbooru.config.pawoo_client_id
|
|
|
|
@site1 = Sources::Strategies.find("https://pawoo.net/@nantokakun/105643037682139899") # 404
|
|
@site2 = Sources::Strategies.find("https://img.pawoo.net/media_attachments/files/001/297/997/original/c4272a09570757c2.png")
|
|
|
|
assert_nothing_raised { @site1.to_h }
|
|
assert_nothing_raised { @site2.to_h }
|
|
end
|
|
|
|
should "still find the artist" do
|
|
@artist = FactoryBot.create(:artist, name: "nantokakun", url_string: "https://pawoo.net/@nantokakun")
|
|
assert_equal([@artist], @site1.artists)
|
|
end
|
|
end
|
|
end
|
|
end
|