Automatically merge tags when uploading a duplicate. There are two cases: * You try to upload an image, but it's already on Danbooru. In this case you'll be immediately redirected to the original post, before you can start tagging the upload. * You're uploading an image, it wasn't a dupe when you first opened the upload page, but you got sniped while tagging it. In this case your tags will be merged with the original post, and you will be redirected to the original post. There are a few corner cases: * If you don't have permission to edit the original post, for example because it's banned or has a censored tag, then your tags won't be merged and will be silently ignored. * Only the tags, rating, and parent ID will be merged. The source and artist commentary won't be merged. This is so that if an artist uploads the exact same file to multiple sites, the new source won't override the original source. * Some tags might be contradictory. For example, the new post might be tagged translation_request, but the original post might already be translated. It's up to the user to fix these things afterwards.
322 lines
14 KiB
Ruby
322 lines
14 KiB
Ruby
require 'test_helper'
|
|
|
|
class UploadsControllerTest < ActionDispatch::IntegrationTest
|
|
context "The uploads controller" do
|
|
setup do
|
|
@user = create(:user)
|
|
end
|
|
|
|
context "image proxy action" do
|
|
should "work" do
|
|
url = "https://i.pximg.net/img-original/img/2017/11/21/17/06/44/65985331_p0.png"
|
|
get_auth image_proxy_uploads_path, @user, params: { url: url }
|
|
|
|
assert_response :success
|
|
assert_equal("image/png", response.media_type)
|
|
assert_equal(15_573, response.body.size)
|
|
end
|
|
end
|
|
|
|
context "batch action" do
|
|
context "for twitter galleries" do
|
|
should "render" do
|
|
skip "Twitter keys are not set" unless Danbooru.config.twitter_api_key
|
|
get_auth batch_uploads_path, @user, params: {:url => "https://twitter.com/lvlln/status/567054278486151168"}
|
|
assert_response :success
|
|
end
|
|
end
|
|
|
|
context "for pixiv ugoira galleries" do
|
|
should "render" do
|
|
get_auth batch_uploads_path, @user, params: {:url => "https://www.pixiv.net/member_illust.php?mode=medium&illust_id=59523577"}
|
|
assert_response :success
|
|
assert_no_match(/59523577_ugoira0\.jpg/, response.body)
|
|
end
|
|
end
|
|
|
|
context "for a blank source" do
|
|
should "render" do
|
|
get_auth batch_uploads_path, @user
|
|
assert_response :success
|
|
end
|
|
end
|
|
end
|
|
|
|
context "new action" do
|
|
should "render" do
|
|
get_auth new_upload_path, @user
|
|
assert_response :success
|
|
end
|
|
|
|
should "render with an url" do
|
|
get_auth new_upload_path(url: "https://cdn.donmai.us/original/d3/4e/d34e4cf0a437a5d65f8e82b7bcd02606.jpg"), @user
|
|
assert_response :success
|
|
end
|
|
end
|
|
|
|
context "index action" do
|
|
should "render as an anonymous user" do
|
|
create(:completed_source_upload, uploader: @user)
|
|
get uploads_path
|
|
|
|
assert_response :success
|
|
end
|
|
|
|
should "render as an uploader" do
|
|
create(:completed_source_upload, uploader: @user)
|
|
get_auth uploads_path, @user
|
|
|
|
assert_response :success
|
|
end
|
|
|
|
should "render as an admin" do
|
|
create(:completed_source_upload, uploader: @user)
|
|
get_auth uploads_path, create(:admin_user)
|
|
|
|
assert_response :success
|
|
end
|
|
|
|
context "for a search" do
|
|
setup do
|
|
CurrentUser.user = @user
|
|
@upload = create(:completed_source_upload, uploader: @user, source: "http://example.com/foobar")
|
|
end
|
|
|
|
should respond_to_search({}).with { [@upload] }
|
|
should respond_to_search(source: "http://example.com/foobar").with { @upload }
|
|
should respond_to_search(status: "completed").with { @upload }
|
|
end
|
|
end
|
|
|
|
context "show action" do
|
|
should "not show uploads to other users" do
|
|
upload = create(:completed_source_upload, uploader: @user)
|
|
get_auth upload_path(upload), create(:user)
|
|
|
|
assert_response 403
|
|
end
|
|
|
|
should "render a completed source upload for the uploader" do
|
|
upload = create(:completed_source_upload, uploader: @user)
|
|
get_auth upload_path(upload), @user
|
|
|
|
assert_response :success
|
|
end
|
|
|
|
should "render a completed file upload for the uploader" do
|
|
upload = create(:completed_file_upload, uploader: @user)
|
|
get_auth upload_path(upload), @user
|
|
|
|
assert_response :success
|
|
end
|
|
|
|
should "render a failed upload" do
|
|
upload = create(:upload, uploader: @user, status: "error: Not an image or video")
|
|
get_auth upload_path(upload), @user
|
|
|
|
assert_response :success
|
|
end
|
|
|
|
should "render a pending upload" do
|
|
upload = create(:upload, uploader: @user, status: "pending", source: "https://www.google.com")
|
|
get_auth upload_path(upload), @user
|
|
|
|
assert_response :success
|
|
end
|
|
|
|
should "render a processing upload" do
|
|
upload = create(:upload, uploader: @user, status: "processing")
|
|
get_auth upload_path(upload), @user
|
|
|
|
assert_response :success
|
|
end
|
|
|
|
should "redirect a completed upload to the original post if it's a duplicate of an existing post" do
|
|
@upload = create(:completed_file_upload, uploader: @user)
|
|
@post = create(:post, md5: @upload.media_assets.first.md5, media_asset: @upload.media_assets.first)
|
|
get_auth upload_path(@upload), @user
|
|
|
|
assert_redirected_to @post
|
|
end
|
|
end
|
|
|
|
context "create action" do
|
|
should "fail if not given a file or a source" do
|
|
assert_no_difference("Upload.count") do
|
|
post_auth uploads_path(format: :json), @user
|
|
|
|
assert_response 422
|
|
assert_equal(["No file or source given"], response.parsed_body.dig("errors", "base"))
|
|
end
|
|
end
|
|
|
|
should "fail if given both a file and source" do
|
|
assert_no_difference("Upload.count") do
|
|
file = File.open("test/files/test.jpg")
|
|
source = "https://files.catbox.moe/om3tcw.webm"
|
|
post_auth uploads_path(format: :json), @user, params: { upload: { file: file, source: source }}
|
|
end
|
|
|
|
assert_response 422
|
|
assert_equal(["Can't give both a file and a source"], response.parsed_body.dig("errors", "base"))
|
|
end
|
|
|
|
should "fail if given an unsupported filetype" do
|
|
file = Rack::Test::UploadedFile.new("test/files/ugoira.json")
|
|
post_auth uploads_path(format: :json), @user, params: { upload: { file: file }}
|
|
|
|
assert_response 201
|
|
assert_match("Not an image or video", Upload.last.status)
|
|
end
|
|
|
|
should "fail if the file size is too large" do
|
|
skip "flaky test"
|
|
Danbooru.config.stubs(:max_file_size).returns(1.kilobyte)
|
|
|
|
file = Rack::Test::UploadedFile.new("test/files/test.jpg")
|
|
post_auth uploads_path(format: :json), @user, params: { upload: { file: file }}
|
|
perform_enqueued_jobs
|
|
|
|
assert_response 201
|
|
assert_match("File size must be less than or equal to", Upload.last.status)
|
|
|
|
Danbooru.config.unstub(:max_file_size)
|
|
end
|
|
|
|
context "for a corrupted image" do
|
|
should "fail for a corrupted jpeg" do
|
|
create_upload!("test/files/test-corrupt.jpg", user: @user)
|
|
assert_match("corrupt", Upload.last.status)
|
|
end
|
|
|
|
should "fail for a corrupted gif" do
|
|
create_upload!("test/files/test-corrupt.gif", user: @user)
|
|
assert_match("corrupt", Upload.last.status)
|
|
end
|
|
|
|
# https://schaik.com/pngsuite/pngsuite_xxx_png.html
|
|
should "fail for a corrupted png" do
|
|
create_upload!("test/files/test-corrupt.png", user: @user)
|
|
assert_match("corrupt", Upload.last.status)
|
|
end
|
|
end
|
|
|
|
context "for a video longer than the video length limit" do
|
|
should "fail for a regular user" do
|
|
@source = "https://cdn.donmai.us/original/63/cb/63cb09f2526ef3ac14f11c011516ad9b.webm"
|
|
post_auth uploads_path(format: :json), @user, params: { upload: { source: @source }}
|
|
perform_enqueued_jobs
|
|
|
|
assert_response 201
|
|
assert_match("Duration must be less than", Upload.last.status)
|
|
end
|
|
end
|
|
|
|
# XXX fixme
|
|
context "for a video longer than the video length limit" do
|
|
should_eventually "work for an admin" do
|
|
@source = "https://cdn.donmai.us/original/63/cb/63cb09f2526ef3ac14f11c011516ad9b.webm"
|
|
post_auth uploads_path(format: :json), create(:admin_user), params: { upload: { source: @source }}
|
|
perform_enqueued_jobs
|
|
|
|
assert_response 201
|
|
assert_equal("completed", Upload.last.status)
|
|
end
|
|
end
|
|
|
|
context "when re-uploading a media asset stuck in the 'processing' state" do
|
|
should "mark the asset as failed" do
|
|
asset = create(:media_asset, file: File.open("test/files/test.jpg"), status: "processing")
|
|
file = Rack::Test::UploadedFile.new("test/files/test.jpg")
|
|
|
|
post_auth uploads_path, @user, params: { upload: { file: file }}
|
|
upload = Upload.last
|
|
|
|
assert_redirected_to upload
|
|
assert_match("Upload failed, try again", upload.reload.status)
|
|
assert_equal("failed", asset.reload.status)
|
|
end
|
|
end
|
|
|
|
should "work for a source URL containing unicode characters" do
|
|
source1 = "https://cdn.donmai.us/original/d3/4e/d34e4cf0a437a5d65f8e82b7bcd02606.jpg?one=東方&two=a%20b"
|
|
source2 = "https://cdn.donmai.us/original/d3/4e/d34e4cf0a437a5d65f8e82b7bcd02606.jpg?one=%E6%9D%B1%E6%96%B9&two=a%20b"
|
|
|
|
upload = assert_successful_upload(source1, user: @user)
|
|
assert_equal(source2, upload.source)
|
|
end
|
|
|
|
context "uploading a file from your computer" do
|
|
should_upload_successfully("test/files/test.jpg")
|
|
should_upload_successfully("test/files/test.png")
|
|
should_upload_successfully("test/files/test-static-32x32.gif")
|
|
should_upload_successfully("test/files/test-animated-86x52.gif")
|
|
should_upload_successfully("test/files/test-300x300.mp4")
|
|
should_upload_successfully("test/files/test-512x512.webm")
|
|
# should_upload_successfully("test/files/compressed.swf")
|
|
end
|
|
|
|
context "uploading a file from a source" do
|
|
should_upload_successfully("https://www.artstation.com/artwork/04XA4")
|
|
should_upload_successfully("https://dantewontdie.artstation.com/projects/YZK5q")
|
|
should_upload_successfully("https://cdna.artstation.com/p/assets/images/images/006/029/978/large/amama-l-z.jpg")
|
|
|
|
should_upload_successfully("https://www.deviantart.com/aeror404/art/Holiday-Elincia-424551484")
|
|
should_upload_successfully("https://noizave.deviantart.com/art/test-no-download-697415967")
|
|
should_upload_successfully("https://images-wixmp-ed30a86b8c4ca887773594c2.wixmp.com/intermediary/f/8b472d70-a0d6-41b5-9a66-c35687090acc/d23jbr4-8a06af02-70cb-46da-8a96-42a6ba73cdb4.jpg/v1/fill/w_786,h_1017,q_70,strp/silverhawks_quicksilver_by_edsfox_d23jbr4-pre.jpg")
|
|
|
|
should_upload_successfully("https://www.hentai-foundry.com/pictures/user/Afrobull/795025/kuroeda")
|
|
should_upload_successfully("https://pictures.hentai-foundry.com/a/Afrobull/795025/Afrobull-795025-kuroeda.png")
|
|
|
|
should_upload_successfully("https://yande.re/post/show/482880")
|
|
should_upload_successfully("https://files.yande.re/image/7ecfdead705d7b956b26b1d37b98d089/yande.re%20482880.jpg")
|
|
|
|
should_upload_successfully("https://konachan.com/post/show/270916")
|
|
should_upload_successfully("https://konachan.com/image/ca12cdb79a66d242e95a6f958341bf05/Konachan.com%20-%20270916.png")
|
|
|
|
should_upload_successfully("http://lohas.nicoseiga.jp/o/910aecf08e542285862954017f8a33a8c32a8aec/1433298801/4937663")
|
|
should_upload_successfully("http://seiga.nicovideo.jp/seiga/im4937663")
|
|
should_upload_successfully("https://seiga.nicovideo.jp/image/source/9146749")
|
|
should_upload_successfully("https://seiga.nicovideo.jp/watch/mg389884")
|
|
should_upload_successfully("https://dic.nicovideo.jp/oekaki/52833.png")
|
|
should_upload_successfully("https://lohas.nicoseiga.jp/o/971eb8af9bbcde5c2e51d5ef3a2f62d6d9ff5552/1589933964/3583893")
|
|
should_upload_successfully("http://lohas.nicoseiga.jp/priv/3521156?e=1382558156&h=f2e089256abd1d453a455ec8f317a6c703e2cedf")
|
|
should_upload_successfully("http://lohas.nicoseiga.jp/priv/b80f86c0d8591b217e7513a9e175e94e00f3c7a1/1384936074/3583893")
|
|
should_upload_successfully("http://lohas.nicoseiga.jp/material/5746c5/4459092")
|
|
# XXX should_upload_successfully("https://dcdn.cdn.nimg.jp/priv/62a56a7f67d3d3746ae5712db9cac7d465f4a339/1592186183/10466669")
|
|
# XXX should_upload_successfully("https://dcdn.cdn.nimg.jp/nicoseiga/lohas/o/8ba0a9b2ea34e1ef3b5cc50785bd10cd63ec7e4a/1592187477/10466669")
|
|
|
|
should_upload_successfully("http://nijie.info/view.php?id=213043")
|
|
should_upload_successfully("https://nijie.info/view_popup.php?id=213043")
|
|
should_upload_successfully("https://pic.nijie.net/03/nijie_picture/728995_20170505014820_0.jpg")
|
|
|
|
should_upload_successfully("https://pawoo.net/web/statuses/1202176") if Danbooru.config.pawoo_client_id.present? # XXX
|
|
should_upload_successfully("https://img.pawoo.net/media_attachments/files/000/128/953/original/4c0a06087b03343f.png") if Danbooru.config.pawoo_client_id.present? # XXX
|
|
|
|
should_upload_successfully("https://www.pixiv.net/en/artworks/64476642")
|
|
should_upload_successfully("https://www.pixiv.net/member_illust.php?mode=medium&illust_id=62247364")
|
|
should_upload_successfully("https://i.pximg.net/img-original/img/2017/08/18/00/09/21/64476642_p0.jpg")
|
|
|
|
should_upload_successfully("https://noizave.tumblr.com/post/162206271767")
|
|
should_upload_successfully("https://media.tumblr.com/3bbfcbf075ddf969c996641b264086fd/tumblr_os2buiIOt51wsfqepo1_1280.png")
|
|
|
|
should_upload_successfully("https://twitter.com/noizave/status/875768175136317440")
|
|
should_upload_successfully("https://pbs.twimg.com/media/DCdZ_FhUIAAYKFN?format=jpg&name=medium")
|
|
should_upload_successfully("https://pbs.twimg.com/profile_banners/2371694594/1581832507/1500x500")
|
|
should_upload_successfully("https://twitter.com/zeth_total/status/1355597580814585856")
|
|
# XXX should_upload_successfully("https://video.twimg.com/tweet_video/EWHWVrmVcAAp4Vw.mp4")
|
|
|
|
should_upload_successfully("https://www.weibo.com/5501756072/J2UNKfbqV")
|
|
should_upload_successfully("https://wx1.sinaimg.cn/mw690/0060kO5aly1gezsyt5xvhj30ok0sgtc9.jpg")
|
|
|
|
should_upload_successfully("https://art.ngfiles.com/images/1254000/1254722_natthelich_pandora.jpg")
|
|
should_upload_successfully("https://art.ngfiles.com/comments/57000/iu_57615_7115981.jpg")
|
|
should_upload_successfully("https://www.newgrounds.com/art/view/puddbytes/costanza-at-bat")
|
|
|
|
should_upload_successfully("https://kmyama.fanbox.cc/posts/104708")
|
|
should_upload_successfully("https://downloads.fanbox.cc/images/post/104708/wsF73EC5Fq0CIK84W0LGYk2p.jpeg")
|
|
end
|
|
end
|
|
end
|
|
end
|