abce4d2551
Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
84 lines
2.3 KiB
Ruby
84 lines
2.3 KiB
Ruby
class FavoriteGroupsController < ApplicationController
|
|
before_action :member_only, :except => [:index, :show]
|
|
respond_to :html, :xml, :json, :js
|
|
|
|
def index
|
|
@favorite_groups = FavoriteGroup.search(search_params).paginate(params[:page], :limit => params[:limit], :search_count => params[:search])
|
|
respond_with(@favorite_groups) do |format|
|
|
format.xml do
|
|
render :xml => @favorite_groups.to_xml(:root => "favorite-groups")
|
|
end
|
|
end
|
|
end
|
|
|
|
def show
|
|
@favorite_group = FavoriteGroup.find(params[:id])
|
|
check_read_privilege(@favorite_group)
|
|
@post_set = PostSets::FavoriteGroup.new(@favorite_group, params[:page])
|
|
respond_with(@favorite_group)
|
|
end
|
|
|
|
def new
|
|
@favorite_group = FavoriteGroup.new
|
|
respond_with(@favorite_group)
|
|
end
|
|
|
|
def create
|
|
@favorite_group = FavoriteGroup.create(favgroup_params)
|
|
respond_with(@favorite_group) do |format|
|
|
format.html do
|
|
if @favorite_group.errors.any?
|
|
render :action => "new"
|
|
else
|
|
redirect_to favorite_groups_path
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
def edit
|
|
@favorite_group = FavoriteGroup.find(params[:id])
|
|
check_write_privilege(@favorite_group)
|
|
respond_with(@favorite_group)
|
|
end
|
|
|
|
def update
|
|
@favorite_group = FavoriteGroup.find(params[:id])
|
|
check_write_privilege(@favorite_group)
|
|
@favorite_group.update(favgroup_params)
|
|
unless @favorite_group.errors.any?
|
|
flash[:notice] = "Favorite group updated"
|
|
end
|
|
respond_with(@favorite_group)
|
|
end
|
|
|
|
def destroy
|
|
@favorite_group = FavoriteGroup.find(params[:id])
|
|
check_write_privilege(@favorite_group)
|
|
@favorite_group.destroy
|
|
flash[:notice] = "Favorite group deleted"
|
|
redirect_to favorite_groups_path
|
|
end
|
|
|
|
def add_post
|
|
@favorite_group = FavoriteGroup.find(params[:id])
|
|
check_write_privilege(@favorite_group)
|
|
@post = Post.find(params[:post_id])
|
|
@favorite_group.add!(@post.id)
|
|
end
|
|
|
|
private
|
|
|
|
def check_write_privilege(favgroup)
|
|
raise User::PrivilegeError unless favgroup.editable_by?(CurrentUser.user)
|
|
end
|
|
|
|
def check_read_privilege(favgroup)
|
|
raise User::PrivilegeError unless favgroup.viewable_by?(CurrentUser.user)
|
|
end
|
|
|
|
def favgroup_params
|
|
params.fetch(:favorite_group, {}).permit(%i[name post_ids is_public])
|
|
end
|
|
end
|