59b277ead1
Changes: * Drop Users.id_to_name. * Don't cache Users.name_to_id. * Replace calls to name_to_id with find_by_name when possible. * Don't autodefine creator_name in belongs_to_creator. * Don't autodefine updater_name in belongs_to_updater. * Instead manually define creator_name / updater_name only on models that need to return these fields in the api. id_to_name was cached to reduce the impact of N+1 query patterns in certain places, especially in api responses that return creator_name / updater_name fields. But it still meant we were doing N calls to memcache. Using `includes` to prefetch users avoids this N+1 pattern. name_to_id had no need be cached, it was never used in any performance- sensitive contexts. Avoiding caching also avoids the need to keep these caches consistent.
110 lines
3.1 KiB
Ruby
110 lines
3.1 KiB
Ruby
class WikiPagesController < ApplicationController
|
|
respond_to :html, :xml, :json, :js
|
|
before_action :member_only, :except => [:index, :search, :show, :show_or_new]
|
|
before_action :builder_only, :only => [:destroy]
|
|
before_action :normalize_search_params, :only => [:index]
|
|
|
|
def new
|
|
@wiki_page = WikiPage.new(wiki_page_params(:create))
|
|
respond_with(@wiki_page)
|
|
end
|
|
|
|
def edit
|
|
@wiki_page = WikiPage.find(params[:id])
|
|
respond_with(@wiki_page)
|
|
end
|
|
|
|
def index
|
|
@wiki_pages = WikiPage.includes(:creator).search(search_params).paginate(params[:page], :limit => params[:limit], :search_count => params[:search])
|
|
respond_with(@wiki_pages) do |format|
|
|
format.html do
|
|
if params[:page].nil? || params[:page].to_i == 1
|
|
if @wiki_pages.length == 1
|
|
redirect_to(wiki_page_path(@wiki_pages.first))
|
|
elsif @wiki_pages.length == 0 && params[:search][:title].present? && params[:search][:title] !~ /\*/
|
|
redirect_to(wiki_pages_path(:search => {:title => "*#{params[:search][:title]}*"}))
|
|
end
|
|
end
|
|
end
|
|
format.xml do
|
|
render :xml => @wiki_pages.to_xml(:root => "wiki-pages")
|
|
end
|
|
format.json do
|
|
render json: @wiki_pages.to_json
|
|
expires_in params[:expiry].to_i.days if params[:expiry]
|
|
end
|
|
end
|
|
end
|
|
|
|
def search
|
|
end
|
|
|
|
def show
|
|
if params[:id] =~ /\A\d+\z/
|
|
@wiki_page = WikiPage.find(params[:id])
|
|
else
|
|
@wiki_page = WikiPage.titled(params[:id]).first
|
|
end
|
|
|
|
if @wiki_page.present?
|
|
respond_with(@wiki_page)
|
|
elsif request.format.html?
|
|
redirect_to show_or_new_wiki_pages_path(title: params[:id])
|
|
else
|
|
raise ActiveRecord::RecordNotFound
|
|
end
|
|
end
|
|
|
|
def create
|
|
@wiki_page = WikiPage.create(wiki_page_params(:create))
|
|
respond_with(@wiki_page)
|
|
end
|
|
|
|
def update
|
|
@wiki_page = WikiPage.find(params[:id])
|
|
@wiki_page.update(wiki_page_params(:update))
|
|
respond_with(@wiki_page)
|
|
end
|
|
|
|
def destroy
|
|
@wiki_page = WikiPage.find(params[:id])
|
|
@wiki_page.update_attributes(:is_deleted => true)
|
|
respond_with(@wiki_page)
|
|
end
|
|
|
|
def revert
|
|
@wiki_page = WikiPage.find(params[:id])
|
|
@version = @wiki_page.versions.find(params[:version_id])
|
|
@wiki_page.revert_to!(@version)
|
|
flash[:notice] = "Page was reverted"
|
|
respond_with(@wiki_page)
|
|
end
|
|
|
|
def show_or_new
|
|
@wiki_page = WikiPage.find_by_title(params[:title])
|
|
if @wiki_page
|
|
redirect_to wiki_page_path(@wiki_page)
|
|
else
|
|
@wiki_page = WikiPage.new(:title => params[:title])
|
|
respond_with(@wiki_page)
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def normalize_search_params
|
|
if params[:title]
|
|
params[:search] ||= {}
|
|
params[:search][:title] = params.delete(:title)
|
|
end
|
|
end
|
|
|
|
def wiki_page_params(context)
|
|
permitted_params = %i[body other_names other_names_string skip_secondary_validations]
|
|
permitted_params += %i[is_locked is_deleted] if CurrentUser.is_builder?
|
|
permitted_params += %i[title] if context == :create || CurrentUser.is_builder?
|
|
|
|
params.fetch(:wiki_page, {}).permit(permitted_params)
|
|
end
|
|
end
|