Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
121 lines
3.7 KiB
Ruby
121 lines
3.7 KiB
Ruby
require 'test_helper'
|
|
|
|
module Moderator
|
|
module Post
|
|
class PostsControllerTest < ActionDispatch::IntegrationTest
|
|
context "The moderator posts controller" do
|
|
setup do
|
|
@admin = create(:admin_user)
|
|
travel_to(1.month.ago) do
|
|
@user = create(:gold_user)
|
|
end
|
|
|
|
as_user do
|
|
@post = create(:post)
|
|
end
|
|
end
|
|
|
|
context "confirm_delete action" do
|
|
should "render" do
|
|
get_auth confirm_delete_moderator_post_post_path(@post), @admin
|
|
assert_response :success
|
|
end
|
|
end
|
|
|
|
context "delete action" do
|
|
should "render" do
|
|
post_auth delete_moderator_post_post_path(@post), @admin, params: {:reason => "xxx", :format => "js", :commit => "Delete"}
|
|
assert(@post.reload.is_deleted?)
|
|
end
|
|
|
|
should "work even if the deleter has flagged the post previously" do
|
|
as_user do
|
|
PostFlag.create(:post => @post, :reason => "aaa", :is_resolved => false)
|
|
end
|
|
post_auth delete_moderator_post_post_path(@post), @admin, params: {:reason => "xxx", :format => "js", :commit => "Delete"}
|
|
assert(@post.reload.is_deleted?)
|
|
end
|
|
end
|
|
|
|
context "undelete action" do
|
|
should "render" do
|
|
as_user do
|
|
@post.update(is_deleted: true)
|
|
end
|
|
post_auth undelete_moderator_post_post_path(@post), @admin, params: {:format => "js"}
|
|
|
|
assert_response :success
|
|
assert(!@post.reload.is_deleted?)
|
|
end
|
|
end
|
|
|
|
context "confirm_move_favorites action" do
|
|
should "render" do
|
|
get_auth confirm_ban_moderator_post_post_path(@post), @admin
|
|
assert_response :success
|
|
end
|
|
end
|
|
|
|
context "move_favorites action" do
|
|
setup do
|
|
@admin = create(:admin_user)
|
|
end
|
|
|
|
should "render" do
|
|
as_user do
|
|
@parent = create(:post)
|
|
@child = create(:post, parent: @parent)
|
|
end
|
|
users = FactoryBot.create_list(:user, 2)
|
|
users.each do |u|
|
|
@child.add_favorite!(u)
|
|
end
|
|
|
|
post_auth move_favorites_moderator_post_post_path(@child.id), @admin, params: { commit: "Submit" }
|
|
assert_redirected_to(@child)
|
|
as(@admin) do
|
|
assert_equal(users, @parent.reload.favorited_users)
|
|
assert_equal([], @child.reload.favorited_users)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "expunge action" do
|
|
should "render" do
|
|
post_auth expunge_moderator_post_post_path(@post), @admin, params: { format: "js" }
|
|
|
|
assert_response :success
|
|
assert_equal(false, ::Post.exists?(@post.id))
|
|
end
|
|
end
|
|
|
|
context "confirm_ban action" do
|
|
should "render" do
|
|
get_auth confirm_ban_moderator_post_post_path(@post), @admin
|
|
assert_response :success
|
|
end
|
|
end
|
|
|
|
context "ban action" do
|
|
should "render" do
|
|
post_auth ban_moderator_post_post_path(@post), @admin, params: { commit: "Ban", format: "js" }
|
|
|
|
assert_response :success
|
|
assert_equal(true, @post.reload.is_banned?)
|
|
end
|
|
end
|
|
|
|
context "unban action" do
|
|
should "render" do
|
|
@post.ban!
|
|
post_auth unban_moderator_post_post_path(@post), @admin, params: { format: "js" }
|
|
|
|
assert_redirected_to(@post)
|
|
assert_equal(false, @post.reload.is_banned?)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|