Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
179 lines
5.6 KiB
Ruby
179 lines
5.6 KiB
Ruby
require 'test_helper'
|
|
|
|
class ForumPostTest < ActiveSupport::TestCase
|
|
context "A forum post" do
|
|
setup do
|
|
@user = FactoryBot.create(:user)
|
|
CurrentUser.user = @user
|
|
CurrentUser.ip_addr = "127.0.0.1"
|
|
@topic = FactoryBot.create(:forum_topic)
|
|
end
|
|
|
|
teardown do
|
|
CurrentUser.user = nil
|
|
CurrentUser.ip_addr = nil
|
|
end
|
|
|
|
context "that mentions a user" do
|
|
context "in a quote block" do
|
|
setup do
|
|
@user2 = FactoryBot.create(:user)
|
|
end
|
|
|
|
should "not create a dmail" do
|
|
assert_difference("Dmail.count", 0) do
|
|
FactoryBot.create(:forum_post, :topic_id => @topic.id, :body => "[quote]@#{@user2.name}[/quote]")
|
|
end
|
|
|
|
assert_difference("Dmail.count", 0) do
|
|
FactoryBot.create(:forum_post, :topic_id => @topic.id, :body => "[quote]@#{@user2.name}[/quote] blah [quote]@#{@user2.name}[/quote]")
|
|
end
|
|
|
|
assert_difference("Dmail.count", 0) do
|
|
FactoryBot.create(:forum_post, :topic_id => @topic.id, :body => "[quote][quote]@#{@user2.name}[/quote][/quote]")
|
|
end
|
|
|
|
assert_difference("Dmail.count", 1) do
|
|
FactoryBot.create(:forum_post, :topic_id => @topic.id, :body => "[quote]@#{@user2.name}[/quote] @#{@user2.name}")
|
|
end
|
|
end
|
|
end
|
|
|
|
context "outside a quote block" do
|
|
setup do
|
|
@user2 = FactoryBot.create(:user)
|
|
@post = FactoryBot.build(:forum_post, :topic_id => @topic.id, :body => "Hey @#{@user2.name} check this out!")
|
|
end
|
|
|
|
should "create a dmail" do
|
|
assert_difference("Dmail.count", 1) do
|
|
@post.save
|
|
end
|
|
|
|
dmail = Dmail.last
|
|
assert_equal(<<-EOS.strip_heredoc, dmail.body)
|
|
@#{CurrentUser.name} mentioned you in topic ##{@topic.id} (\"#{@topic.title}\":[/forum_topics/#{@topic.id}?page=1]):
|
|
|
|
[quote]
|
|
Hey @#{@user2.name} check this out!
|
|
[/quote]
|
|
EOS
|
|
end
|
|
end
|
|
end
|
|
|
|
context "that belongs to a topic with several pages of posts" do
|
|
setup do
|
|
Danbooru.config.stubs(:posts_per_page).returns(3)
|
|
@posts = []
|
|
9.times do
|
|
@posts << FactoryBot.create(:forum_post, :topic_id => @topic.id, :body => rand(100_000))
|
|
end
|
|
Timecop.travel(2.seconds.from_now) do
|
|
@posts << FactoryBot.create(:forum_post, :topic_id => @topic.id, :body => rand(100_000))
|
|
end
|
|
end
|
|
|
|
context "that is deleted" do
|
|
setup do
|
|
CurrentUser.user = FactoryBot.create(:moderator_user)
|
|
end
|
|
|
|
should "update the topic's updated_at timestamp" do
|
|
@topic.reload
|
|
assert_equal(@posts[-1].updated_at.to_i, @topic.updated_at.to_i)
|
|
@posts[-1].delete!
|
|
@topic.reload
|
|
assert_equal(@posts[-2].updated_at.to_i, @topic.updated_at.to_i)
|
|
end
|
|
end
|
|
|
|
should "know which page it's on" do
|
|
assert_equal(2, @posts[3].forum_topic_page)
|
|
assert_equal(2, @posts[4].forum_topic_page)
|
|
assert_equal(2, @posts[5].forum_topic_page)
|
|
assert_equal(3, @posts[6].forum_topic_page)
|
|
end
|
|
|
|
should "update the topic's updated_at when deleted" do
|
|
@posts.last.destroy
|
|
@topic.reload
|
|
assert_equal(@posts[8].updated_at.to_s, @topic.updated_at.to_s)
|
|
end
|
|
end
|
|
|
|
context "belonging to a locked topic" do
|
|
setup do
|
|
@post = FactoryBot.create(:forum_post, :topic_id => @topic.id, :body => "zzz")
|
|
@topic.update_attribute(:is_locked, true)
|
|
@post.reload
|
|
end
|
|
|
|
should "not be updateable" do
|
|
@post.update_attributes(:body => "xxx")
|
|
@post.reload
|
|
assert_equal("zzz", @post.body)
|
|
end
|
|
|
|
should "not be deletable" do
|
|
assert_difference("ForumPost.count", 0) do
|
|
@post.destroy
|
|
end
|
|
end
|
|
end
|
|
|
|
should "update the topic when created" do
|
|
@original_topic_updated_at = @topic.updated_at
|
|
Timecop.travel(1.second.from_now) do
|
|
post = FactoryBot.create(:forum_post, :topic_id => @topic.id)
|
|
end
|
|
@topic.reload
|
|
assert_not_equal(@original_topic_updated_at.to_s, @topic.updated_at.to_s)
|
|
end
|
|
|
|
should "update the topic when updated only for the original post" do
|
|
posts = []
|
|
3.times do
|
|
posts << FactoryBot.create(:forum_post, :topic_id => @topic.id, :body => rand(100_000))
|
|
end
|
|
|
|
# updating the original post
|
|
Timecop.travel(1.second.from_now) do
|
|
posts.first.update_attributes(:body => "xxx")
|
|
end
|
|
@topic.reload
|
|
assert_equal(posts.first.updated_at.to_s, @topic.updated_at.to_s)
|
|
|
|
# updating a non-original post
|
|
Timecop.travel(2.seconds.from_now) do
|
|
posts.last.update_attributes(:body => "xxx")
|
|
end
|
|
assert_equal(posts.first.updated_at.to_s, @topic.updated_at.to_s)
|
|
end
|
|
|
|
should "be searchable by body content" do
|
|
post = FactoryBot.create(:forum_post, :topic_id => @topic.id, :body => "xxx")
|
|
assert_equal(1, ForumPost.body_matches("xxx").count)
|
|
assert_equal(0, ForumPost.body_matches("aaa").count)
|
|
end
|
|
|
|
should "initialize its creator" do
|
|
post = FactoryBot.create(:forum_post, :topic_id => @topic.id)
|
|
assert_equal(@user.id, post.creator_id)
|
|
end
|
|
|
|
context "updated by a second user" do
|
|
setup do
|
|
@post = FactoryBot.create(:forum_post, :topic_id => @topic.id)
|
|
@second_user = FactoryBot.create(:user)
|
|
CurrentUser.user = @second_user
|
|
end
|
|
|
|
should "record its updater" do
|
|
@post.update_attributes(:body => "abc")
|
|
assert_equal(@second_user.id, @post.updater_id)
|
|
end
|
|
end
|
|
end
|
|
end
|