Files
danbooru/app/controllers/artists_controller.rb
evazion 674028588c /artists: avoid COUNT(*), avoid N+1 queries on artist urls.
* The /artists page issued a `SELECT count(*) FROM artists` because
  .paginate was missing search_count.

* /artists.json had an N+1 problem on artist urls. This slowed down
  autocomplete.
2017-04-07 18:25:30 -05:00

141 lines
3.7 KiB
Ruby

class ArtistsController < ApplicationController
respond_to :html, :xml, :json
before_filter :member_only, :except => [:index, :show, :banned]
before_filter :builder_only, :only => [:destroy]
before_filter :admin_only, :only => [:ban, :unban]
before_filter :load_artist, :only => [:ban, :unban, :show, :edit, :update, :destroy, :undelete]
def new
@artist = Artist.new_with_defaults(params)
respond_with(@artist)
end
def edit
respond_with(@artist)
end
def banned
@artists = Artist.where("is_banned = ?", true).order("name")
respond_with(@artists) do |format|
format.xml do
render :xml => @artists.to_xml(:include => [:urls], :root => "artists")
end
format.json do
render :json => @artists.to_json(:include => [:urls])
end
end
end
def ban
@artist.ban!
redirect_to(artist_path(@artist), :notice => "Artist was banned")
end
def unban
@artist.unban!
redirect_to(artist_path(@artist), :notice => "Artist was unbanned")
end
def index
search_params = params[:search].present? ? params[:search] : params
@artists = Artist.includes(:urls).search(search_params).order("id desc").paginate(params[:page], :limit => params[:limit], :search_count => params[:search])
respond_with(@artists) do |format|
format.xml do
render :xml => @artists.to_xml(:include => [:urls], :root => "artists")
end
format.json do
render :json => @artists.to_json(:include => [:urls])
end
end
end
def search
end
def show
@artist = Artist.find(params[:id])
@post_set = PostSets::Artist.new(@artist)
respond_with(@artist) do |format|
format.xml do
render :xml => @artist.to_xml(:include => [:urls])
end
format.json do
render :json => @artist.to_json(:include => [:urls])
end
end
end
def create
@artist = Artist.create(params[:artist], :as => CurrentUser.role)
respond_with(@artist)
end
def update
body = params[:artist].delete("notes")
@artist.assign_attributes(params[:artist], :as => CurrentUser.role)
if body
@artist.notes = body
end
@artist.save
respond_with(@artist)
end
def destroy
if !@artist.deletable_by?(CurrentUser.user)
raise User::PrivilegeError
end
@artist.update_attribute(:is_active, false)
redirect_to(artist_path(@artist), :notice => "Artist deleted")
end
def undelete
if !@artist.deletable_by?(CurrentUser.user)
raise User::PrivilegeError
end
@artist.update_attribute(:is_active, true)
redirect_to(artist_path(@artist), :notice => "Artist undeleted")
end
def revert
@artist = Artist.find(params[:id])
@version = @artist.versions.find(params[:version_id])
@artist.revert_to!(@version)
respond_with(@artist)
end
def show_or_new
@artist = Artist.find_by_name(params[:name])
if @artist
redirect_to artist_path(@artist)
else
redirect_to new_artist_path(:name => params[:name])
end
end
def finder
begin
@artists = Artist.url_matches(params[:url]).order("id desc").limit(20)
if @artists.empty? && params[:referer_url].present? && params[:referer_url] != params[:url]
@artists = Artist.url_matches(params[:referer_url]).order("id desc").limit(20)
end
rescue PixivApiClient::Error => e
@artists = []
end
respond_with(@artists) do |format|
format.xml do
render :xml => @artists.to_xml(:include => [:urls], :root => "artists")
end
format.json do
render :json => @artists.to_json(:include => [:urls])
end
end
end
private
def load_artist
@artist = Artist.find(params[:id])
end
end