Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
112 lines
3.1 KiB
Ruby
112 lines
3.1 KiB
Ruby
class ForumPostsController < ApplicationController
|
|
respond_to :html, :xml, :json, :js
|
|
before_action :member_only, :except => [:index, :show, :search]
|
|
before_action :load_post, :only => [:edit, :show, :update, :destroy, :undelete]
|
|
before_action :check_min_level, :only => [:edit, :show, :update, :destroy, :undelete]
|
|
skip_before_action :api_check
|
|
|
|
def new
|
|
if params[:topic_id]
|
|
@forum_topic = ForumTopic.find(params[:topic_id])
|
|
raise User::PrivilegeError.new unless @forum_topic.visible?(CurrentUser.user)
|
|
end
|
|
if params[:post_id]
|
|
quoted_post = ForumPost.find(params[:post_id])
|
|
raise User::PrivilegeError.new unless quoted_post.topic.visible?(CurrentUser.user)
|
|
end
|
|
@forum_post = ForumPost.new_reply(params)
|
|
respond_with(@forum_post)
|
|
end
|
|
|
|
def edit
|
|
check_privilege(@forum_post)
|
|
respond_with(@forum_post)
|
|
end
|
|
|
|
def index
|
|
@query = ForumPost.search(search_params)
|
|
@forum_posts = @query.includes(:topic).paginate(params[:page], :limit => params[:limit], :search_count => params[:search])
|
|
respond_with(@forum_posts) do |format|
|
|
format.xml do
|
|
render :xml => @forum_posts.to_xml(:root => "forum-posts")
|
|
end
|
|
end
|
|
end
|
|
|
|
def search
|
|
end
|
|
|
|
def show
|
|
if request.format == "text/html" && @forum_post.id == @forum_post.topic.original_post.id
|
|
redirect_to(forum_topic_path(@forum_post.topic, :page => params[:page]))
|
|
else
|
|
respond_with(@forum_post)
|
|
end
|
|
end
|
|
|
|
def create
|
|
@forum_post = ForumPost.create(forum_post_params(:create))
|
|
page = @forum_post.topic.last_page if @forum_post.topic.last_page > 1
|
|
respond_with(@forum_post, :location => forum_topic_path(@forum_post.topic, :page => page))
|
|
end
|
|
|
|
def update
|
|
check_privilege(@forum_post)
|
|
@forum_post.update(forum_post_params(:update))
|
|
page = @forum_post.forum_topic_page if @forum_post.forum_topic_page > 1
|
|
respond_with(@forum_post, :location => forum_topic_path(@forum_post.topic, :page => page, :anchor => "forum_post_#{@forum_post.id}"))
|
|
end
|
|
|
|
def destroy
|
|
check_privilege(@forum_post)
|
|
@forum_post.delete!
|
|
respond_with(@forum_post)
|
|
end
|
|
|
|
def undelete
|
|
check_privilege(@forum_post)
|
|
@forum_post.undelete!
|
|
respond_with(@forum_post)
|
|
end
|
|
|
|
private
|
|
def load_post
|
|
@forum_post = ForumPost.find(params[:id])
|
|
@forum_topic = @forum_post.topic
|
|
end
|
|
|
|
def check_min_level
|
|
if CurrentUser.user.level < @forum_topic.min_level
|
|
respond_with(@forum_topic) do |fmt|
|
|
fmt.html do
|
|
flash[:notice] = "Access denied"
|
|
redirect_to forum_topics_path
|
|
end
|
|
|
|
fmt.json do
|
|
render json: nil, :status => 403
|
|
end
|
|
|
|
fmt.xml do
|
|
render xml: nil, :status => 403
|
|
end
|
|
end
|
|
|
|
return false
|
|
end
|
|
end
|
|
|
|
def check_privilege(forum_post)
|
|
if !forum_post.editable_by?(CurrentUser.user)
|
|
raise User::PrivilegeError
|
|
end
|
|
end
|
|
|
|
def forum_post_params(context)
|
|
permitted_params = [:body]
|
|
permitted_params += [:topic_id] if context == :create
|
|
|
|
params.require(:forum_post).permit(permitted_params)
|
|
end
|
|
end
|