Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
211 lines
6.3 KiB
Ruby
211 lines
6.3 KiB
Ruby
require 'test_helper'
|
|
|
|
class NoteTest < ActiveSupport::TestCase
|
|
context "In all cases" do
|
|
setup do
|
|
@user = FactoryBot.create(:user)
|
|
CurrentUser.user = @user
|
|
CurrentUser.ip_addr = "127.0.0.1"
|
|
end
|
|
|
|
teardown do
|
|
CurrentUser.user = nil
|
|
CurrentUser.ip_addr = nil
|
|
end
|
|
|
|
context "#merge_version" do
|
|
setup do
|
|
@post = FactoryBot.create(:post)
|
|
@note = FactoryBot.create(:note, :post => @post)
|
|
end
|
|
|
|
should "not increment version" do
|
|
@note.update_attributes(:x => 100)
|
|
assert_equal(1, @note.versions.count)
|
|
assert_equal(1, @note.versions.first.version)
|
|
end
|
|
end
|
|
|
|
context "for a post that already has a note" do
|
|
setup do
|
|
@post = FactoryBot.create(:post)
|
|
@note = FactoryBot.create(:note, :post => @post)
|
|
end
|
|
|
|
context "when the note is deleted the post" do
|
|
setup do
|
|
@note.toggle!(:is_active)
|
|
end
|
|
|
|
should "null out its last_noted_at_field" do
|
|
@post.reload
|
|
assert_nil(@post.last_noted_at)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "creating a note" do
|
|
setup do
|
|
@post = FactoryBot.create(:post, :image_width => 1000, :image_height => 1000)
|
|
end
|
|
|
|
should "not validate if the note is outside the image" do
|
|
@note = FactoryBot.build(:note, :x => 1001, :y => 500, :post => @post)
|
|
@note.save
|
|
assert_equal(["Note must be inside the image"], @note.errors.full_messages)
|
|
end
|
|
|
|
should "not validate if the note is larger than the image" do
|
|
@note = FactoryBot.build(:note, :x => 500, :y => 500, :height => 501, :width => 500, :post => @post)
|
|
@note.save
|
|
assert_equal(["Note must be inside the image"], @note.errors.full_messages)
|
|
end
|
|
|
|
should "not validate if the post does not exist" do
|
|
@note = FactoryBot.build(:note, :x => 500, :y => 500, :post_id => -1)
|
|
@note.save
|
|
assert_equal(["Post must exist"], @note.errors.full_messages)
|
|
end
|
|
|
|
should "not validate if the body is blank" do
|
|
@note = FactoryBot.build(:note, body: " ")
|
|
|
|
assert_equal(false, @note.valid?)
|
|
assert_equal(["Body can't be blank"], @note.errors.full_messages)
|
|
end
|
|
|
|
should "create a version" do
|
|
assert_difference("NoteVersion.count", 1) do
|
|
Timecop.travel(1.day.from_now) do
|
|
@note = FactoryBot.create(:note, :post => @post)
|
|
end
|
|
end
|
|
|
|
assert_equal(1, @note.versions.count)
|
|
assert_equal(@note.body, @note.versions.first.body)
|
|
assert_equal(1, @note.version)
|
|
assert_equal(1, @note.versions.first.version)
|
|
end
|
|
|
|
should "update the post's last_noted_at field" do
|
|
assert_nil(@post.last_noted_at)
|
|
@note = FactoryBot.create(:note, :post => @post)
|
|
@post.reload
|
|
assert_not_nil(@post.last_noted_at)
|
|
end
|
|
|
|
context "for a note-locked post" do
|
|
setup do
|
|
@post.update_attribute(:is_note_locked, true)
|
|
end
|
|
|
|
should "fail" do
|
|
assert_difference("Note.count", 0) do
|
|
@note = FactoryBot.build(:note, :post => @post)
|
|
@note.save
|
|
end
|
|
assert_equal(["Post is note locked"], @note.errors.full_messages)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "updating a note" do
|
|
setup do
|
|
@post = FactoryBot.create(:post, :image_width => 1000, :image_height => 1000)
|
|
@note = FactoryBot.create(:note, :post => @post)
|
|
@note.stubs(:merge_version?).returns(false)
|
|
end
|
|
|
|
should "increment the updater's note_update_count" do
|
|
@user.reload
|
|
assert_difference("@user.note_update_count", 1) do
|
|
@note.update_attributes(:body => "zzz")
|
|
@user.reload
|
|
end
|
|
end
|
|
|
|
should "update the post's last_noted_at field" do
|
|
assert_nil(@post.last_noted_at)
|
|
@note.update_attributes(:x => 500)
|
|
@post.reload
|
|
assert_equal(@post.last_noted_at.to_i, @note.updated_at.to_i)
|
|
end
|
|
|
|
should "create a version" do
|
|
assert_difference("NoteVersion.count", 1) do
|
|
Timecop.travel(1.day.from_now) do
|
|
@note.update_attributes(:body => "fafafa")
|
|
end
|
|
end
|
|
assert_equal(2, @note.versions.count)
|
|
assert_equal(2, @note.versions.last.version)
|
|
assert_equal("fafafa", @note.versions.last.body)
|
|
assert_equal(2, @note.version)
|
|
end
|
|
|
|
context "for a note-locked post" do
|
|
setup do
|
|
@post.update_attribute(:is_note_locked, true)
|
|
end
|
|
|
|
should "fail" do
|
|
@note.update_attributes(:x => 500)
|
|
assert_equal(["Post is note locked"], @note.errors.full_messages)
|
|
end
|
|
end
|
|
|
|
context "without making any changes" do
|
|
should "not create a new version" do
|
|
assert_no_difference("@note.versions.count") do
|
|
@note.save
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context "when notes have been vandalized by one user" do
|
|
setup do
|
|
@vandal = FactoryBot.create(:user)
|
|
@note = FactoryBot.create(:note, :x => 5, :y => 5)
|
|
CurrentUser.scoped(@vandal, "127.0.0.1") do
|
|
@note.update_attributes(:x => 10, :y => 10)
|
|
end
|
|
end
|
|
|
|
context "the act of undoing all changes by that user" do
|
|
should "revert any affected notes" do
|
|
assert_equal(2, NoteVersion.count)
|
|
assert_equal([1, 2], @note.versions.map(&:version))
|
|
assert_equal([@user.id, @vandal.id], @note.versions.map(&:updater_id))
|
|
Timecop.travel(1.day.from_now) do
|
|
Note.undo_changes_by_user(@vandal.id)
|
|
end
|
|
@note.reload
|
|
assert_equal([1, 3], @note.versions.map(&:version))
|
|
assert_equal([@user.id, @user.id], @note.versions.map(&:updater_id))
|
|
assert_equal(5, @note.x)
|
|
assert_equal(5, @note.y)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "searching for a note" do
|
|
setup do
|
|
@note = FactoryBot.create(:note, :body => "aaa")
|
|
end
|
|
|
|
context "where the body contains the string 'aaa'" do
|
|
should "return a hit" do
|
|
assert_equal(1, Note.body_matches("aaa").count)
|
|
end
|
|
end
|
|
|
|
context "where the body contains the string 'bbb'" do
|
|
should "return no hits" do
|
|
assert_equal(0, Note.body_matches("bbb").count)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|