The belongs_to_creator macro was used to initialize the creator_id field to the CurrentUser. This made tests complicated because it meant you had to create and set the current user every time you wanted to create an object, when lead to the current user being set over and over again. It also meant you had to constantly be aware of what the CurrentUser was in many different contexts, which was often confusing. Setting creators explicitly simplifies everything greatly.
35 lines
703 B
Ruby
35 lines
703 B
Ruby
class IpBansController < ApplicationController
|
|
respond_to :html, :xml, :json, :js
|
|
before_action :moderator_only
|
|
|
|
def new
|
|
@ip_ban = IpBan.new
|
|
end
|
|
|
|
def create
|
|
@ip_ban = CurrentUser.ip_bans.create(ip_ban_params)
|
|
respond_with(@ip_ban, :location => ip_bans_path)
|
|
end
|
|
|
|
def index
|
|
@ip_bans = IpBan.includes(:creator).paginated_search(params, count_pages: true)
|
|
respond_with(@ip_bans)
|
|
end
|
|
|
|
def destroy
|
|
@ip_ban = IpBan.find(params[:id])
|
|
@ip_ban.destroy
|
|
respond_with(@ip_ban)
|
|
end
|
|
|
|
private
|
|
|
|
def ip_ban_params
|
|
params.fetch(:ip_ban, {}).permit(%i[ip_addr reason])
|
|
end
|
|
|
|
def search_params
|
|
params.fetch(:search, {}).permit(%i[ip_addr order])
|
|
end
|
|
end
|