Remove the `CurrentUser.ip_addr` global variable and replace it with `request.remote_ip`. Before we had to track the current user's IP in a global variable so that when we edited a post for example, we could pass down the user's IP to the model and save it in the post_versions table. Now that we now longer save IPs in version tables, we don't need a global variable to get access to the current user's IP outside of controllers.
195 lines
6.4 KiB
Ruby
195 lines
6.4 KiB
Ruby
require 'test_helper'
|
|
|
|
class SavedSearchTest < ActiveSupport::TestCase
|
|
def setup
|
|
super
|
|
@user = FactoryBot.create(:user)
|
|
CurrentUser.user = @user
|
|
@mock_redis = MockRedis.new
|
|
SavedSearch.stubs(:redis).returns(@mock_redis)
|
|
end
|
|
|
|
def teardown
|
|
super
|
|
CurrentUser.user = nil
|
|
end
|
|
|
|
context ".labels_for" do
|
|
setup do
|
|
FactoryBot.create(:saved_search, user: @user, label_string: "blah", query: "blah")
|
|
FactoryBot.create(:saved_search, user: @user, label_string: "zah", query: "blah")
|
|
end
|
|
|
|
should "fetch the labels used by a user" do
|
|
assert_equal(%w(blah zah), SavedSearch.labels_for(@user.id))
|
|
end
|
|
end
|
|
|
|
context ".queries_for" do
|
|
setup do
|
|
FactoryBot.create(:tag_alias, antecedent_name: "bbb", consequent_name: "ccc", creator: @user)
|
|
FactoryBot.create(:saved_search, user: @user, label_string: "blah", query: "aaa")
|
|
FactoryBot.create(:saved_search, user: @user, label_string: "zah", query: "CCC BBB AAA")
|
|
FactoryBot.create(:saved_search, user: @user, label_string: "qux", query: " aaa bbb ccc ")
|
|
end
|
|
|
|
should "fetch the queries used by a user for a label" do
|
|
assert_equal(%w(aaa), SavedSearch.queries_for(@user.id, label: "blah"))
|
|
end
|
|
|
|
should "fetch the queries used by a user without a label" do
|
|
assert_equal(["aaa", "aaa ccc"], SavedSearch.queries_for(@user.id))
|
|
end
|
|
end
|
|
|
|
context ".post_ids_for" do
|
|
context "with a label" do
|
|
setup do
|
|
create(:saved_search, query: "a", labels: ["blah"], user: @user)
|
|
create(:saved_search, query: "b", labels: ["blah"], user: @user)
|
|
create(:saved_search, query: "c", labels: ["blah"], user: @user)
|
|
|
|
create(:post, tag_string: "a")
|
|
create(:post, tag_string: "b")
|
|
create(:post, tag_string: "c")
|
|
end
|
|
|
|
context "without a primed cache" do
|
|
should "return nothing" do
|
|
post_ids = SavedSearch.post_ids_for(@user.id, label: "blah")
|
|
assert_equal([], post_ids)
|
|
end
|
|
end
|
|
|
|
context "with a primed cache" do
|
|
setup do
|
|
perform_enqueued_jobs do
|
|
SavedSearch.post_ids_for(@user.id, label: "blah")
|
|
end
|
|
end
|
|
|
|
should "fetch the post ids" do
|
|
post_ids = SavedSearch.post_ids_for(@user.id, label: "blah")
|
|
assert_equal(Post.pluck(:id).sort, post_ids.sort)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "without a label" do
|
|
setup do
|
|
create(:saved_search, query: "a", user: @user)
|
|
create(:saved_search, query: "b", user: @user)
|
|
create(:saved_search, query: "c", user: @user)
|
|
|
|
create(:post, tag_string: "a")
|
|
create(:post, tag_string: "b")
|
|
create(:post, tag_string: "c")
|
|
end
|
|
|
|
context "without a primed cache" do
|
|
should "return nothing" do
|
|
post_ids = SavedSearch.post_ids_for(@user.id)
|
|
assert_equal([], post_ids)
|
|
end
|
|
end
|
|
|
|
context "with a primed cache" do
|
|
setup do
|
|
perform_enqueued_jobs do
|
|
SavedSearch.post_ids_for(@user.id)
|
|
end
|
|
end
|
|
|
|
should "fetch the post ids" do
|
|
post_ids = SavedSearch.post_ids_for(@user.id)
|
|
assert_equal(Post.pluck(:id).sort, post_ids.sort)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context "The #normalize_labels method" do
|
|
subject { build(:saved_search) }
|
|
|
|
should normalize_attribute(:labels).from(["FOO"]).to(["foo"])
|
|
should normalize_attribute(:labels).from([" foo"]).to(["foo"])
|
|
should normalize_attribute(:labels).from(["foo "]).to(["foo"])
|
|
should normalize_attribute(:labels).from(["___foo"]).to(["foo"])
|
|
should normalize_attribute(:labels).from(["foo___"]).to(["foo"])
|
|
should normalize_attribute(:labels).from(["foo\n"]).to(["foo"])
|
|
should normalize_attribute(:labels).from(["foo bar"]).to(["foo_bar"])
|
|
should normalize_attribute(:labels).from(["foo bar"]).to(["foo_bar"])
|
|
should normalize_attribute(:labels).from(["foo___bar"]).to(["foo_bar"])
|
|
should normalize_attribute(:labels).from([" _Foo Bar_ "]).to(["foo_bar"])
|
|
should normalize_attribute(:labels).from(["Я"]).to(["я"])
|
|
should normalize_attribute(:labels).from(["foo 1", "bar 2"]).to(["foo_1", "bar_2"])
|
|
should normalize_attribute(:labels).from(["foo", nil, "", " ", "bar"]).to(["foo", "bar"])
|
|
should normalize_attribute(:labels).from([nil, "", " "]).to([])
|
|
end
|
|
|
|
context "Populating a saved search" do
|
|
setup do
|
|
@saved_search = create(:saved_search, query: "bkub", user: @user)
|
|
@post = create(:post, tag_string: "bkub")
|
|
end
|
|
|
|
should "work for a single tag search" do
|
|
SavedSearch.populate("bkub")
|
|
assert_equal([@post.id], SavedSearch.post_ids_for(@user.id))
|
|
end
|
|
|
|
should "work for a tag search returning no posts" do
|
|
SavedSearch.populate("does_not_exist")
|
|
assert_equal([], SavedSearch.post_ids_for(@user.id))
|
|
end
|
|
|
|
should "not allow users to perform privileged searches" do
|
|
@flag = create(:post_flag)
|
|
@saved_search = create(:saved_search, query: "flagger:#{@flag.creator.name}", user: @user)
|
|
SavedSearch.populate("flagger:#{@flag.creator.name}")
|
|
assert_equal([], SavedSearch.post_ids_for(@user.id))
|
|
end
|
|
end
|
|
|
|
context "Creating a saved search" do
|
|
setup do
|
|
FactoryBot.create(:tag_alias, antecedent_name: "zzz", consequent_name: "yyy", creator: @user)
|
|
@saved_search = @user.saved_searches.create(query: " ZZZ xxx ")
|
|
end
|
|
|
|
should "normalize the query aside from the order" do
|
|
assert_equal("yyy xxx", @saved_search.query)
|
|
end
|
|
|
|
should "normalize the label string" do
|
|
@saved_search.label_string = "Foo Bar"
|
|
assert_equal(%w[foo bar], @saved_search.labels)
|
|
|
|
@saved_search.labels = ["Artist 1", "Artist 2"]
|
|
assert_equal(%w[artist_1 artist_2], @saved_search.labels)
|
|
end
|
|
end
|
|
|
|
context "A user with max saved searches" do
|
|
setup do
|
|
@user = create(:gold_user)
|
|
User.any_instance.stubs(:max_saved_searches).returns(1)
|
|
@ss1 = create(:saved_search, user: @user)
|
|
end
|
|
|
|
should "not be able to create another saved search" do
|
|
@ss2 = build(:saved_search, user: @user)
|
|
|
|
assert_equal(false, @ss2.valid?)
|
|
assert_equal(["You can only have up to 1 saved search"], @ss2.errors.full_messages)
|
|
end
|
|
|
|
should "be able to edit existing saved searches" do
|
|
@ss1.update!(query: "blah")
|
|
|
|
assert_equal(true, @ss1.valid?)
|
|
assert_equal("blah", @ss1.query)
|
|
end
|
|
end
|
|
end
|