a129eb4251
Don't allow wiki pages to have invalid names. This incidentally means that you can't create wiki pages for pools. For example, you can't create a wiki titled "pool:almost_heart-warming". This is not a valid tag name, so it's not a valid wiki name either. This was done in a handful of cases to translate Pixiv tags to Danbooru pools (see: <https://danbooru.donmai.us/wiki_page_versions?search[title_like]=pool:*>) Also fix it so that titles are normalized before validation, not before save.
115 lines
4.0 KiB
Ruby
115 lines
4.0 KiB
Ruby
require 'test_helper'
|
|
|
|
class WikiPageTest < ActiveSupport::TestCase
|
|
setup do
|
|
CurrentUser.ip_addr = "127.0.0.1"
|
|
end
|
|
|
|
teardown do
|
|
CurrentUser.user = nil
|
|
CurrentUser.ip_addr = nil
|
|
end
|
|
|
|
context "A wiki page" do
|
|
context "updated by a regular user" do
|
|
setup do
|
|
@user = FactoryBot.create(:user)
|
|
CurrentUser.user = @user
|
|
@wiki_page = FactoryBot.create(:wiki_page, :title => "HOT POTATO", :other_names => "foo*bar baz")
|
|
end
|
|
|
|
should "normalize its title" do
|
|
assert_equal("hot_potato", @wiki_page.title)
|
|
end
|
|
|
|
should "normalize its other names" do
|
|
@wiki_page.update(:other_names => "foo*bar baz baz 加賀（艦これ）")
|
|
assert_equal(%w[foo*bar baz 加賀(艦これ)], @wiki_page.other_names)
|
|
end
|
|
|
|
should "search by title" do
|
|
matches = WikiPage.titled("hot potato")
|
|
assert_equal(1, matches.count)
|
|
assert_equal("hot_potato", matches.first.title)
|
|
end
|
|
|
|
should "search other names with wildcards" do
|
|
matches = WikiPage.search(other_names_match: "fo*")
|
|
assert_equal([@wiki_page.id], matches.map(&:id))
|
|
end
|
|
|
|
should "create versions" do
|
|
assert_difference("WikiPageVersion.count") do
|
|
@wiki_page = FactoryBot.create(:wiki_page, :title => "xxx")
|
|
end
|
|
|
|
assert_difference("WikiPageVersion.count") do
|
|
@wiki_page.title = "yyy"
|
|
travel(1.day) do
|
|
@wiki_page.save
|
|
end
|
|
end
|
|
end
|
|
|
|
should "revert to a prior version" do
|
|
@wiki_page.title = "yyy"
|
|
travel(1.day) do
|
|
@wiki_page.save
|
|
end
|
|
version = WikiPageVersion.first
|
|
@wiki_page.revert_to!(version)
|
|
@wiki_page.reload
|
|
assert_equal("hot_potato", @wiki_page.title)
|
|
end
|
|
|
|
should "update its dtext links" do
|
|
@wiki_page.update!(body: "[[long hair]]")
|
|
assert_equal(1, @wiki_page.dtext_links.size)
|
|
assert_equal("wiki_link", @wiki_page.dtext_links.first.link_type)
|
|
assert_equal("long_hair", @wiki_page.dtext_links.first.link_target)
|
|
|
|
@wiki_page.update!(body: "http://www.google.com")
|
|
assert_equal(1, @wiki_page.dtext_links.size)
|
|
assert_equal("external_link", @wiki_page.dtext_links.first.link_type)
|
|
assert_equal("http://www.google.com", @wiki_page.dtext_links.first.link_target)
|
|
|
|
@wiki_page.update!(body: "nothing")
|
|
assert_equal(0, @wiki_page.dtext_links.size)
|
|
end
|
|
end
|
|
|
|
context "during title validation" do
|
|
# these values are allowed because they're normalized first
|
|
should allow_value(" foo ").for(:title).on(:create)
|
|
should allow_value("~foo").for(:title).on(:create)
|
|
should allow_value("_foo").for(:title).on(:create)
|
|
should allow_value("foo_").for(:title).on(:create)
|
|
should allow_value("foo__bar").for(:title).on(:create)
|
|
should allow_value("FOO").for(:title).on(:create)
|
|
should allow_value("foo bar").for(:title).on(:create)
|
|
|
|
should_not allow_value("").for(:title).on(:create)
|
|
should_not allow_value("___").for(:title).on(:create)
|
|
should_not allow_value("-foo").for(:title).on(:create)
|
|
should_not allow_value("/foo").for(:title).on(:create)
|
|
should_not allow_value("foo*bar").for(:title).on(:create)
|
|
should_not allow_value("foo,bar").for(:title).on(:create)
|
|
should_not allow_value("foo\abar").for(:title).on(:create)
|
|
should_not allow_value("café").for(:title).on(:create)
|
|
should_not allow_value("東方").for(:title).on(:create)
|
|
should_not allow_value("FAV:blah").for(:title).on(:create)
|
|
should_not allow_value("X"*171).for(:title).on(:create)
|
|
end
|
|
|
|
context "with other names" do
|
|
should "not allow artist wikis to have other names" do
|
|
tag = create(:artist_tag)
|
|
wiki = build(:wiki_page, title: tag.name, other_names: ["blah"])
|
|
|
|
assert_equal(false, wiki.valid?)
|
|
assert_equal(["An artist wiki can't have other names"], wiki.errors[:base])
|
|
end
|
|
end
|
|
end
|
|
end
|