`normalize_for_source` was used to convert image URLs to page URLs when displaying sources on the post show page. Move all the code for converting image URLs to page URLs from `Sources::Strategies#normalize_for_source` to `Source::URL#page_url`. Before we had to be very careful in source strategies not to make any network calls in `normalize_for_source`, since it was used in the view for the post show page. Now all the code for generating page URLs is isolated in Source::URL, which makes source strategies simpler. It also makes it easier to check if a source is an image URL or page URL, and if the image URL is convertible to a page URL, which will make autotagging bad_link or bad_source feasible. Finally, this fixes it to generate better page URLs in a handful of cases: * https://www.artstation.com/artwork/qPVGP instead of https://anubis1982918.artstation.com/projects/qPVGP * https://yande.re/post/show?md5=b4b1d11facd1700544554e4805d47bb6s instead of https://yande.re/post?tags=md5:b4b1d11facd1700544554e4805d47bb6 * http://gallery.minitokyo.net/view/365677 instead of http://gallery.minitokyo.net/download/365677 * https://valkyriecrusade.fandom.com/wiki/File:Crimson_Hatsune_H.png instead of https://valkyriecrusade.wikia.com/wiki/File:Crimson_Hatsune_H.png * https://rule34.paheal.net/post/view/852405 instead of https://rule34.paheal.net/post/list/md5:854806addcd3b1246424e7cea49afe31/1
63 lines
1.4 KiB
Ruby
63 lines
1.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class Source::URL::Plurk < Source::URL
|
|
attr_reader :username, :work_id
|
|
|
|
def self.match?(url)
|
|
url.domain == "plurk.com"
|
|
end
|
|
|
|
def parse
|
|
case [domain, *path_segments]
|
|
|
|
# https://images.plurk.com/5wj6WD0r6y4rLN0DL3sqag.jpg
|
|
# https://images.plurk.com/mx_5wj6WD0r6y4rLN0DL3sqag.jpg
|
|
in "plurk.com", /^(mx_)?(\w{22})\.(\w+)$/ if image_url?
|
|
@image_id = $2
|
|
|
|
# https://www.plurk.com/p/om6zv4
|
|
in "plurk.com", "p", work_id
|
|
@work_id = work_id
|
|
|
|
# https://www.plurk.com/m/p/okxzae
|
|
in "plurk.com", "m", "p", work_id
|
|
@work_id = work_id
|
|
|
|
# https://www.plurk.com/m/redeyehare
|
|
in "plurk.com", "m", username
|
|
@username = username
|
|
|
|
# https://www.plurk.com/u/ddks2923
|
|
in "plurk.com", "u", username
|
|
@username = username
|
|
|
|
# https://www.plurk.com/m/u/leiy1225
|
|
in "plurk.com", "m", "u", username
|
|
@username = username
|
|
|
|
# https://www.plurk.com/s/u/salmonroe13
|
|
in "plurk.com", "s", "u", username
|
|
@username = username
|
|
|
|
# https://www.plurk.com/redeyehare
|
|
# https://www.plurk.com/RSSSww/invite/4
|
|
in "plurk.com", username, *rest
|
|
@username = username
|
|
|
|
else
|
|
end
|
|
end
|
|
|
|
def image_url?
|
|
host == "images.plurk.com"
|
|
end
|
|
|
|
def page_url
|
|
"https://www.plurk.com/p/#{work_id}" if work_id.present?
|
|
end
|
|
|
|
def profile_url
|
|
"https://www.plurk.com/#{username}" if username.present?
|
|
end
|
|
end
|