e37844303d
In some cases we can't get the artist name from the API, either because we can't do the API call because the url doesn't contain a deviation id, or because the work is deleted: * http://fc08.deviantart.net/files/f/2007/120/c/9/cool_like_me_by_47ness.jpg (work: http://fav.me/dwcohb) * https://pre00.deviantart.net/423b/th/pre/i/2017/281/e/0/mindflayer_girl01_by_nickbeja-dbpxdt8.png (work: http://fav.me/dbpxd58) Switch to taking the artist name from the url (when present) to deal with these cases. Fixes the artist finder and the artist url normalizer to work in this situation.
234 lines
9.9 KiB
Ruby
234 lines
9.9 KiB
Ruby
require 'test_helper'
|
||
|
||
module Sources
|
||
class DeviantArtTest < ActiveSupport::TestCase
|
||
def setup
|
||
super
|
||
skip "DeviantArt API keys not set" unless Danbooru.config.deviantart_client_id.present?
|
||
end
|
||
|
||
context "A path-based artist url" do
|
||
setup do
|
||
@site = Sources::Strategies.find("https://www.deviantart.com/aeror404/art/Holiday-Elincia-424551484")
|
||
end
|
||
|
||
should "work" do
|
||
assert_equal(["http://origin-orig.deviantart.net/d533/f/2014/004/8/d/holiday_elincia_by_aeror404-d70rm0s.jpg"], @site.image_urls)
|
||
assert_equal(@site.image_url, @site.canonical_url)
|
||
assert_equal("aeror404", @site.artist_name)
|
||
assert_equal("https://www.deviantart.com/aeror404", @site.profile_url)
|
||
end
|
||
end
|
||
|
||
context "The source for a deleted DeviantArt image URL" do
|
||
should "work" do
|
||
@site = Sources::Strategies.find("https://pre00.deviantart.net/423b/th/pre/i/2017/281/e/0/mindflayer_girl01_by_nickbeja-dbpxdt8.png")
|
||
@artist = FactoryBot.create(:artist, name: "nickbeja", url_string: "https://nickbeja.deviantart.com")
|
||
|
||
assert_equal("https://pre00.deviantart.net/423b/th/pre/i/2017/281/e/0/mindflayer_girl01_by_nickbeja-dbpxdt8.png", @site.image_url)
|
||
assert_equal(@site.image_url, @site.canonical_url)
|
||
assert_equal("nickbeja", @site.artist_name)
|
||
assert_equal("https://www.deviantart.com/nickbeja", @site.profile_url)
|
||
assert_equal([@artist], @site.artists)
|
||
assert_nothing_raised { @site.to_h }
|
||
end
|
||
end
|
||
|
||
context "The source for a download-disabled DeviantArt artwork page" do
|
||
should "get the image url" do
|
||
@site = Sources::Strategies.find("https://noizave.deviantart.com/art/test-no-download-697415967")
|
||
|
||
assert_equal(["https://img00.deviantart.net/56ee/i/2017/219/2/3/test__no_download_by_noizave-dbj81lr.jpg"], @site.image_urls)
|
||
assert_equal(@site.image_url, @site.canonical_url)
|
||
end
|
||
end
|
||
|
||
context "The source for a DeviantArt image url" do
|
||
should "fetch the source data" do
|
||
@site = Sources::Strategies.find("https://pre00.deviantart.net/b5e6/th/pre/f/2016/265/3/5/legend_of_galactic_heroes_by_hideyoshi-daihpha.jpg")
|
||
|
||
assert_equal("hideyoshi", @site.artist_name)
|
||
assert_equal("https://www.deviantart.com/hideyoshi", @site.profile_url)
|
||
assert_equal("http://origin-orig.deviantart.net/9e1f/f/2016/265/3/5/legend_of_galactic_heroes_by_hideyoshi-daihpha.jpg", @site.image_url)
|
||
assert_equal(@site.image_url, @site.canonical_url)
|
||
end
|
||
end
|
||
|
||
context "The source for a origin-orig.deviantart.net image url without a referer" do
|
||
should "work" do
|
||
@site = Sources::Strategies.find("http://origin-orig.deviantart.net/7b5b/f/2017/160/c/5/test_post_please_ignore_by_noizave-dbc3a48.png")
|
||
|
||
assert_equal(@site.url, @site.image_url)
|
||
assert_equal("https://www.deviantart.com/noizave/art/test-post-please-ignore-685436408", @site.page_url)
|
||
assert_equal(@site.image_url, @site.canonical_url)
|
||
assert_equal("noizave", @site.artist_name)
|
||
assert_equal("https://www.deviantart.com/noizave", @site.profile_url)
|
||
assert_equal(%w[bar baz foo], @site.tags.map(&:first))
|
||
assert_nothing_raised { @site.to_h }
|
||
end
|
||
end
|
||
|
||
context "The source for a img00.deviantart.net sample image url" do
|
||
should "return the full size image url" do
|
||
@site = Sources::Strategies.find("https://img00.deviantart.net/a233/i/2017/160/5/1/test_post_please_ignore_by_noizave-dbc3a48.png")
|
||
assert_equal("http://origin-orig.deviantart.net/7b5b/f/2017/160/c/5/test_post_please_ignore_by_noizave-dbc3a48.png", @site.image_url)
|
||
end
|
||
end
|
||
|
||
context "The source for a th00.deviantart.net/*/PRE/* thumbnail url" do
|
||
should "return the full size image url" do
|
||
@site = Sources::Strategies.find("http://th00.deviantart.net/fs71/PRE/f/2014/065/3/b/goruto_by_xyelkiltrox-d797tit.png")
|
||
assert_equal("http://origin-orig.deviantart.net/0f1e/f/2014/065/3/b/goruto_by_xyelkiltrox-d797tit.png", @site.image_url)
|
||
end
|
||
end
|
||
|
||
context "The source for a *.deviantart.net/*/:title_by_:artist.jpg url" do
|
||
setup do
|
||
@url = "http://fc08.deviantart.net/files/f/2007/120/c/9/cool_like_me_by_47ness.jpg"
|
||
@ref = "https://47ness.deviantart.com/art/Cool-Like-Me-54339311"
|
||
@artist = FactoryBot.create(:artist, name: "47ness", url_string: "https://www.deviantart.com/47ness")
|
||
end
|
||
|
||
context "without a referer" do
|
||
should "work" do
|
||
@site = Sources::Strategies.find(@url)
|
||
|
||
assert_equal(@site.url, @site.image_url)
|
||
assert_equal("47ness", @site.artist_name)
|
||
assert_equal("https://www.deviantart.com/47ness", @site.profile_url)
|
||
assert_equal("", @site.page_url)
|
||
assert_equal(@site.image_url, @site.canonical_url)
|
||
assert_equal([@artist], @site.artists)
|
||
assert_nothing_raised { @site.to_h }
|
||
end
|
||
end
|
||
|
||
context "with a referer" do
|
||
should "work" do
|
||
@site = Sources::Strategies.find(@url, @ref)
|
||
|
||
assert_equal("http://origin-orig.deviantart.net/a418/f/2007/120/c/9/cool_like_me_by_47ness.jpg", @site.image_url)
|
||
assert_equal("47ness", @site.artist_name)
|
||
assert_equal("https://www.deviantart.com/47ness", @site.profile_url)
|
||
assert_equal("https://www.deviantart.com/47ness/art/Cool-Like-Me-54339311", @site.page_url)
|
||
assert_equal(@site.page_url, @site.canonical_url)
|
||
assert_equal([@artist], @site.artists)
|
||
assert_nothing_raised { @site.to_h }
|
||
end
|
||
end
|
||
end
|
||
|
||
context "The source for a *.deviantart.net/*/:hash.jpg url" do
|
||
setup do
|
||
@url = "http://pre06.deviantart.net/8497/th/pre/f/2009/173/c/c/cc9686111dcffffffb5fcfaf0cf069fb.jpg"
|
||
@ref = "https://www.deviantart.com/edsfox/art/Silverhawks-Quicksilver-126872896"
|
||
@artist = FactoryBot.create(:artist, name: "edsfox", url_string: "https://edsfox.deviantart.com")
|
||
end
|
||
|
||
context "without a referer" do
|
||
should "work" do
|
||
@site = Sources::Strategies.find(@url)
|
||
|
||
assert_equal(@url, @site.image_url)
|
||
assert_equal("", @site.artist_name)
|
||
assert_equal("", @site.profile_url)
|
||
assert_equal("", @site.page_url)
|
||
assert_equal(@site.image_url, @site.canonical_url)
|
||
assert_equal([], @site.artists)
|
||
assert_nothing_raised { @site.to_h }
|
||
end
|
||
end
|
||
|
||
context "with a referer" do
|
||
should "work" do
|
||
@site = Sources::Strategies.find(@url, @ref)
|
||
|
||
assert_equal("http://origin-orig.deviantart.net/66c1/f/2009/173/c/c/cc9686111dcffffffb5fcfaf0cf069fb.jpg", @site.image_url)
|
||
assert_equal("edsfox", @site.artist_name)
|
||
assert_equal("https://www.deviantart.com/edsfox", @site.profile_url)
|
||
assert_equal("https://www.deviantart.com/edsfox/art/Silverhawks-Quicksilver-126872896", @site.page_url)
|
||
assert_equal(@site.page_url, @site.canonical_url)
|
||
assert_equal([@artist], @site.artists)
|
||
assert_nothing_raised { @site.to_h }
|
||
end
|
||
end
|
||
end
|
||
|
||
context "The source for an DeviantArt artwork page" do
|
||
setup do
|
||
@site = Sources::Strategies.find("http://noizave.deviantart.com/art/test-post-please-ignore-685436408")
|
||
end
|
||
|
||
should "get the image url" do
|
||
assert_match(%r!https?://origin-orig.deviantart.net/7b5b/f/2017/160/c/5/test_post_please_ignore_by_noizave-dbc3a48.png!, @site.image_url)
|
||
end
|
||
|
||
should "get the profile" do
|
||
assert_equal("https://www.deviantart.com/noizave", @site.profile_url)
|
||
end
|
||
|
||
should "get the artist name" do
|
||
assert_equal("noizave", @site.artist_name)
|
||
end
|
||
|
||
should "get the tags" do
|
||
assert_equal(%w[bar baz foo], @site.tags.map(&:first))
|
||
end
|
||
|
||
should "get the artist commentary" do
|
||
title = "test post please ignore"
|
||
desc = "<div align=\"center\"><span>blah blah<br /><div align=\"left\"><a class=\"external\" href=\"https://www.deviantart.com/users/outgoing?http://www.google.com\">test link</a><br /></div></span></div><br /><h1>lol</h1><br /><br /><b>blah</b> <i>blah</i> <u>blah</u> <strike>blah</strike><br />herp derp<br /><br /><blockquote>this is a quote</blockquote><ol><li>one</li><li>two</li><li>three</li></ol><ul><li>one</li><li>two</li><li>three</li></ul><img src=\"https://e.deviantart.net/emoticons/h/heart.gif\" alt=\"Heart\" style=\"width: 15px; height: 13px;\" data-embed-type=\"emoticon\" data-embed-id=\"357\"> "
|
||
|
||
assert_equal(title, @site.artist_commentary_title)
|
||
assert_equal(desc, @site.artist_commentary_desc)
|
||
end
|
||
|
||
should "get the dtext-ified commentary" do
|
||
desc = <<-EOS.strip_heredoc.chomp
|
||
blah blah
|
||
"test link":[http://www.google.com]
|
||
|
||
h1. lol
|
||
|
||
|
||
|
||
[b]blah[/b] [i]blah[/i] [u]blah[/u] [s]blah[/s]
|
||
herp derp
|
||
|
||
[quote]this is a quote[/quote]
|
||
|
||
* one
|
||
* two
|
||
* three
|
||
|
||
* one
|
||
* two
|
||
* three
|
||
|
||
"Heart":[https://e.deviantart.net/emoticons/h/heart.gif]
|
||
EOS
|
||
|
||
assert_equal(desc, @site.dtext_artist_commentary_desc)
|
||
end
|
||
end
|
||
|
||
context "The source for a login-only DeviantArt artwork page" do
|
||
setup do
|
||
@site = Sources::Strategies.find("http://noizave.deviantart.com/art/hidden-work-685458369")
|
||
end
|
||
|
||
should "get the image url" do
|
||
assert_match(%r!https?://origin-orig\.deviantart\.net/cb25/f/2017/160/1/9/hidden_work_by_noizave-dbc3r29\.png!, @site.image_url)
|
||
end
|
||
end
|
||
|
||
context "A source with malformed links in the artist commentary" do
|
||
should "fix the links" do
|
||
@site = Sources::Strategies.find("https://teemutaiga.deviantart.com/art/Kisu-620666655")
|
||
|
||
assert_match(%r!"Print available at Inprnt":\[http://www.inprnt.com/gallery/teemutaiga/kisu\]!, @site.dtext_artist_commentary_desc)
|
||
end
|
||
end
|
||
end
|
||
end
|