Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
193 lines
6.0 KiB
Ruby
193 lines
6.0 KiB
Ruby
require 'test_helper'
|
|
|
|
class ForumTopicsControllerTest < ActionDispatch::IntegrationTest
|
|
context "The forum topics controller" do
|
|
setup do
|
|
@user = create(:user)
|
|
@other_user = create(:user)
|
|
@mod = create(:moderator_user)
|
|
|
|
as_user do
|
|
@forum_topic = create(:forum_topic, :title => "my forum topic", :original_post_attributes => {:body => "xxx"})
|
|
end
|
|
end
|
|
|
|
context "for a level restricted topic" do
|
|
setup do
|
|
as(@mod) do
|
|
@forum_topic.update(min_level: User::Levels::MODERATOR)
|
|
end
|
|
end
|
|
|
|
should "not allow users to see the topic" do
|
|
get_auth forum_topic_path(@forum_topic), @user
|
|
assert_redirected_to forum_topics_path
|
|
end
|
|
|
|
should "not bump the forum for users without access" do
|
|
@gold_user = create(:gold_user)
|
|
|
|
# An open topic should bump...
|
|
as(@gold_user) do
|
|
@open_topic = create(:forum_topic)
|
|
end
|
|
@gold_user.reload
|
|
as(@gold_user) do
|
|
assert(@gold_user.has_forum_been_updated?)
|
|
end
|
|
|
|
# Marking it as read should clear it...
|
|
as(@gold_user) do
|
|
post_auth mark_all_as_read_forum_topics_path, @gold_user
|
|
end
|
|
@gold_user.reload
|
|
assert_redirected_to(forum_topics_path)
|
|
as(@gold_user) do
|
|
assert(!@gold_user.has_forum_been_updated?)
|
|
end
|
|
|
|
# Then adding an unread private topic should not bump.
|
|
as(@mod) do
|
|
create(:forum_post, :topic_id => @forum_topic.id)
|
|
end
|
|
@gold_user.reload
|
|
as(@gold_user) do
|
|
assert_equal(false, @gold_user.has_forum_been_updated?)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "show action" do
|
|
should "render" do
|
|
get forum_topic_path(@forum_topic)
|
|
assert_response :success
|
|
end
|
|
|
|
should "record a topic visit for html requests" do
|
|
get_auth forum_topic_path(@forum_topic), @user
|
|
@user.reload
|
|
assert_not_nil(@user.last_forum_read_at)
|
|
end
|
|
|
|
should "not record a topic visit for non-html requests" do
|
|
get_auth forum_topic_path(@forum_topic), @user, params: {format: :json}
|
|
@user.reload
|
|
assert_nil(@user.last_forum_read_at)
|
|
end
|
|
|
|
should "render for atom feed" do
|
|
get forum_topic_path(@forum_topic), params: {:format => :atom}
|
|
assert_response :success
|
|
end
|
|
end
|
|
|
|
context "index action" do
|
|
setup do
|
|
as_user do
|
|
@topic1 = create(:forum_topic, :is_sticky => true, :original_post_attributes => {:body => "xxx"})
|
|
@topic2 = create(:forum_topic, :original_post_attributes => {:body => "xxx"})
|
|
end
|
|
end
|
|
|
|
should "list all forum topics" do
|
|
get forum_topics_path
|
|
assert_response :success
|
|
end
|
|
|
|
should "not list stickied topics first for JSON responses" do
|
|
get forum_topics_path, params: {format: :json}
|
|
forum_topics = JSON.parse(response.body)
|
|
assert_equal([@topic2.id, @topic1.id, @forum_topic.id], forum_topics.map {|t| t["id"]})
|
|
end
|
|
|
|
should "render for atom feed" do
|
|
get forum_topics_path, params: {:format => :atom}
|
|
assert_response :success
|
|
end
|
|
|
|
context "with search conditions" do
|
|
should "list all matching forum topics" do
|
|
get forum_topics_path, params: {:search => {:title_matches => "forum"}}
|
|
assert_response :success
|
|
assert_select "a.forum-post-link", @forum_topic.title
|
|
assert_select "a.forum-post-link", {count: 0, text: @topic1.title}
|
|
assert_select "a.forum-post-link", {count: 0, text: @topic2.title}
|
|
end
|
|
|
|
should "list nothing for when the search matches nothing" do
|
|
get forum_topics_path, params: {:search => {:title_matches => "bababa"}}
|
|
assert_response :success
|
|
assert_select "a.forum-post-link", {count: 0, text: @forum_topic.title}
|
|
assert_select "a.forum-post-link", {count: 0, text: @topic1.title}
|
|
assert_select "a.forum-post-link", {count: 0, text: @topic2.title}
|
|
end
|
|
end
|
|
end
|
|
|
|
context "edit action" do
|
|
should "render if the editor is the creator of the topic" do
|
|
get_auth edit_forum_topic_path(@forum_topic), @user
|
|
assert_response :success
|
|
end
|
|
|
|
should "render if the editor is a moderator" do
|
|
get_auth edit_forum_topic_path(@forum_topic), @mod
|
|
assert_response :success
|
|
end
|
|
|
|
should "fail if the editor is not the creator of the topic and is not a moderator" do
|
|
get_auth edit_forum_topic_path(@forum_topic), @other_user
|
|
assert_response(403)
|
|
end
|
|
end
|
|
|
|
context "new action" do
|
|
should "render" do
|
|
get_auth new_forum_topic_path, @user
|
|
assert_response :success
|
|
end
|
|
end
|
|
|
|
context "create action" do
|
|
should "create a new forum topic and post" do
|
|
assert_difference(["ForumPost.count", "ForumTopic.count"], 1) do
|
|
post_auth forum_topics_path, @user, params: {:forum_topic => {:title => "bababa", :original_post_attributes => {:body => "xaxaxa"}}}
|
|
end
|
|
|
|
forum_topic = ForumTopic.last
|
|
assert_redirected_to(forum_topic_path(forum_topic))
|
|
end
|
|
end
|
|
|
|
context "destroy action" do
|
|
setup do
|
|
as_user do
|
|
@post = create(:forum_post, :topic_id => @forum_topic.id)
|
|
end
|
|
end
|
|
|
|
should "destroy the topic and any associated posts" do
|
|
delete_auth forum_topic_path(@forum_topic), @mod
|
|
assert_redirected_to(forum_topic_path(@forum_topic))
|
|
@forum_topic.reload
|
|
assert(@forum_topic.is_deleted?)
|
|
end
|
|
end
|
|
|
|
context "undelete action" do
|
|
setup do
|
|
as(@mod) do
|
|
@forum_topic.update(is_deleted: true)
|
|
end
|
|
end
|
|
|
|
should "restore the topic" do
|
|
post_auth undelete_forum_topic_path(@forum_topic), @mod
|
|
assert_redirected_to(forum_topic_path(@forum_topic))
|
|
@forum_topic.reload
|
|
assert(!@forum_topic.is_deleted?)
|
|
end
|
|
end
|
|
end
|
|
end
|