Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
239 lines
7.2 KiB
Ruby
239 lines
7.2 KiB
Ruby
class ApplicationController < ActionController::Base
|
|
protect_from_forgery
|
|
helper :pagination
|
|
before_action :reset_current_user
|
|
before_action :set_current_user
|
|
after_action :reset_current_user
|
|
before_action :set_title
|
|
before_action :normalize_search
|
|
before_action :set_started_at_session
|
|
before_action :api_check
|
|
before_action :set_safe_mode
|
|
# before_action :secure_cookies_check
|
|
layout "default"
|
|
force_ssl :if => :ssl_login?
|
|
helper_method :show_moderation_notice?
|
|
before_action :enable_cors
|
|
|
|
rescue_from Exception, :with => :rescue_exception
|
|
rescue_from User::PrivilegeError, :with => :access_denied
|
|
rescue_from SessionLoader::AuthenticationFailure, :with => :authentication_failed
|
|
rescue_from Danbooru::Paginator::PaginationError, :with => :render_pagination_limit
|
|
rescue_from PG::ConnectionBad, with: :bad_db_connection
|
|
rescue_from ActionController::UnpermittedParameters, :with => :access_denied
|
|
|
|
# This is raised on requests to `/blah.js`. Rails has already rendered StaticController#not_found
|
|
# here, so calling `rescue_exception` would cause a double render error.
|
|
rescue_from ActionController::InvalidCrossOriginRequest, :with => lambda {}
|
|
|
|
protected
|
|
|
|
def show_moderation_notice?
|
|
CurrentUser.can_approve_posts? && (cookies[:moderated].blank? || Time.at(cookies[:moderated].to_i) < 20.hours.ago)
|
|
end
|
|
|
|
def ssl_login?
|
|
cookies[:ssl_login].present?
|
|
end
|
|
|
|
def enable_cors
|
|
response.headers["Access-Control-Allow-Origin"] = "*"
|
|
end
|
|
|
|
def require_reportbooru_key
|
|
unless params[:key] == Danbooru.config.reportbooru_key
|
|
render(text: "forbidden", status: 403)
|
|
return false
|
|
end
|
|
end
|
|
|
|
def bad_db_connection
|
|
respond_to do |format|
|
|
format.json do
|
|
render json: {success: false, reason: "database is unavailable"}.to_json, status: 503
|
|
end
|
|
|
|
format.html do
|
|
render template: "static/service_unavailable", status: 503
|
|
end
|
|
end
|
|
end
|
|
|
|
def api_check
|
|
if !CurrentUser.is_anonymous? && !request.get? && !request.head?
|
|
if CurrentUser.user.token_bucket.nil?
|
|
TokenBucket.create_default(CurrentUser.user)
|
|
CurrentUser.user.reload
|
|
end
|
|
|
|
throttled = CurrentUser.user.token_bucket.throttled?
|
|
headers["X-Api-Limit"] = CurrentUser.user.token_bucket.token_count.to_s
|
|
|
|
if throttled
|
|
respond_to do |format|
|
|
format.json do
|
|
render json: {success: false, reason: "too many requests"}.to_json, status: 429
|
|
end
|
|
|
|
format.xml do
|
|
render xml: {success: false, reason: "too many requests"}.to_xml(:root => "response"), status: 429
|
|
end
|
|
|
|
format.html do
|
|
render :template => "static/too_many_requests", :status => 429
|
|
end
|
|
end
|
|
|
|
return false
|
|
end
|
|
end
|
|
|
|
return true
|
|
end
|
|
|
|
def rescue_exception(exception)
|
|
@exception = exception
|
|
|
|
if Rails.env.test? && ENV["DEBUG"]
|
|
puts "---"
|
|
STDERR.puts("#{exception.class} exception thrown: #{exception.message}")
|
|
exception.backtrace.each {|x| STDERR.puts(x)}
|
|
puts "---"
|
|
end
|
|
|
|
if exception.is_a?(::ActiveRecord::StatementInvalid) && exception.to_s =~ /statement timeout/
|
|
if Rails.env.production?
|
|
NewRelic::Agent.notice_error(exception, :uri => request.original_url, :referer => request.referer, :request_params => params, :custom_params => {:user_id => CurrentUser.user.id, :user_ip_addr => CurrentUser.ip_addr})
|
|
end
|
|
|
|
@error_message = "The database timed out running your query."
|
|
render :template => "static/error", :status => 500
|
|
elsif exception.is_a?(::ActiveRecord::RecordNotFound)
|
|
@error_message = "That record was not found"
|
|
render :template => "static/error", :status => 404
|
|
elsif exception.is_a?(NotImplementedError)
|
|
flash[:notice] = "This feature isn't available: #{@exception.message}"
|
|
respond_to do |fmt|
|
|
fmt.html { redirect_to :back }
|
|
fmt.js { render nothing: true, status: 501 }
|
|
fmt.json { render template: "static/error", status: 501 }
|
|
fmt.xml { render template: "static/error", status: 501 }
|
|
end
|
|
else
|
|
render :template => "static/error", :status => 500
|
|
end
|
|
end
|
|
|
|
def render_pagination_limit
|
|
@error_message = "You can only view up to #{Danbooru.config.max_numbered_pages} pages. Please narrow your search terms."
|
|
render :template => "static/error", :status => 410
|
|
end
|
|
|
|
def authentication_failed
|
|
respond_to do |fmt|
|
|
fmt.html do
|
|
render :text => "authentication failed", :status => 401
|
|
end
|
|
|
|
fmt.xml do
|
|
render :xml => {:sucess => false, :reason => "authentication failed"}.to_xml(:root => "response"), :status => 401
|
|
end
|
|
|
|
fmt.json do
|
|
render :json => {:success => false, :reason => "authentication failed"}.to_json, :status => 401
|
|
end
|
|
end
|
|
end
|
|
|
|
def access_denied(exception = nil)
|
|
previous_url = params[:url] || request.fullpath
|
|
|
|
respond_to do |fmt|
|
|
fmt.html do
|
|
if CurrentUser.is_anonymous?
|
|
if request.get?
|
|
redirect_to new_session_path(:url => previous_url), :notice => "Access denied"
|
|
else
|
|
redirect_to new_session_path, :notice => "Access denied"
|
|
end
|
|
else
|
|
render :template => "static/access_denied", :status => 403
|
|
end
|
|
end
|
|
fmt.xml do
|
|
render :xml => {:success => false, :reason => "access denied"}.to_xml(:root => "response"), :status => 403
|
|
end
|
|
fmt.json do
|
|
render :json => {:success => false, :reason => "access denied"}.to_json, :status => 403
|
|
end
|
|
fmt.js do
|
|
render js: "", :status => 403
|
|
end
|
|
end
|
|
end
|
|
|
|
def set_current_user
|
|
session_loader = SessionLoader.new(session, cookies, request, params)
|
|
session_loader.load
|
|
end
|
|
|
|
def reset_current_user
|
|
CurrentUser.user = nil
|
|
CurrentUser.ip_addr = nil
|
|
end
|
|
|
|
def set_started_at_session
|
|
if session[:started_at].blank?
|
|
session[:started_at] = Time.now
|
|
end
|
|
end
|
|
|
|
User::Roles.each do |role|
|
|
define_method("#{role}_only") do
|
|
if !CurrentUser.user.is_banned_or_ip_banned? && CurrentUser.user.__send__("is_#{role}?")
|
|
true
|
|
else
|
|
access_denied()
|
|
false
|
|
end
|
|
end
|
|
end
|
|
|
|
def set_title
|
|
@page_title = Danbooru.config.app_name + "/#{params[:controller]}"
|
|
end
|
|
|
|
# Remove blank `search` params from the url.
|
|
#
|
|
# /tags?search[name]=touhou&search[category]=&search[order]=
|
|
# => /tags?search[name]=touhou
|
|
def normalize_search
|
|
if request.get?
|
|
if params[:search].blank?
|
|
params[:search] = ActionController::Parameters.new
|
|
end
|
|
|
|
if params[:search].is_a?(ActionController::Parameters) && params[:search].values.any?(&:blank?)
|
|
params[:search].reject! {|k,v| v.blank?}
|
|
redirect_to url_for(params: params.except(:controller, :action, :index).permit!)
|
|
end
|
|
end
|
|
end
|
|
|
|
def search_params
|
|
params.fetch(:search, {}).permit!
|
|
end
|
|
|
|
def set_safe_mode
|
|
CurrentUser.set_safe_mode(request)
|
|
end
|
|
|
|
def secure_cookies_check
|
|
if request.ssl?
|
|
Rails.application.config.session_store :cookie_store, :key => '_danbooru_session', :secure => true
|
|
else
|
|
Rails.application.config.session_store :cookie_store, :key => '_danbooru_session', :secure => false
|
|
end
|
|
end
|
|
end
|