abce4d2551
Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
83 lines
1.9 KiB
Ruby
83 lines
1.9 KiB
Ruby
class DmailsController < ApplicationController
|
|
respond_to :html, :xml, :json
|
|
before_action :member_only, except: [:index, :show, :destroy, :mark_all_as_read]
|
|
before_action :gold_only, only: [:ham, :spam]
|
|
|
|
def new
|
|
if params[:respond_to_id]
|
|
parent = Dmail.find(params[:respond_to_id])
|
|
check_privilege(parent)
|
|
@dmail = parent.build_response(:forward => params[:forward])
|
|
else
|
|
@dmail = Dmail.new(create_params)
|
|
end
|
|
|
|
respond_with(@dmail)
|
|
end
|
|
|
|
def index
|
|
if params[:folder] && params[:set_default_folder]
|
|
cookies.permanent[:dmail_folder] = params[:folder]
|
|
end
|
|
@query = Dmail.active.visible.search(search_params)
|
|
@dmails = @query.paginate(params[:page], :limit => params[:limit])
|
|
respond_with(@dmails) do |format|
|
|
format.xml do
|
|
render :xml => @dmails.to_xml(:root => "dmails")
|
|
end
|
|
end
|
|
end
|
|
|
|
def show
|
|
@dmail = Dmail.find(params[:id])
|
|
check_privilege(@dmail)
|
|
@dmail.mark_as_read!
|
|
respond_with(@dmail)
|
|
end
|
|
|
|
def create
|
|
@dmail = Dmail.create_split(create_params)
|
|
respond_with(@dmail)
|
|
end
|
|
|
|
def destroy
|
|
@dmail = Dmail.find(params[:id])
|
|
check_privilege(@dmail)
|
|
@dmail.mark_as_read!
|
|
@dmail.destroy
|
|
redirect_to dmails_path, :notice => "Message destroyed"
|
|
end
|
|
|
|
def mark_all_as_read
|
|
Dmail.visible.unread.each do |x|
|
|
x.update_column(:is_read, true)
|
|
end
|
|
CurrentUser.user.has_mail = false
|
|
CurrentUser.user.save
|
|
end
|
|
|
|
def spam
|
|
@dmail = Dmail.find(params[:id])
|
|
@dmail.update_column(:is_spam, true)
|
|
@dmail.spam!
|
|
end
|
|
|
|
def ham
|
|
@dmail = Dmail.find(params[:id])
|
|
@dmail.update_column(:is_spam, false)
|
|
@dmail.ham!
|
|
end
|
|
|
|
private
|
|
|
|
def check_privilege(dmail)
|
|
if !dmail.visible_to?(CurrentUser.user, params[:key])
|
|
raise User::PrivilegeError
|
|
end
|
|
end
|
|
|
|
def create_params
|
|
params.fetch(:dmail, {}).permit(:title, :body, :to_name, :to_id)
|
|
end
|
|
end
|