abce4d2551
Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
57 lines
1.7 KiB
Ruby
57 lines
1.7 KiB
Ruby
require 'test_helper'
|
|
|
|
class PoolElementsControllerTest < ActionDispatch::IntegrationTest
|
|
context "The pools posts controller" do
|
|
setup do
|
|
mock_pool_archive_service!
|
|
start_pool_archive_transaction
|
|
@user = travel_to(1.month.ago) {create(:user)}
|
|
@mod = create(:moderator_user)
|
|
as_user do
|
|
@post = create(:post)
|
|
@pool = create(:pool, :name => "abc")
|
|
end
|
|
end
|
|
|
|
teardown do
|
|
rollback_pool_archive_transaction
|
|
end
|
|
|
|
context "create action" do
|
|
should "add a post to a pool" do
|
|
post_auth pool_element_path, @user, params: {:pool_id => @pool.id, :post_id => @post.id, :format => "json"}
|
|
@pool.reload
|
|
assert_equal([@post.id], @pool.post_id_array)
|
|
end
|
|
|
|
should "add a post to a pool once and only once" do
|
|
@pool.add!(@post)
|
|
post_auth pool_element_path, @user, params: {:pool_id => @pool.id, :post_id => @post.id, :format => "json"}
|
|
@pool.reload
|
|
assert_equal([@post.id], @pool.post_id_array)
|
|
end
|
|
end
|
|
|
|
context "destroy action" do
|
|
setup do
|
|
@pool.add!(@post)
|
|
end
|
|
|
|
should "remove a post from a pool" do
|
|
delete_auth pool_element_path, @user, params: {:pool_id => @pool.id, :post_id => @post.id, :format => "json"}
|
|
@pool.reload
|
|
assert_equal([], @pool.post_id_array)
|
|
end
|
|
|
|
should "do nothing if the post is not a member of the pool" do
|
|
as_user do
|
|
@pool.remove!(@post)
|
|
end
|
|
delete_auth pool_element_path, @user, params: {:pool_id => @pool.id, :post_id => @post.id, :format => "json"}
|
|
@pool.reload
|
|
assert_equal([], @pool.post_id_array)
|
|
end
|
|
end
|
|
end
|
|
end
|