abce4d2551
Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
84 lines
2.3 KiB
Ruby
84 lines
2.3 KiB
Ruby
require 'test_helper'
|
|
|
|
class CurrentUserTest < ActiveSupport::TestCase
|
|
setup do
|
|
CurrentUser.user = nil
|
|
CurrentUser.ip_addr = nil
|
|
end
|
|
|
|
teardown do
|
|
Thread.current[:safe_mode] = false
|
|
end
|
|
|
|
context ".safe_mode?" do
|
|
should "return true if the host contains the string host" do
|
|
req = mock()
|
|
req.stubs(:host).returns("safebooru")
|
|
req.stubs(:params).returns({})
|
|
CurrentUser.set_safe_mode(req)
|
|
assert_equal(true, CurrentUser.safe_mode?)
|
|
end
|
|
|
|
should "return false if the host does not contain the string host" do
|
|
req = mock()
|
|
req.stubs(:host).returns("danbooru")
|
|
req.stubs(:params).returns({})
|
|
CurrentUser.user = FactoryBot.create(:user)
|
|
CurrentUser.set_safe_mode(req)
|
|
assert_equal(false, CurrentUser.safe_mode?)
|
|
end
|
|
|
|
should "return true if the user has enabled the safe mode account setting" do
|
|
req = mock
|
|
req.stubs(:host).returns("danbooru")
|
|
req.stubs(:params).returns({})
|
|
|
|
CurrentUser.user = FactoryBot.create(:user, enable_safe_mode: true)
|
|
CurrentUser.set_safe_mode(req)
|
|
|
|
assert_equal(true, CurrentUser.safe_mode?)
|
|
end
|
|
end
|
|
|
|
context "The current user" do
|
|
should "be set only within the scope of the block" do
|
|
user = FactoryBot.create(:user)
|
|
|
|
assert_nil(CurrentUser.user)
|
|
assert_nil(CurrentUser.ip_addr)
|
|
|
|
CurrentUser.user = user
|
|
CurrentUser.ip_addr = "1.2.3.4"
|
|
|
|
assert_not_nil(CurrentUser.user)
|
|
assert_equal(user.id, CurrentUser.user.id)
|
|
assert_equal("1.2.3.4", CurrentUser.ip_addr)
|
|
end
|
|
end
|
|
|
|
context "A scoped current user" do
|
|
should "reset the current user after the block has exited" do
|
|
user1 = FactoryBot.create(:user)
|
|
user2 = FactoryBot.create(:user)
|
|
CurrentUser.user = user1
|
|
CurrentUser.scoped(user2, nil) do
|
|
assert_equal(user2.id, CurrentUser.user.id)
|
|
end
|
|
assert_equal(user1.id, CurrentUser.user.id)
|
|
end
|
|
|
|
should "reset the current user even if an exception is thrown" do
|
|
user1 = FactoryBot.create(:user)
|
|
user2 = FactoryBot.create(:user)
|
|
CurrentUser.user = user1
|
|
assert_raises(RuntimeError) do
|
|
CurrentUser.scoped(user2, nil) do
|
|
assert_equal(user2.id, CurrentUser.user.id)
|
|
raise "ERROR"
|
|
end
|
|
end
|
|
assert_equal(user1.id, CurrentUser.user.id)
|
|
end
|
|
end
|
|
end
|