Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
125 lines
4.2 KiB
Ruby
125 lines
4.2 KiB
Ruby
require 'test_helper'
|
|
|
|
class StorageManagerTest < ActiveSupport::TestCase
|
|
BASE_DIR = "#{Rails.root}/tmp/test-storage"
|
|
|
|
setup do
|
|
CurrentUser.ip_addr = "127.0.0.1"
|
|
end
|
|
|
|
context "StorageManager::Local" do
|
|
setup do
|
|
@storage_manager = StorageManager::Local.new(base_dir: BASE_DIR, base_url: "/data")
|
|
end
|
|
|
|
teardown do
|
|
FileUtils.rm_rf(BASE_DIR)
|
|
end
|
|
|
|
context "#store method" do
|
|
should "store the file" do
|
|
@storage_manager.store(StringIO.new("data"), "#{BASE_DIR}/test.txt")
|
|
|
|
assert("data", File.read("#{BASE_DIR}/test.txt"))
|
|
end
|
|
|
|
should "overwrite the file if it already exists" do
|
|
@storage_manager.store(StringIO.new("foo"), "#{BASE_DIR}/test.txt")
|
|
@storage_manager.store(StringIO.new("bar"), "#{BASE_DIR}/test.txt")
|
|
|
|
assert("bar", File.read("#{BASE_DIR}/test.txt"))
|
|
end
|
|
end
|
|
|
|
context "#delete method" do
|
|
should "delete the file" do
|
|
@storage_manager.store(StringIO.new("data"), "test.txt")
|
|
@storage_manager.delete("test.txt")
|
|
|
|
assert_not(File.exist?("#{BASE_DIR}/test.txt"))
|
|
end
|
|
|
|
should "not fail if the file doesn't exist" do
|
|
assert_nothing_raised { @storage_manager.delete("dne.txt") }
|
|
end
|
|
end
|
|
|
|
context "#store_file and #delete_file methods" do
|
|
setup do
|
|
@post = FactoryBot.create(:post, file_ext: "png")
|
|
|
|
@storage_manager.store_file(StringIO.new("data"), @post, :preview)
|
|
@storage_manager.store_file(StringIO.new("data"), @post, :large)
|
|
@storage_manager.store_file(StringIO.new("data"), @post, :original)
|
|
|
|
@file_path = "#{BASE_DIR}/preview/#{@post.md5}.jpg"
|
|
@large_file_path = "#{BASE_DIR}/sample/sample-#{@post.md5}.jpg"
|
|
@preview_file_path = "#{BASE_DIR}/#{@post.md5}.#{@post.file_ext}"
|
|
end
|
|
|
|
should "store the files at the correct path" do
|
|
assert(File.exist?(@file_path))
|
|
assert(File.exist?(@large_file_path))
|
|
assert(File.exist?(@preview_file_path))
|
|
end
|
|
|
|
should "delete the files" do
|
|
@storage_manager.delete_file(@post.id, @post.md5, @post.file_ext, :preview)
|
|
@storage_manager.delete_file(@post.id, @post.md5, @post.file_ext, :large)
|
|
@storage_manager.delete_file(@post.id, @post.md5, @post.file_ext, :original)
|
|
|
|
assert_not(File.exist?(@file_path))
|
|
assert_not(File.exist?(@large_file_path))
|
|
assert_not(File.exist?(@preview_file_path))
|
|
end
|
|
end
|
|
|
|
context "#file_url method" do
|
|
should "return the correct urls" do
|
|
@post = FactoryBot.create(:post, file_ext: "png")
|
|
@storage_manager.stubs(:tagged_filenames).returns(false)
|
|
|
|
assert_equal("/data/#{@post.md5}.png", @storage_manager.file_url(@post, :original))
|
|
assert_equal("/data/sample/sample-#{@post.md5}.jpg", @storage_manager.file_url(@post, :large))
|
|
assert_equal("/data/preview/#{@post.md5}.jpg", @storage_manager.file_url(@post, :preview))
|
|
end
|
|
end
|
|
end
|
|
|
|
context "StorageManager::Hybrid" do
|
|
setup do
|
|
@post1 = FactoryBot.build(:post, id: 1, file_ext: "png")
|
|
@post2 = FactoryBot.build(:post, id: 2, file_ext: "png")
|
|
|
|
@storage_manager = StorageManager::Hybrid.new do |id, md5, file_ext, type|
|
|
if id.odd?
|
|
StorageManager::Local.new(base_dir: "#{BASE_DIR}/i1", base_url: "/i1")
|
|
else
|
|
StorageManager::Local.new(base_dir: "#{BASE_DIR}/i2", base_url: "/i2")
|
|
end
|
|
end
|
|
end
|
|
|
|
teardown do
|
|
FileUtils.rm_rf(BASE_DIR)
|
|
end
|
|
|
|
context "#store_file method" do
|
|
should "store odd-numbered posts under /i1 and even-numbered posts under /i2" do
|
|
@storage_manager.store_file(StringIO.new("post1"), @post1, :original)
|
|
@storage_manager.store_file(StringIO.new("post2"), @post2, :original)
|
|
|
|
assert(File.exist?("#{BASE_DIR}/i1/#{@post1.md5}.png"))
|
|
assert(File.exist?("#{BASE_DIR}/i2/#{@post2.md5}.png"))
|
|
end
|
|
end
|
|
|
|
context "#file_url method" do
|
|
should "generate /i1 urls for odd posts and /i2 urls for even posts" do
|
|
assert_equal("/i1/#{@post1.md5}.png", @storage_manager.file_url(@post1, :original))
|
|
assert_equal("/i2/#{@post2.md5}.png", @storage_manager.file_url(@post2, :original))
|
|
end
|
|
end
|
|
end
|
|
end
|