1653392361
Stop updating the fav_string attribute on posts. The column still exists on the table, but is no longer used or updated. Like the pool_string in7d503f08, the fav_string was used in the past to facilitate `fav:X` searches. Posts had a hidden fav_string column that contained a list of every user who favorited the post. These were treated like fake hidden tags on the post so that a search for `fav:X` was treated like a tag search. The fav_string attribute has been unused for search purposes for a while now. It was only kept because of technicalities that required departitioning the favorites table first (340e1008e) before it could be removed. Basically, removing favorites with `@favorite.destroy` was slow because Rails always deletes object by ID, but we didn't have an index on favorites.id, and we couldn't easily add one until the favorites table was departitioned. Fixes #4652. See https://github.com/danbooru/danbooru/issues/4652#issuecomment-754993802 for more discussion of issues caused by the fav_string (in short: write amplification, post table bloat, and favorite inconsistency problems).
85 lines
3.1 KiB
Ruby
85 lines
3.1 KiB
Ruby
require 'test_helper'
|
|
|
|
class FavoritesControllerTest < ActionDispatch::IntegrationTest
|
|
context "The favorites controller" do
|
|
setup do
|
|
@user = create(:user)
|
|
@post = create(:post)
|
|
@faved_post = create(:post)
|
|
create(:favorite, post: @faved_post, user: @user)
|
|
end
|
|
|
|
context "index action" do
|
|
should "redirect the user_id param to an ordfav: search" do
|
|
get favorites_path(user_id: @user.id)
|
|
assert_redirected_to posts_path(tags: "ordfav:#{@user.name}", format: "html")
|
|
end
|
|
|
|
should "redirect members to an ordfav: search" do
|
|
get_auth favorites_path, @user
|
|
assert_redirected_to posts_path(tags: "ordfav:#{@user.name}", format: "html")
|
|
end
|
|
|
|
should "redirect anonymous users to the posts index" do
|
|
get favorites_path
|
|
assert_redirected_to posts_path(format: "html")
|
|
end
|
|
|
|
should "render for json" do
|
|
get favorites_path, as: :json
|
|
assert_response :success
|
|
end
|
|
end
|
|
|
|
context "create action" do
|
|
should "create a favorite for the current user" do
|
|
assert_difference [-> { @post.favorites.count }, -> { @post.reload.fav_count }, -> { @user.reload.favorite_count }], 1 do
|
|
post_auth favorites_path(post_id: @post.id), @user, as: :javascript
|
|
assert_response :redirect
|
|
end
|
|
end
|
|
|
|
should "not allow creating duplicate favorites" do
|
|
create(:favorite, post: @post, user: @user)
|
|
|
|
assert_no_difference [-> { @post.favorites.count }, -> { @post.reload.fav_count }, -> { @user.reload.favorite_count }] do
|
|
post_auth favorites_path(post_id: @post.id), @user, as: :javascript
|
|
assert_response :redirect
|
|
end
|
|
end
|
|
|
|
should "allow banned users to create favorites" do
|
|
@banned_user = create(:banned_user)
|
|
|
|
assert_difference [-> { @post.favorites.count }, -> { @post.reload.fav_count }, -> { @banned_user.reload.favorite_count }], 1 do
|
|
post_auth favorites_path(post_id: @post.id), @banned_user, as: :javascript
|
|
assert_response :redirect
|
|
end
|
|
end
|
|
|
|
should "not allow anonymous users to create favorites" do
|
|
assert_no_difference [-> { @post.favorites.count }, -> { @post.reload.fav_count }] do
|
|
post favorites_path(post_id: @post.id), as: :javascript
|
|
assert_response 403
|
|
end
|
|
end
|
|
end
|
|
|
|
context "destroy action" do
|
|
should "remove the favorite for the current user" do
|
|
assert_difference [-> { @faved_post.favorites.count }, -> { @faved_post.reload.fav_count }, -> { @user.reload.favorite_count }], -1 do
|
|
delete_auth favorite_path(@faved_post.id), @user, as: :javascript
|
|
assert_response :redirect
|
|
end
|
|
end
|
|
|
|
should "allow banned users to destroy favorites" do
|
|
assert_difference [-> { @faved_post.favorites.count }, -> { @faved_post.reload.fav_count }, -> { @user.reload.favorite_count }], -1 do
|
|
delete_auth favorite_path(@faved_post.id), @user, as: :javascript
|
|
assert_response :redirect
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|