b4ce2d83a6
The belongs_to_creator macro was used to initialize the creator_id field to the CurrentUser. This made tests complicated because it meant you had to create and set the current user every time you wanted to create an object, when lead to the current user being set over and over again. It also meant you had to constantly be aware of what the CurrentUser was in many different contexts, which was often confusing. Setting creators explicitly simplifies everything greatly.
238 lines
8.1 KiB
Ruby
238 lines
8.1 KiB
Ruby
require 'test_helper'
|
|
|
|
class CommentsControllerTest < ActionDispatch::IntegrationTest
|
|
context "A comments controller" do
|
|
setup do
|
|
@mod = FactoryBot.create(:moderator_user)
|
|
@user = FactoryBot.create(:member_user)
|
|
@post = create(:post)
|
|
|
|
CurrentUser.user = @user
|
|
CurrentUser.ip_addr = "127.0.0.1"
|
|
Danbooru.config.stubs(:member_comment_time_threshold).returns(1.week.from_now)
|
|
Danbooru.config.stubs(:member_comment_limit).returns(100)
|
|
end
|
|
|
|
teardown do
|
|
CurrentUser.user = nil
|
|
CurrentUser.ip_addr = nil
|
|
end
|
|
|
|
context "index action" do
|
|
context "grouped by post" do
|
|
should "render all comments for .js" do
|
|
get comments_path(post_id: @post.id), xhr: true
|
|
|
|
assert_response :success
|
|
assert_equal("text/javascript", response.media_type)
|
|
end
|
|
|
|
should "show posts with visible comments" do
|
|
@comment = as(@user) { create(:comment, post: @post) }
|
|
get comments_path(group_by: "post")
|
|
|
|
assert_response :success
|
|
assert_select "#post_#{@post.id}", 1
|
|
assert_select "#post_#{@post.id} .comment", 1
|
|
assert_select "#post_#{@post.id} #show-all-comments-link", 0
|
|
end
|
|
|
|
should "show the 'Show hidden comments' link on posts with thresholded comments" do
|
|
as(@user) { create(:comment, post: @post, score: -10) }
|
|
get comments_path(group_by: "post")
|
|
|
|
assert_response :success
|
|
assert_select "#post_#{@post.id}", 1
|
|
assert_select "#post_#{@post.id} #show-all-comments-link", /Show 1 hidden comment/
|
|
assert_select "#post_#{@post.id} .comment", 0
|
|
assert_select "#post_#{@post.id} .list-of-comments", /There are no visible comments/
|
|
end
|
|
|
|
should "not show the 'Show hidden comments' link on posts with deleted comments to Members" do
|
|
@comment1 = as(@user) { create(:comment, post: @post) }
|
|
@comment2 = as(@user) { create(:comment, post: @post, is_deleted: true) }
|
|
get comments_path(group_by: "post")
|
|
|
|
assert_response :success
|
|
assert_select "#post_#{@post.id}", 1
|
|
assert_select "#post_#{@post.id} .comment", 1
|
|
assert_select "#post_#{@post.id} #show-all-comments-link", 0
|
|
end
|
|
|
|
should "show the 'Show hidden comments' link on posts with deleted comments to Moderators" do
|
|
@comment1 = as(@user) { create(:comment, post: @post) }
|
|
@comment2 = as(@user) { create(:comment, post: @post, is_deleted: true) }
|
|
get_auth comments_path(group_by: "post"), @mod
|
|
|
|
assert_response :success
|
|
assert_select "#post_#{@post.id}", 1
|
|
assert_select "#post_#{@post.id} .comment", 1
|
|
assert_select "#post_#{@post.id} #show-all-comments-link", /Show 1 hidden comment/
|
|
end
|
|
|
|
should "not bump posts with nonbumping comments" do
|
|
as(@user) { create(:comment, post: @post, do_not_bump_post: true) }
|
|
get comments_path(group_by: "post")
|
|
|
|
assert_response :success
|
|
assert_select "#post_#{@post.id}", 0
|
|
end
|
|
|
|
should "not bump posts with only deleted comments" do
|
|
as(@user) { create(:comment, post: @post, is_deleted: true) }
|
|
get comments_path(group_by: "post")
|
|
|
|
assert_response :success
|
|
assert_select "#post_#{@post.id}", 0
|
|
end
|
|
end
|
|
|
|
should "render by comment" do
|
|
get comments_path(group_by: "comment")
|
|
assert_response :success
|
|
end
|
|
|
|
should "render for atom feeds" do
|
|
get comments_path(format: "atom")
|
|
assert_response :success
|
|
end
|
|
end
|
|
|
|
context "search action" do
|
|
should "render" do
|
|
@comment = create(:comment, post: @post)
|
|
get search_comments_path
|
|
assert_response :success
|
|
end
|
|
end
|
|
|
|
context "show action" do
|
|
should "render" do
|
|
@comment = create(:comment, post: @post)
|
|
get comment_path(@comment.id)
|
|
assert_redirected_to post_path(@comment.post, anchor: "comment_#{@comment.id}")
|
|
end
|
|
end
|
|
|
|
context "edit action" do
|
|
should "render" do
|
|
@comment = create(:comment, post: @post)
|
|
get_auth edit_comment_path(@comment.id), @user
|
|
assert_response :success
|
|
end
|
|
end
|
|
|
|
context "update action" do
|
|
setup do
|
|
@comment = create(:comment, post: @post)
|
|
end
|
|
|
|
context "when updating another user's comment" do
|
|
should "succeed if updater is a moderator" do
|
|
put_auth comment_path(@comment.id), @user, params: {comment: {body: "abc"}}
|
|
assert_equal("abc", @comment.reload.body)
|
|
assert_redirected_to post_path(@comment.post)
|
|
end
|
|
|
|
should "fail if updater is not a moderator" do
|
|
@mod_comment = as(@mod) { create(:comment, post: @post) }
|
|
put_auth comment_path(@mod_comment.id), @user, params: {comment: {body: "abc"}}
|
|
assert_not_equal("abc", @mod_comment.reload.body)
|
|
assert_response 403
|
|
end
|
|
end
|
|
|
|
context "when stickying a comment" do
|
|
should "succeed if updater is a moderator" do
|
|
put_auth comment_path(@comment.id), @mod, params: {comment: {is_sticky: true}}
|
|
assert_equal(true, @comment.reload.is_sticky)
|
|
assert_redirected_to @comment.post
|
|
end
|
|
|
|
should "fail if updater is not a moderator" do
|
|
put_auth comment_path(@comment.id), @user, params: {comment: {is_sticky: true}}
|
|
assert_equal(false, @comment.reload.is_sticky)
|
|
end
|
|
end
|
|
|
|
should "update the body" do
|
|
put_auth comment_path(@comment.id), @user, params: {comment: {body: "abc"}}
|
|
assert_equal("abc", @comment.reload.body)
|
|
assert_redirected_to post_path(@comment.post)
|
|
end
|
|
|
|
should "allow changing the body and is_deleted" do
|
|
put_auth comment_path(@comment.id), @user, params: {comment: {body: "herp derp", is_deleted: true}}
|
|
assert_equal("herp derp", @comment.reload.body)
|
|
assert_equal(true, @comment.is_deleted)
|
|
assert_redirected_to post_path(@post)
|
|
end
|
|
|
|
should "not allow changing do_not_bump_post or post_id" do
|
|
as_user do
|
|
@another_post = create(:post)
|
|
end
|
|
put_auth comment_path(@comment.id), @comment.creator, params: {do_not_bump_post: true, post_id: @another_post.id}
|
|
assert_equal(false, @comment.reload.do_not_bump_post)
|
|
assert_equal(@post.id, @comment.post_id)
|
|
end
|
|
end
|
|
|
|
context "new action" do
|
|
should "redirect" do
|
|
get_auth new_comment_path, @user
|
|
assert_response :success
|
|
end
|
|
end
|
|
|
|
context "create action" do
|
|
should "create a comment" do
|
|
assert_difference("Comment.count", 1) do
|
|
post_auth comments_path, @user, params: { comment: { post_id: @post.id, body: "blah" } }
|
|
end
|
|
comment = Comment.last
|
|
assert_redirected_to post_path(comment.post)
|
|
end
|
|
|
|
should "not allow commenting on nonexistent posts" do
|
|
assert_difference("Comment.count", 0) do
|
|
post_auth comments_path, @user, params: { comment: { post_id: -1, body: "blah" } }
|
|
end
|
|
assert_redirected_to comments_path
|
|
end
|
|
end
|
|
|
|
context "destroy action" do
|
|
should "mark comment as deleted" do
|
|
@comment = create(:comment, post: @post)
|
|
delete_auth comment_path(@comment.id), @user
|
|
|
|
assert_equal(true, @comment.reload.is_deleted)
|
|
assert_redirected_to @comment
|
|
end
|
|
end
|
|
|
|
context "undelete action" do
|
|
should "mark comment as undeleted" do
|
|
@comment = create(:comment, post: @post, is_deleted: true)
|
|
post_auth undelete_comment_path(@comment.id), @user
|
|
|
|
assert_equal(false, @comment.reload.is_deleted)
|
|
assert_redirected_to(@comment)
|
|
end
|
|
|
|
should "not allow undeleting comments deleted by a moderator" do
|
|
@comment = create(:comment, post: @post)
|
|
|
|
delete_auth comment_path(@comment.id), @mod
|
|
assert_redirected_to @comment
|
|
assert(@comment.reload.is_deleted?)
|
|
|
|
post_auth undelete_comment_path(@comment.id), @user
|
|
assert_response 403
|
|
assert(@comment.reload.is_deleted?)
|
|
end
|
|
end
|
|
end
|
|
end
|