evazion 83915a5d46 modqueue: avoid N+1 queries for disapprovals, uploaders. ...

Fixes an N+1 queries problem in the /moderator/post/queue view by
prefetching disapprovals and uploaders.

Also the way disapproval messages were previously rendered triggered a bunch
of sql queries for each post:

    SELECT COUNT(*) FROM "post_disapprovals" WHERE "post_disapprovals"."post_id" = $1 [["post_id", 52]]
    SELECT COUNT(*) FROM "post_disapprovals" WHERE "post_disapprovals"."post_id" = $1 AND "post_disapprovals"."reason" = $2  [["post_id", 52], ["reason", "breaks_rules"]]
    SELECT COUNT(*) FROM "post_disapprovals" WHERE "post_disapprovals"."post_id" = $1 AND "post_disapprovals"."reason" = $2  [["post_id", 52], ["reason", "poor_quality"]]
    SELECT COUNT(*) FROM "post_disapprovals" WHERE "post_disapprovals"."post_id" = $1 AND "post_disapprovals"."reason" IN ('disinterest', 'legacy')  [["post_id", 52]]
    SELECT COUNT(*) FROM "post_disapprovals" WHERE "post_disapprovals"."post_id" = $1 AND (message is not null and message <> '')  [["post_id", 52]]
    SELECT "post_disapprovals".* FROM "post_disapprovals" WHERE "post_disapprovals"."post_id" = $1 AND (message is not null and message <> '')  [["post_id", 52]]

This refactors to bring it down to one:

    SELECT "post_disapprovals".* FROM "post_disapprovals" WHERE "post_disapprovals"."post_id" = $1  [["post_id", 52]]

2017-02-24 21:03:14 -06:00

..

admin

fixes #2876: Changing approver/contributor privileges should log mod action

2017-02-14 12:46:54 -08:00

concerns/saved_searches

Fix #2795: "check_availability" bug with saved searches.

2016-12-22 21:44:35 -06:00

explore

track searches that return no results

2016-02-02 16:25:14 -08:00

maintenance/user

Fix #2785: Allow changing API key; require password to view or change key.

2016-12-18 06:30:48 -06:00

mobile

fixes #2432, fix tests

2015-07-14 15:13:04 -07:00

moderator

modqueue: avoid N+1 queries for disapprovals, uploaders.

2017-02-24 21:03:14 -06:00

application_controller.rb

fixes #2822: Post vote API: returns 200 for both success and failure; fixes bug with x-api-limit header

2017-01-09 17:31:14 -08:00

artist_commentaries_controller.rb

Add more artist commentary API endpoints.

2016-12-27 06:01:22 +00:00

artist_commentary_versions_controller.rb

Add artist commentary, fixes #2024

2013-11-19 10:37:02 -05:00

artist_versions_controller.rb

fix #2783: Unhide /artist_versions for members

2016-12-05 15:55:02 -08:00

artists_controller.rb

Prevent reverting to foreign versions (fixes #2711).

2016-10-11 06:57:46 +00:00

bans_controller.rb

Add missing JSON/XML responses.

2016-10-17 05:57:05 -05:00

bulk_update_requests_controller.rb

Set approver of aliases/implications in BURs.

2016-10-26 21:52:19 -05:00

comment_votes_controller.rb

fix tests

2017-01-24 16:05:06 -08:00

comments_controller.rb

/comments?group_by=comment: add is_sticky/is_deleted/do_not_bump_post/order params.

2017-01-23 22:13:00 -06:00

counts_controller.rb

fixes #1924

2014-05-30 00:02:23 -04:00

delayed_jobs_controller.rb

Add /delayed_jobs.json.

2016-10-17 05:57:05 -05:00

dmails_controller.rb

dmails_controller.rb: convert to strong params.

2017-02-23 22:51:17 -06:00

dtext_previews_controller.rb

enable ragel parser in more places

2016-06-22 16:31:25 -07:00

favorite_group_orders_controller.rb

Add order page for favgroups

2015-06-30 10:02:07 -04:00

favorite_groups_controller.rb

Add key shortcut to add to favgroup

2015-07-01 11:16:07 -04:00

favorites_controller.rb

implement token bucket rate limiting

2017-01-09 17:31:14 -08:00

forum_posts_controller.rb

Final fix for #2658 - close exploit with "new".

2017-01-16 19:34:31 +05:00

forum_topics_controller.rb

skip api check for forum and comment endpoints

2017-01-10 15:06:34 -08:00

ip_bans_controller.rb

Another partial fix for issue #2824, which also affected ip bans and feedback

2017-01-09 13:57:16 +05:00

iqdb_queries_controller.rb

remove old iqdb code

2016-12-02 13:21:56 -08:00

janitor_trials_controller.rb

add limit parameter to everything

2013-05-15 01:01:19 -04:00

legacy_controller.rb

fixes #2432, fix tests

2015-07-14 15:13:04 -07:00

meta_searches_controller.rb

fixes #1227

2014-02-28 16:40:11 -08:00

mod_actions_controller.rb

Add missing JSON/XML responses.

2016-10-17 05:57:05 -05:00

news_updates_controller.rb

add limit parameter to everything

2013-05-15 01:01:19 -04:00

note_previews_controller.rb

fixes #1504

2013-05-08 08:57:50 -04:00

note_versions_controller.rb

Make more pages publicly accessible to logged out users.

2016-10-17 05:57:05 -05:00

notes_controller.rb

Remove unused NotesController#pass_html_id.

2016-10-31 01:37:49 +00:00

pool_elements_controller.rb

Better error when trying to add to nonexistent pool

2015-11-03 23:31:19 -05:00

pool_orders_controller.rb

Fixes #28: Pool reording does not work

2011-09-13 13:28:33 -04:00

pool_versions_controller.rb

fixes #2869: Add way to differentiate Pool Descriptions from Pool History

2017-02-14 16:03:19 -08:00

pools_controller.rb

Prevent reverting to foreign versions (fixes #2711).

2016-10-11 06:57:46 +00:00

post_appeals_controller.rb

Make more pages publicly accessible to logged out users.

2016-10-17 05:57:05 -05:00

post_events_controller.rb

Make more pages publicly accessible to logged out users.

2016-10-17 05:57:05 -05:00

post_flags_controller.rb

Make more pages publicly accessible to logged out users.

2016-10-17 05:57:05 -05:00

post_versions_controller.rb

fixes #2165

2014-05-25 14:50:07 -04:00

post_votes_controller.rb

fixes #2822: Post vote API: returns 200 for both success and failure; fixes bug with x-api-limit header

2017-01-09 17:31:14 -08:00

posts_controller.rb

posts_controller.rb: remove unused /posts/home action.

2017-02-06 19:07:03 -06:00

related_tags_controller.rb

Simple HTML page and form for related tags

2017-01-09 19:18:18 +05:00

reports_controller.rb

remove contributors report

2017-02-21 13:12:43 -08:00

saved_search_category_changes_controller.rb

Fix #2795: "check_availability" bug with saved searches.

2016-12-22 21:44:35 -06:00

saved_searches_controller.rb

Fix #2795: "check_availability" bug with saved searches.

2016-12-22 21:44:35 -06:00

sessions_controller.rb

fixes #2619: Delete password_hash cookie on sign out

2016-07-11 16:38:00 -07:00

sources_controller.rb

potential fix for #2404

2015-06-10 17:28:51 -07:00

static_controller.rb

add glob patten for missing routes

2016-08-30 14:42:01 -07:00

super_voters_controller.rb

Make more pages publicly accessible to logged out users.

2016-10-17 05:57:05 -05:00

tag_alias_corrections_controller.rb

fixes #2417

2015-06-29 18:17:59 -07:00

tag_alias_requests_controller.rb

add secondary validations to aliases+implications+requests

2016-02-11 11:48:56 -08:00

tag_aliases_controller.rb

Set approver of aliases/implications in BURs.

2016-10-26 21:52:19 -05:00

tag_corrections_controller.rb

after a tag correction, display tag whether it is empty or not

2013-06-23 18:55:45 -04:00

tag_implication_requests_controller.rb

add secondary validations to aliases+implications+requests

2016-02-11 11:48:56 -08:00

tag_implications_controller.rb

Set approver of aliases/implications in BURs.

2016-10-26 21:52:19 -05:00

tag_subscriptions_controller.rb

add member only constraint for migrating tag subscriptions

2016-06-24 14:11:44 -07:00

tags_controller.rb

Include aliased tags in autocomplete

2015-04-04 12:06:06 -04:00

uploads_controller.rb

Pull upload notice, bookmarklet notice from help:upload_notice wiki page.

2016-11-21 01:17:15 -06:00

user_feedbacks_controller.rb

Fix #2851: Account deletion should remove name change requests.

2017-01-19 22:32:13 +00:00

user_name_change_requests_controller.rb

Name changes: add API endpoints for /user_name_change_requests.

2017-01-15 05:03:09 +00:00

user_reverts_controller.rb

remove reference to janitor_only

2016-09-29 11:54:49 -07:00

user_upgrades_controller.rb

eliminate transaction log items table

2016-12-21 15:00:59 -08:00

users_controller.rb

implement token bucket rate limiting

2017-01-09 17:31:14 -08:00

wiki_page_versions_controller.rb

add limit parameter to everything

2013-05-15 01:01:19 -04:00

wiki_pages_controller.rb

fixes #2885: "Is Deleted" not being recorded correctly for Wiki Page Versions

2017-02-15 15:32:41 -08:00