Changes: * Drop Users.id_to_name. * Don't cache Users.name_to_id. * Replace calls to name_to_id with find_by_name when possible. * Don't autodefine creator_name in belongs_to_creator. * Don't autodefine updater_name in belongs_to_updater. * Instead manually define creator_name / updater_name only on models that need to return these fields in the api. id_to_name was cached to reduce the impact of N+1 query patterns in certain places, especially in api responses that return creator_name / updater_name fields. But it still meant we were doing N calls to memcache. Using `includes` to prefetch users avoids this N+1 pattern. name_to_id had no need be cached, it was never used in any performance- sensitive contexts. Avoiding caching also avoids the need to keep these caches consistent.
23 lines
766 B
Plaintext
23 lines
766 B
Plaintext
<div id="c-user-feedbacks">
|
|
<div id="a-show">
|
|
<h1>User Feedback For <%= link_to_user @user_feedback.user %></h1>
|
|
|
|
<ul>
|
|
<li><strong>Creator</strong> <%= link_to_user @user_feedback.creator %></li>
|
|
<li><strong>Date</strong> <%= @user_feedback.created_at %></li>
|
|
<li><strong>Category</strong> <%= @user_feedback.category %></li>
|
|
<li><strong>Message</strong> <%= format_text @user_feedback.body %></li>
|
|
</ul>
|
|
|
|
<% if @user_feedback.editable_by?(CurrentUser.user) %>
|
|
<p><%= link_to "Edit", edit_user_feedback_path(@user_feedback) %></p>
|
|
<% end %>
|
|
</div>
|
|
</div>
|
|
|
|
<%= render "secondary_links" %>
|
|
|
|
<% content_for(:page_title) do %>
|
|
Feedback - <%= @user_feedback.user.name %> - <%= Danbooru.config.app_name %>
|
|
<% end %>
|