Refactor how model visibility works in index actions: * Call `visible` in the controller instead of in model `search` methods. This decouples model visibility from model searching. * Explicitly pass CurrentUser when calling `visible`. This reduces hidden dependencies on the current user inside models. * Standardize on calling the method `visible`. In some places it was called `permitted` instead. * Add a `visible` base method to ApplicationModel.
30 lines
921 B
Ruby
30 lines
921 B
Ruby
class ForumPostVotesController < ApplicationController
|
|
respond_to :html, :xml, :json, :js
|
|
before_action :member_only, only: [:create, :destroy]
|
|
|
|
def index
|
|
@forum_post_votes = ForumPostVote.visible(CurrentUser.user).paginated_search(params, count_pages: true)
|
|
@forum_post_votes = @forum_post_votes.includes(:creator, forum_post: [:creator, :topic]) if request.format.html?
|
|
|
|
respond_with(@forum_post_votes)
|
|
end
|
|
|
|
def create
|
|
@forum_post = ForumPost.permitted.find(params[:forum_post_id])
|
|
@forum_post_vote = @forum_post.votes.create(forum_post_vote_params.merge(creator: CurrentUser.user))
|
|
respond_with(@forum_post_vote)
|
|
end
|
|
|
|
def destroy
|
|
@forum_post_vote = CurrentUser.user.forum_post_votes.find(params[:id])
|
|
@forum_post_vote.destroy
|
|
respond_with(@forum_post_vote)
|
|
end
|
|
|
|
private
|
|
|
|
def forum_post_vote_params
|
|
params.fetch(:forum_post_vote, {}).permit(:score)
|
|
end
|
|
end
|