59b277ead1
Changes: * Drop Users.id_to_name. * Don't cache Users.name_to_id. * Replace calls to name_to_id with find_by_name when possible. * Don't autodefine creator_name in belongs_to_creator. * Don't autodefine updater_name in belongs_to_updater. * Instead manually define creator_name / updater_name only on models that need to return these fields in the api. id_to_name was cached to reduce the impact of N+1 query patterns in certain places, especially in api responses that return creator_name / updater_name fields. But it still meant we were doing N calls to memcache. Using `includes` to prefetch users avoids this N+1 pattern. name_to_id had no need be cached, it was never used in any performance- sensitive contexts. Avoiding caching also avoids the need to keep these caches consistent.
74 lines
1.9 KiB
Ruby
74 lines
1.9 KiB
Ruby
class NotesController < ApplicationController
|
|
respond_to :html, :xml, :json, :js
|
|
before_action :member_only, :except => [:index, :show, :search]
|
|
|
|
def search
|
|
end
|
|
|
|
def index
|
|
@notes = Note.includes(:creator).search(search_params).paginate(params[:page], :limit => params[:limit], :search_count => params[:search])
|
|
respond_with(@notes) do |format|
|
|
format.html { @notes = @notes.includes(:creator) }
|
|
format.xml do
|
|
render :xml => @notes.to_xml(:root => "notes")
|
|
end
|
|
end
|
|
end
|
|
|
|
def show
|
|
@note = Note.find(params[:id])
|
|
respond_with(@note) do |format|
|
|
format.html { redirect_to(post_path(@note.post, anchor: "note-#{@note.id}")) }
|
|
end
|
|
end
|
|
|
|
def create
|
|
@note = Note.create(note_params(:create))
|
|
respond_with(@note) do |fmt|
|
|
fmt.json do
|
|
if @note.errors.any?
|
|
render :json => {:success => false, :reasons => @note.errors.full_messages}.to_json, :status => 422
|
|
else
|
|
render :json => @note.to_json(:methods => [:html_id])
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
def update
|
|
@note = Note.find(params[:id])
|
|
@note.update(note_params(:update))
|
|
respond_with(@note) do |format|
|
|
format.json do
|
|
if @note.errors.any?
|
|
render :json => {:success => false, :reasons => @note.errors.full_messages}.to_json, :status => 422
|
|
else
|
|
render :json => @note.to_json
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
def destroy
|
|
@note = Note.find(params[:id])
|
|
@note.update_attributes(:is_active => false)
|
|
respond_with(@note)
|
|
end
|
|
|
|
def revert
|
|
@note = Note.find(params[:id])
|
|
@version = @note.versions.find(params[:version_id])
|
|
@note.revert_to!(@version)
|
|
respond_with(@note)
|
|
end
|
|
|
|
private
|
|
|
|
def note_params(context)
|
|
permitted_params = %i[x y width height body]
|
|
permitted_params += %i[post_id html_id] if context == :create
|
|
|
|
params.require(:note).permit(permitted_params)
|
|
end
|
|
end
|