abce4d2551
Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
81 lines
2.4 KiB
Ruby
81 lines
2.4 KiB
Ruby
class UserNameChangeRequest < ApplicationRecord
|
|
after_initialize :initialize_attributes, if: :new_record?
|
|
validates_presence_of :user_id, :original_name, :desired_name
|
|
validates_inclusion_of :status, :in => %w(pending approved rejected)
|
|
belongs_to :user
|
|
belongs_to :approver, :class_name => "User", optional: true
|
|
validate :not_limited, :on => :create
|
|
validates :desired_name, user_name: true
|
|
|
|
def initialize_attributes
|
|
self.user_id ||= CurrentUser.user.id
|
|
self.original_name ||= CurrentUser.user.name
|
|
end
|
|
|
|
def self.pending
|
|
where(:status => "pending")
|
|
end
|
|
|
|
def self.approved
|
|
where(:status => "approved")
|
|
end
|
|
|
|
def self.visible(viewer = CurrentUser.user)
|
|
if viewer.is_admin?
|
|
all
|
|
elsif viewer.is_member?
|
|
joins(:user).merge(User.undeleted).where("user_name_change_requests.status = 'approved' OR user_name_change_requests.user_id = ?", viewer.id)
|
|
else
|
|
none
|
|
end
|
|
end
|
|
|
|
def rejected?
|
|
status == "rejected"
|
|
end
|
|
|
|
def approved?
|
|
status == "approved"
|
|
end
|
|
|
|
def pending?
|
|
status == "pending"
|
|
end
|
|
|
|
def feedback
|
|
UserFeedback.for_user(user_id).order("id desc")
|
|
end
|
|
|
|
def approve!
|
|
update_attributes(:status => "approved", :approver_id => CurrentUser.user.id)
|
|
user.update_attribute(:name, desired_name)
|
|
body = "Your name change request has been approved. Be sure to log in with your new user name."
|
|
Dmail.create_automated(:title => "Name change request approved", :body => body, :to_id => user_id)
|
|
UserFeedback.create(:user_id => user_id, :category => "neutral", :body => "Name changed from #{original_name} to #{desired_name}")
|
|
ModAction.log("Name changed from #{original_name} to #{desired_name}",:user_name_change)
|
|
end
|
|
|
|
def reject!(reason)
|
|
update_attributes(:status => "rejected", :rejection_reason => reason)
|
|
body = "Your name change request has been rejected for the following reason: #{rejection_reason}"
|
|
Dmail.create_automated(:title => "Name change request rejected", :body => body, :to_id => user_id)
|
|
end
|
|
|
|
def not_limited
|
|
if UserNameChangeRequest.where("user_id = ? and created_at >= ?", CurrentUser.user.id, 1.week.ago).exists?
|
|
errors.add(:base, "You can only submit one name change request per week")
|
|
return false
|
|
else
|
|
return true
|
|
end
|
|
end
|
|
|
|
def hidden_attributes
|
|
if CurrentUser.is_admin? || user == CurrentUser.user
|
|
[]
|
|
else
|
|
super + [:change_reason, :rejection_reason]
|
|
end
|
|
end
|
|
end
|