d9dc84325f
Fix bug where it was possible to submit blank text in various text fields. Caused by `String#blank?` not considering certain Unicode characters as blank. `blank?` is defined as `match?(/\A[[:space:]]*\z/)`, where `[[:space:]]` matches ASCII spaces (space, tab, newline, etc) and Unicode characters in the Space category ([1]). However, there are other space-like characters not in the Space category. This includes U+200B (Zero-Width Space), and many more. It turns out the "Default ignorable code points" [2][3] are what we're after. These are the set of 400 or so formatting and control characters that are invisible when displayed. Note that there are other control characters that aren't invisible when rendered, instead they're shown with a placeholder glyph. These include the ASCII C0 and C1 control codes [4], certain Unicode control characters [5], and unassigned, reserved, and private use codepoints. There is one outlier: the Braille pattern blank (U+2800) [6]. This character is visually blank, but is not considered to be a space or an ignorable code point. [1]: https://codepoints.net/search?gc[]=Z [2]: https://codepoints.net/search?DI=1 [3]: https://www.unicode.org/review/pr-5.html [4]: https://codepoints.net/search?gc[]=Cc [5]: https://codepoints.net/search?gc[]=Cf [6]: https://codepoints.net/U+2800 [7]: https://en.wikipedia.org/wiki/Whitespace_character [8]: https://character.construction/blanks [9]: https://invisible-characters.com
67 lines
2.2 KiB
Ruby
67 lines
2.2 KiB
Ruby
require 'test_helper'
|
|
|
|
class PostAppealTest < ActiveSupport::TestCase
|
|
context "In all cases" do
|
|
setup do
|
|
@user = create(:user, upload_points: 1000)
|
|
end
|
|
|
|
context "a user" do
|
|
setup do
|
|
@post = create(:post, tag_string: "aaa", is_deleted: true)
|
|
end
|
|
|
|
should "not be able to appeal a post more than once" do
|
|
@post_appeal = create(:post_appeal, post: @post, creator: @user)
|
|
@post_appeal = build(:post_appeal, post: @post, creator: @user)
|
|
|
|
assert_equal(false, @post_appeal.valid?)
|
|
assert_includes(@post_appeal.errors.full_messages, "You have already appealed this post")
|
|
end
|
|
|
|
should "not be able to appeal an active post" do
|
|
@post.update!(is_deleted: false)
|
|
@post_appeal = build(:post_appeal, post: @post, creator: @user)
|
|
|
|
assert_equal(false, @post_appeal.valid?)
|
|
assert_equal(["Post cannot be appealed"], @post_appeal.errors.full_messages)
|
|
end
|
|
|
|
context "appeal limits" do
|
|
context "for members" do
|
|
should "not be able to appeal more than their upload limit" do
|
|
create_list(:post_appeal, 5, creator: @user)
|
|
|
|
assert_equal(15, @user.upload_limit.upload_slots)
|
|
assert_equal(15, @user.upload_limit.used_upload_slots)
|
|
|
|
@post_appeal = build(:post_appeal, creator: @user)
|
|
assert_equal(false, @post_appeal.valid?)
|
|
assert_equal(["have reached your appeal limit"], @post_appeal.errors[:creator])
|
|
end
|
|
end
|
|
|
|
context "for users with unrestricted uploads" do
|
|
should "should not have an appeal limit" do
|
|
@user = create(:contributor)
|
|
create_list(:post_appeal, 10, creator: @user)
|
|
|
|
assert_equal(15, @user.upload_limit.upload_slots)
|
|
assert_equal(30, @user.upload_limit.used_upload_slots)
|
|
assert_equal(false, @user.is_appeal_limited?)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "validation" do
|
|
subject { build(:post_appeal) }
|
|
|
|
should allow_value("").for(:reason)
|
|
|
|
should_not allow_value(" ").for(:reason)
|
|
should_not allow_value("\u200B").for(:reason)
|
|
end
|
|
end
|
|
end
|
|
end
|