When a POST request returns a 302 redirect, follow the redirect with a GET request instead of with a POST request. HTTP standards leave it unspecified whether a POST request that returns a 302 redirect should be followed with a GET or with a POST. A GET is what most browsers use, which means it's what most servers expect. Fixes the /tagme Discord command not working because when we uploaded the image to DeepDanbooru, the POST request returned a 302 redirect, which the server expected us to follow with a GET, not with a POST. Ref: * https://stackoverflow.com/questions/17605915/what-is-the-correct-behavior-expected-of-an-http-post-302-redirect-to-get
209 lines
7.9 KiB
Ruby
209 lines
7.9 KiB
Ruby
require 'test_helper'
|
|
|
|
class DanbooruHttpTest < ActiveSupport::TestCase
|
|
def httpbin_url(path = "")
|
|
"https://nghttp2.org/httpbin/#{path}"
|
|
end
|
|
|
|
context "Danbooru::Http" do
|
|
context "#get method" do
|
|
should "work for all basic methods" do
|
|
%i[get head put post delete].each do |method|
|
|
response = Danbooru::Http.send(method, httpbin_url("status/200"))
|
|
assert_equal(200, response.status)
|
|
end
|
|
end
|
|
|
|
should "follow redirects" do
|
|
response = Danbooru::Http.get(httpbin_url("absolute-redirect/3"))
|
|
assert_equal(200, response.status)
|
|
end
|
|
|
|
should "fail if redirected too many times" do
|
|
response = Danbooru::Http.get(httpbin_url("absolute-redirect/10"))
|
|
assert_equal(596, response.status)
|
|
end
|
|
|
|
should "fail if the request takes too long to connect" do
|
|
response = Danbooru::Http.timeout(1).get(httpbin_url("delay/5"))
|
|
assert_equal(597, response.status)
|
|
end
|
|
|
|
should "fail if the request takes too long to download" do
|
|
# XXX should return status 597 instead
|
|
assert_raises(HTTP::TimeoutError) do
|
|
response = Danbooru::Http.timeout(1).get(httpbin_url("drip?duration=10&numbytes=10")).flush
|
|
end
|
|
end
|
|
|
|
should "return a 5xx error if the domain can't be resolved" do
|
|
response = Danbooru::Http.get("http://doesnotexist.donmai.us")
|
|
assert_equal(598, response.status)
|
|
end
|
|
|
|
should "return a 5xx error if the SSL certificate is expired" do
|
|
response = Danbooru::Http.get("https://expired.badssl.com")
|
|
assert_equal(590, response.status)
|
|
end
|
|
|
|
should "automatically decompress gzipped responses" do
|
|
response = Danbooru::Http.get(httpbin_url("gzip"))
|
|
assert_equal(200, response.status)
|
|
assert_equal(true, response.parse["gzipped"])
|
|
end
|
|
|
|
should "automatically parse html responses" do
|
|
response = Danbooru::Http.get(httpbin_url("html"))
|
|
assert_equal(200, response.status)
|
|
assert_instance_of(Nokogiri::HTML5::Document, response.parse)
|
|
assert_equal("Herman Melville - Moby-Dick", response.parse.css("h1").text)
|
|
end
|
|
|
|
should "automatically parse xml responses" do
|
|
response = Danbooru::Http.get(httpbin_url("xml"))
|
|
assert_equal(200, response.status)
|
|
assert_equal(true, response.parse[:slideshow].present?)
|
|
end
|
|
|
|
should "track cookies between requests" do
|
|
http = Danbooru::Http.use(:session)
|
|
|
|
resp1 = http.get(httpbin_url("cookies/set/abc/1"))
|
|
resp2 = http.get(httpbin_url("cookies/set/def/2"))
|
|
resp3 = http.get(httpbin_url("cookies"))
|
|
assert_equal({ abc: "1", def: "2" }, resp3.parse["cookies"].symbolize_keys)
|
|
|
|
resp4 = http.cookies(def: 3, ghi: 4).get(httpbin_url("cookies"))
|
|
assert_equal({ abc: "1", def: "3", ghi: "4" }, resp4.parse["cookies"].symbolize_keys)
|
|
end
|
|
end
|
|
|
|
context "#post method" do
|
|
should "follow 302 redirects with a GET" do
|
|
response = Danbooru::Http.get(httpbin_url("redirect-to?url=#{httpbin_url("get")}"))
|
|
assert_equal(200, response.status)
|
|
end
|
|
end
|
|
|
|
context "cache feature" do
|
|
should "cache multiple requests to the same url" do
|
|
http = Danbooru::Http.cache(1.hour)
|
|
|
|
response1 = http.get(httpbin_url("uuid"))
|
|
assert_equal(200, response1.status)
|
|
|
|
response2 = http.get(httpbin_url("uuid"))
|
|
assert_equal(200, response2.status)
|
|
assert_equal(response2.to_s, response1.to_s)
|
|
end
|
|
|
|
should "cache cookies correctly" do
|
|
http = Danbooru::Http.cache(1.hour)
|
|
|
|
resp1 = http.get(httpbin_url("cookies"))
|
|
resp2 = http.get(httpbin_url("cookies/set/abc/1"))
|
|
resp3 = http.get(httpbin_url("cookies/set/def/2"))
|
|
resp4 = http.get(httpbin_url("cookies"))
|
|
|
|
assert_equal(200, resp1.status)
|
|
assert_equal(200, resp2.status)
|
|
assert_equal(200, resp3.status)
|
|
assert_equal(200, resp4.status)
|
|
|
|
assert_equal({}, resp1.parse["cookies"].symbolize_keys)
|
|
assert_equal({ abc: "1" }, resp2.parse["cookies"].symbolize_keys)
|
|
assert_equal({ abc: "1", def: "2" }, resp3.parse["cookies"].symbolize_keys)
|
|
assert_equal({ abc: "1", def: "2" }, resp4.parse["cookies"].symbolize_keys)
|
|
end
|
|
end
|
|
|
|
context "retriable feature" do
|
|
should "retry immediately if no Retry-After header is sent" do
|
|
response_429 = ::HTTP::Response.new(status: 429, version: "1.1", body: "")
|
|
response_200 = ::HTTP::Response.new(status: 200, version: "1.1", body: "")
|
|
HTTP::Client.any_instance.expects(:perform).times(2).returns(response_429, response_200)
|
|
|
|
response = Danbooru::Http.use(:retriable).get(httpbin_url("status/429"))
|
|
assert_equal(200, response.status)
|
|
end
|
|
|
|
should "retry if the Retry-After header is an integer" do
|
|
response_503 = ::HTTP::Response.new(status: 503, version: "1.1", headers: { "Retry-After": "1" }, body: "")
|
|
response_200 = ::HTTP::Response.new(status: 200, version: "1.1", body: "")
|
|
HTTP::Client.any_instance.expects(:perform).times(2).returns(response_503, response_200)
|
|
|
|
response = Danbooru::Http.use(:retriable).get(httpbin_url("status/503"))
|
|
assert_equal(200, response.status)
|
|
end
|
|
|
|
should "retry if the Retry-After header is a date" do
|
|
response_503 = ::HTTP::Response.new(status: 503, version: "1.1", headers: { "Retry-After": 2.seconds.from_now.httpdate }, body: "")
|
|
response_200 = ::HTTP::Response.new(status: 200, version: "1.1", body: "")
|
|
HTTP::Client.any_instance.expects(:perform).times(2).returns(response_503, response_200)
|
|
|
|
response = Danbooru::Http.use(:retriable).get(httpbin_url("status/503"))
|
|
assert_equal(200, response.status)
|
|
end
|
|
end
|
|
|
|
context "spoof referrer feature" do
|
|
should "spoof the referer" do
|
|
response = Danbooru::Http.use(:spoof_referrer).get(httpbin_url("anything"))
|
|
|
|
assert_equal(200, response.status)
|
|
assert_equal("https://nghttp2.org", response.parse.dig("headers", "Referer"))
|
|
end
|
|
end
|
|
|
|
context "unpolish cloudflare feature" do
|
|
should "return the original image for polished images" do
|
|
url = "https://cdnb.artstation.com/p/assets/images/images/025/273/307/4k/atey-ghailan-a-sage-keyart-s-ch-04-outlined-1.jpg?1585246642"
|
|
response = Danbooru::Http.use(:unpolish_cloudflare).get(url)
|
|
|
|
assert_equal(200, response.status)
|
|
assert_equal(622_594, response.content_length)
|
|
end
|
|
end
|
|
|
|
context "#download method" do
|
|
should "download files" do
|
|
response, file = Danbooru::Http.download_media(httpbin_url("bytes/1000"))
|
|
|
|
assert_equal(200, response.status)
|
|
assert_equal(1000, file.size)
|
|
end
|
|
|
|
should "follow redirects when downloading files" do
|
|
response, file = Danbooru::Http.download_media(httpbin_url("/redirect-to?url=#{httpbin_url("bytes/1000")}"))
|
|
|
|
assert_equal(200, response.status)
|
|
assert_equal(1000, file.size)
|
|
end
|
|
|
|
should "fail if the url points to a private IP" do
|
|
assert_raises(Danbooru::Http::DownloadError) do
|
|
Danbooru::Http.public_only.download_media("https://127.0.0.1.nip.io")
|
|
end
|
|
end
|
|
|
|
should "fail if the url redirects to a private IP" do
|
|
assert_raises(Danbooru::Http::DownloadError) do
|
|
Danbooru::Http.public_only.download_media(httpbin_url("redirect-to?url=https://127.0.0.1.nip.io"))
|
|
end
|
|
end
|
|
|
|
should "fail if a download is too large" do
|
|
assert_raises(Danbooru::Http::FileTooLargeError) do
|
|
response, file = Danbooru::Http.max_size(500).download_media(httpbin_url("bytes/1000"))
|
|
end
|
|
end
|
|
|
|
should "fail if a streaming download is too large" do
|
|
assert_raises(Danbooru::Http::FileTooLargeError) do
|
|
response, file = Danbooru::Http.max_size(500).download_media(httpbin_url("stream-bytes/1000"))
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|