abce4d2551
Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
63 lines
1.1 KiB
Ruby
63 lines
1.1 KiB
Ruby
FactoryBot.define do
|
|
factory(:user, aliases: [:creator, :updater]) do
|
|
name {(rand(1_000_000) + 10).to_s}
|
|
password "password"
|
|
password_hash {User.sha1("password")}
|
|
email {FFaker::Internet.email}
|
|
default_image_size "large"
|
|
base_upload_limit 10
|
|
level 20
|
|
created_at {Time.now}
|
|
last_logged_in_at {Time.now}
|
|
favorite_count 0
|
|
bit_prefs 0
|
|
|
|
factory(:banned_user) do
|
|
transient { ban_duration 3 }
|
|
is_banned true
|
|
end
|
|
|
|
factory(:member_user) do
|
|
level 20
|
|
end
|
|
|
|
factory(:gold_user) do
|
|
level 30
|
|
end
|
|
|
|
factory(:platinum_user) do
|
|
level 31
|
|
end
|
|
|
|
factory(:builder_user) do
|
|
level 32
|
|
end
|
|
|
|
factory(:contributor_user) do
|
|
level 32
|
|
bit_prefs User.flag_value_for("can_upload_free")
|
|
end
|
|
|
|
factory(:contrib_user) do
|
|
level 32
|
|
bit_prefs User.flag_value_for("can_upload_free")
|
|
end
|
|
|
|
factory(:moderator_user) do
|
|
level 40
|
|
can_approve_posts true
|
|
end
|
|
|
|
factory(:mod_user) do
|
|
level 40
|
|
can_approve_posts true
|
|
end
|
|
|
|
factory(:admin_user) do
|
|
level 50
|
|
can_approve_posts true
|
|
end
|
|
end
|
|
end
|
|
|