Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
119 lines
2.8 KiB
Ruby
119 lines
2.8 KiB
Ruby
ENV["RAILS_ENV"] = "test"
|
|
|
|
if ENV["SIMPLECOV"]
|
|
require 'simplecov'
|
|
SimpleCov.start 'rails' do
|
|
add_group "Libraries", ["app/logical", "lib"]
|
|
add_group "Presenters", "app/presenters"
|
|
end
|
|
end
|
|
|
|
require File.expand_path('../../config/environment', __FILE__)
|
|
require 'rails/test_help'
|
|
require 'cache'
|
|
require 'webmock/minitest'
|
|
|
|
Dir[File.expand_path(File.dirname(__FILE__) + "/factories/*.rb")].each {|file| require file}
|
|
Dir[File.expand_path(File.dirname(__FILE__) + "/test_helpers/*.rb")].each {|file| require file}
|
|
|
|
Dotenv.load(Rails.root + ".env.local")
|
|
|
|
Shoulda::Matchers.configure do |config|
|
|
config.integrate do |with|
|
|
with.test_framework :minitest
|
|
with.library :rails
|
|
end
|
|
end
|
|
|
|
module TestHelpers
|
|
def create(factory_bot_model, params = {})
|
|
record = FactoryBot.build(factory_bot_model, params)
|
|
record.save
|
|
raise ActiveRecord::RecordInvalid.new(record) if record.errors.any?
|
|
record
|
|
end
|
|
|
|
def as(user, &block)
|
|
CurrentUser.as(user, &block)
|
|
end
|
|
|
|
def as_user(&block)
|
|
CurrentUser.as(@user, &block)
|
|
end
|
|
|
|
def as_admin(&block)
|
|
CurrentUser.as_admin(&block)
|
|
end
|
|
end
|
|
|
|
|
|
class ActiveSupport::TestCase
|
|
include PostArchiveTestHelper
|
|
include PoolArchiveTestHelper
|
|
include ReportbooruHelper
|
|
include DownloadTestHelper
|
|
include IqdbTestHelper
|
|
include SavedSearchTestHelper
|
|
include UploadTestHelper
|
|
include TestHelpers
|
|
|
|
setup do
|
|
mock_popular_search_service!
|
|
mock_missed_search_service!
|
|
WebMock.allow_net_connect!
|
|
Danbooru.config.stubs(:enable_sock_puppet_validation?).returns(false)
|
|
|
|
storage_manager = StorageManager::Local.new(base_dir: "#{Rails.root}/public/data/test")
|
|
Danbooru.config.stubs(:storage_manager).returns(storage_manager)
|
|
Danbooru.config.stubs(:backup_storage_manager).returns(StorageManager::Null.new)
|
|
end
|
|
|
|
teardown do
|
|
FileUtils.rm_rf(Danbooru.config.storage_manager.base_dir)
|
|
Cache.clear
|
|
end
|
|
end
|
|
|
|
class ActionDispatch::IntegrationTest
|
|
include PostArchiveTestHelper
|
|
include PoolArchiveTestHelper
|
|
include TestHelpers
|
|
|
|
def method_authenticated(method_name, url, user, options)
|
|
Thread.current[:test_user_id] = user.id
|
|
self.send(method_name, url, options)
|
|
ensure
|
|
Thread.current[:test_user_id] = nil
|
|
end
|
|
|
|
def get_auth(url, user, options = {})
|
|
method_authenticated(:get, url, user, options)
|
|
end
|
|
|
|
def post_auth(url, user, options = {})
|
|
method_authenticated(:post, url, user, options)
|
|
end
|
|
|
|
def put_auth(url, user, options = {})
|
|
method_authenticated(:put, url, user, options)
|
|
end
|
|
|
|
def delete_auth(url, user, options = {})
|
|
method_authenticated(:delete, url, user, options)
|
|
end
|
|
|
|
def setup
|
|
super
|
|
Danbooru.config.stubs(:enable_sock_puppet_validation?).returns(false)
|
|
end
|
|
|
|
def teardown
|
|
super
|
|
Cache.clear
|
|
end
|
|
end
|
|
|
|
Delayed::Worker.delay_jobs = false
|
|
|
|
Rails.application.load_seed
|