abce4d2551
Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
80 lines
2.2 KiB
Ruby
80 lines
2.2 KiB
Ruby
require 'test_helper'
|
|
|
|
class AliasAndImplicationImporterTest < ActiveSupport::TestCase
|
|
context "The alias and implication importer" do
|
|
setup do
|
|
CurrentUser.user = FactoryBot.create(:admin_user)
|
|
CurrentUser.ip_addr = "127.0.0.1"
|
|
end
|
|
|
|
teardown do
|
|
CurrentUser.user = nil
|
|
CurrentUser.ip_addr = nil
|
|
end
|
|
|
|
context "category command" do
|
|
setup do
|
|
@tag = Tag.find_or_create_by_name("hello")
|
|
@list = "category hello -> artist\n"
|
|
@importer = AliasAndImplicationImporter.new(@list, nil)
|
|
end
|
|
|
|
should "work" do
|
|
@importer.process!
|
|
@tag.reload
|
|
assert_equal(Tag.categories.value_for("artist"), @tag.category)
|
|
end
|
|
end
|
|
|
|
context "given a valid list" do
|
|
setup do
|
|
@list = "create alias abc -> def\ncreate implication aaa -> bbb\n"
|
|
@importer = AliasAndImplicationImporter.new(@list, nil)
|
|
end
|
|
|
|
should "process it" do
|
|
@importer.process!
|
|
assert(TagAlias.exists?(antecedent_name: "abc", consequent_name: "def"))
|
|
assert(TagImplication.exists?(antecedent_name: "aaa", consequent_name: "bbb"))
|
|
end
|
|
end
|
|
|
|
context "given a list with an invalid command" do
|
|
setup do
|
|
@list = "zzzz abc -> def\n"
|
|
@importer = AliasAndImplicationImporter.new(@list, nil)
|
|
end
|
|
|
|
should "throw an exception" do
|
|
assert_raises(RuntimeError) do
|
|
@importer.process!
|
|
end
|
|
end
|
|
end
|
|
|
|
context "given a list with a logic error" do
|
|
setup do
|
|
@list = "remove alias zzz -> yyy\n"
|
|
@importer = AliasAndImplicationImporter.new(@list, nil)
|
|
end
|
|
|
|
should "throw an exception" do
|
|
assert_raises(RuntimeError) do
|
|
@importer.process!
|
|
end
|
|
end
|
|
end
|
|
|
|
should "rename an aliased tag's artist entry and wiki page" do
|
|
tag1 = FactoryBot.create(:tag, :name => "aaa", :category => 1)
|
|
tag2 = FactoryBot.create(:tag, :name => "bbb")
|
|
artist = FactoryBot.create(:artist, :name => "aaa", :notes => "testing")
|
|
@importer = AliasAndImplicationImporter.new("create alias aaa -> bbb", "", "1")
|
|
@importer.process!
|
|
artist.reload
|
|
assert_equal("bbb", artist.name)
|
|
assert_equal("testing", artist.notes)
|
|
end
|
|
end
|
|
end
|