d9dc84325f
Fix bug where it was possible to submit blank text in various text fields. Caused by `String#blank?` not considering certain Unicode characters as blank. `blank?` is defined as `match?(/\A[[:space:]]*\z/)`, where `[[:space:]]` matches ASCII spaces (space, tab, newline, etc) and Unicode characters in the Space category ([1]). However, there are other space-like characters not in the Space category. This includes U+200B (Zero-Width Space), and many more. It turns out the "Default ignorable code points" [2][3] are what we're after. These are the set of 400 or so formatting and control characters that are invisible when displayed. Note that there are other control characters that aren't invisible when rendered, instead they're shown with a placeholder glyph. These include the ASCII C0 and C1 control codes [4], certain Unicode control characters [5], and unassigned, reserved, and private use codepoints. There is one outlier: the Braille pattern blank (U+2800) [6]. This character is visually blank, but is not considered to be a space or an ignorable code point. [1]: https://codepoints.net/search?gc[]=Z [2]: https://codepoints.net/search?DI=1 [3]: https://www.unicode.org/review/pr-5.html [4]: https://codepoints.net/search?gc[]=Cc [5]: https://codepoints.net/search?gc[]=Cf [6]: https://codepoints.net/U+2800 [7]: https://en.wikipedia.org/wiki/Whitespace_character [8]: https://character.construction/blanks [9]: https://invisible-characters.com
95 lines
2.5 KiB
Ruby
95 lines
2.5 KiB
Ruby
require 'test_helper'
|
|
|
|
class ForumTopicTest < ActiveSupport::TestCase
|
|
context "A forum topic" do
|
|
setup do
|
|
travel_to Time.now
|
|
@user = FactoryBot.create(:user)
|
|
CurrentUser.user = @user
|
|
@topic = create(:forum_topic, title: "xxx", creator: @user)
|
|
end
|
|
|
|
teardown do
|
|
CurrentUser.user = nil
|
|
end
|
|
|
|
context "#mark_as_read!" do
|
|
context "without a previous visit" do
|
|
should "create a new visit" do
|
|
@topic.mark_as_read!(@user)
|
|
@user.reload
|
|
assert_equal(@topic.updated_at.to_i, @user.last_forum_read_at.to_i)
|
|
end
|
|
end
|
|
|
|
context "with a previous visit" do
|
|
setup do
|
|
FactoryBot.create(:forum_topic_visit, user: @user, forum_topic: @topic, last_read_at: 1.day.ago)
|
|
end
|
|
|
|
should "update the visit" do
|
|
@topic.mark_as_read!(@user)
|
|
@user.reload
|
|
assert_equal(@topic.updated_at.to_i, @user.last_forum_read_at.to_i)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "constructed with nested attributes for its original post" do
|
|
should "create a matching forum post" do
|
|
assert_difference(["ForumTopic.count", "ForumPost.count"], 1) do
|
|
@topic = create(:forum_topic, title: "abc", original_post_attributes: { body: "abc", creator: @user })
|
|
end
|
|
end
|
|
end
|
|
|
|
should "be searchable by title" do
|
|
assert_search_equals(@topic, title: "xxx")
|
|
assert_search_equals([], title: "aaa")
|
|
end
|
|
|
|
should "be searchable by category id" do
|
|
assert_search_equals(@topic, category_id: 0)
|
|
assert_search_equals([], category_id: 1)
|
|
end
|
|
|
|
should "initialize its creator" do
|
|
assert_equal(@user.id, @topic.creator_id)
|
|
end
|
|
|
|
context "updated by a second user" do
|
|
setup do
|
|
@second_user = FactoryBot.create(:user)
|
|
CurrentUser.user = @second_user
|
|
end
|
|
|
|
should "record its updater" do
|
|
@topic.update(title: "abc")
|
|
assert_equal(@second_user.id, @topic.updater_id)
|
|
end
|
|
end
|
|
|
|
context "with multiple posts that has been deleted" do
|
|
setup do
|
|
5.times do
|
|
FactoryBot.create(:forum_post, :topic_id => @topic.id)
|
|
end
|
|
end
|
|
|
|
should "delete any associated posts" do
|
|
assert_difference("ForumPost.count", -5) do
|
|
@topic.destroy
|
|
end
|
|
end
|
|
end
|
|
|
|
context "during validation" do
|
|
subject { build(:forum_topic) }
|
|
|
|
should_not allow_value("").for(:title)
|
|
should_not allow_value(" ").for(:title)
|
|
should_not allow_value("\u200B").for(:title)
|
|
end
|
|
end
|
|
end
|