efb836ac02
* Introduce an abstraction for normalizing attributes. Very loosely modeled after https://github.com/fnando/normalize_attributes. * Normalize wiki bodies to Unicode NFC form. * Normalize Unicode space characters in wiki bodies (strip zero width spaces, normalize line endings to CRLF, normalize Unicode spaces to ASCII spaces). * Trim spaces from the start and end of wiki page bodies. This may cause wiki page diffs to show spaces being removed even when the user didn't explicitly remove the spaces themselves.
128 lines
4.4 KiB
Ruby
128 lines
4.4 KiB
Ruby
require 'test_helper'
|
|
|
|
class WikiPageTest < ActiveSupport::TestCase
|
|
setup do
|
|
CurrentUser.ip_addr = "127.0.0.1"
|
|
end
|
|
|
|
teardown do
|
|
CurrentUser.user = nil
|
|
CurrentUser.ip_addr = nil
|
|
end
|
|
|
|
context "A wiki page" do
|
|
context "updated by a regular user" do
|
|
setup do
|
|
@user = FactoryBot.create(:user)
|
|
CurrentUser.user = @user
|
|
@wiki_page = FactoryBot.create(:wiki_page, :title => "HOT POTATO", :other_names => "foo*bar baz")
|
|
end
|
|
|
|
should "normalize its title" do
|
|
assert_equal("hot_potato", @wiki_page.title)
|
|
end
|
|
|
|
should "normalize its other names" do
|
|
@wiki_page.update(:other_names => "foo*bar baz baz 加賀（艦これ）")
|
|
assert_equal(%w[foo*bar baz 加賀(艦これ)], @wiki_page.other_names)
|
|
end
|
|
|
|
should "search by title" do
|
|
matches = WikiPage.titled("hot potato")
|
|
assert_equal(1, matches.count)
|
|
assert_equal("hot_potato", matches.first.title)
|
|
end
|
|
|
|
should "search other names with wildcards" do
|
|
matches = WikiPage.search(other_names_match: "fo*")
|
|
assert_equal([@wiki_page.id], matches.map(&:id))
|
|
end
|
|
|
|
should "create versions" do
|
|
assert_difference("WikiPageVersion.count") do
|
|
@wiki_page = FactoryBot.create(:wiki_page, :title => "xxx")
|
|
end
|
|
|
|
assert_difference("WikiPageVersion.count") do
|
|
@wiki_page.title = "yyy"
|
|
travel(1.day) do
|
|
@wiki_page.save
|
|
end
|
|
end
|
|
end
|
|
|
|
should "revert to a prior version" do
|
|
@wiki_page.title = "yyy"
|
|
travel(1.day) do
|
|
@wiki_page.save
|
|
end
|
|
version = WikiPageVersion.first
|
|
@wiki_page.revert_to!(version)
|
|
@wiki_page.reload
|
|
assert_equal("hot_potato", @wiki_page.title)
|
|
end
|
|
|
|
should "update its dtext links" do
|
|
@wiki_page.update!(body: "[[long hair]]")
|
|
assert_equal(1, @wiki_page.dtext_links.size)
|
|
assert_equal("wiki_link", @wiki_page.dtext_links.first.link_type)
|
|
assert_equal("long_hair", @wiki_page.dtext_links.first.link_target)
|
|
|
|
@wiki_page.update!(body: "http://www.google.com")
|
|
assert_equal(1, @wiki_page.dtext_links.size)
|
|
assert_equal("external_link", @wiki_page.dtext_links.first.link_type)
|
|
assert_equal("http://www.google.com", @wiki_page.dtext_links.first.link_target)
|
|
|
|
@wiki_page.update!(body: "nothing")
|
|
assert_equal(0, @wiki_page.dtext_links.size)
|
|
end
|
|
end
|
|
|
|
context "the wiki body" do
|
|
should "be normalized to NFC" do
|
|
# \u00E9: é; \u0301: acute accent
|
|
@wiki = create(:wiki_page, body: "Poke\u0301mon")
|
|
assert_equal("Pok\u00E9mon", @wiki.body)
|
|
end
|
|
|
|
should "normalize line endings and trim spaces" do
|
|
@wiki = create(:wiki_page, body: " foo\nbar\n")
|
|
assert_equal("foo\r\nbar", @wiki.body)
|
|
end
|
|
end
|
|
|
|
context "during title validation" do
|
|
# these values are allowed because they're normalized first
|
|
should allow_value(" foo ").for(:title).on(:create)
|
|
should allow_value("~foo").for(:title).on(:create)
|
|
should allow_value("_foo").for(:title).on(:create)
|
|
should allow_value("foo_").for(:title).on(:create)
|
|
should allow_value("foo__bar").for(:title).on(:create)
|
|
should allow_value("FOO").for(:title).on(:create)
|
|
should allow_value("foo bar").for(:title).on(:create)
|
|
|
|
should_not allow_value("").for(:title).on(:create)
|
|
should_not allow_value("___").for(:title).on(:create)
|
|
should_not allow_value("-foo").for(:title).on(:create)
|
|
should_not allow_value("/foo").for(:title).on(:create)
|
|
should_not allow_value("foo*bar").for(:title).on(:create)
|
|
should_not allow_value("foo,bar").for(:title).on(:create)
|
|
should_not allow_value("foo\abar").for(:title).on(:create)
|
|
should_not allow_value("café").for(:title).on(:create)
|
|
should_not allow_value("東方").for(:title).on(:create)
|
|
should_not allow_value("FAV:blah").for(:title).on(:create)
|
|
should_not allow_value("X"*171).for(:title).on(:create)
|
|
end
|
|
|
|
context "with other names" do
|
|
should "not allow artist wikis to have other names" do
|
|
tag = create(:artist_tag)
|
|
wiki = build(:wiki_page, title: tag.name, other_names: ["blah"])
|
|
|
|
assert_equal(false, wiki.valid?)
|
|
assert_equal(["An artist wiki can't have other names"], wiki.errors[:base])
|
|
end
|
|
end
|
|
end
|
|
end
|