Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
105 lines
3.7 KiB
Ruby
105 lines
3.7 KiB
Ruby
class JanitorTrial < ApplicationRecord
|
|
belongs_to :user
|
|
after_create :send_dmail
|
|
after_create :promote_user
|
|
validates_presence_of :user
|
|
belongs_to_creator
|
|
validates_inclusion_of :status, :in => %w(active inactive)
|
|
before_validation :initialize_status
|
|
validates_uniqueness_of :user_id
|
|
|
|
def self.search(params)
|
|
q = super.where(status: "active")
|
|
|
|
if params[:user_name]
|
|
q = q.where("user_id = (select _.id from users _ where lower(_.name) = ?)", params[:user_name].mb_chars.downcase)
|
|
end
|
|
|
|
if params[:user_id]
|
|
q = q.where("user_id = ?", params[:user_id].to_i)
|
|
end
|
|
|
|
q.apply_default_order(params)
|
|
end
|
|
|
|
def self.message_candidates!
|
|
admin = User.admins.first
|
|
n = 0
|
|
|
|
User.without_timeout do
|
|
User.where("last_logged_in_at >= ? and created_at <= ? and email is not null and (favorite_count >= 300 OR post_upload_count >= 300) and bit_prefs & ? = 0", 1.week.ago, 6.months.ago, User.flag_value_for("can_approve_posts")).find_each do |user|
|
|
if !Dmail.where("from_id = ? and to_id = ? and title = ?", admin.id, user.id, "Test Janitor Invitation").exists?
|
|
favorites = user.favorites.order("random()").limit(400).map(&:post_id)
|
|
uploads = user.posts.order("random()").limit(400).map(&:id)
|
|
p50 = ActiveRecord::Base.select_value_sql("select percentile_cont(0.50) within group (order by score) from posts where id in (?)", favorites + uploads).to_f
|
|
|
|
if p50 > 3
|
|
n += 1
|
|
if n > 8
|
|
break
|
|
end
|
|
|
|
CurrentUser.scoped(admin, "127.0.0.1") do
|
|
body = <<-EOS
|
|
Janitors on #{Danbooru.config.app_name} are responsible for helping maintain a high level of quality on the site. They approve uploads from other users and help with other moderation efforts. You would be expected at a minimum to approve a few posts a week. If you are interested, please respond to this message.
|
|
EOS
|
|
|
|
Dmail.create_split(:title => "Test Janitor Invitation", :body => body, :to_id => user.id)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
def initialize_status
|
|
self.status = "active"
|
|
end
|
|
|
|
def user_name
|
|
user.try(:name)
|
|
end
|
|
|
|
def user_name=(name)
|
|
self.user_id = User.name_to_id(name)
|
|
end
|
|
|
|
def send_dmail
|
|
body = "You have been selected as a test janitor. You can now approve pending posts and have access to the moderation interface. You should reacquaint yourself with the [[howto:upload]] guide to make sure you understand the site rules.\n\nOver the next several weeks your approvals will be monitored. If the majority of them are not quality uploads you will fail the trial period and lose your approval privileges. You will also receive a negative user record indicating you previously attempted and failed a test janitor trial.\n\nThere is a minimum quota of 1 approval a month to indicate that you are being active. Remember, the goal isn't to approve as much as possible. It's to filter out borderline-quality art."
|
|
|
|
Dmail.create_automated(:title => "Test Janitor Trial Period", :body => body, :to_id => user_id)
|
|
end
|
|
|
|
def promote_user
|
|
user.feedback.create(:category => "neutral", :body => "Gained approval privileges")
|
|
user.can_approve_posts = true
|
|
user.save
|
|
end
|
|
|
|
def create_feedback
|
|
user.feedback.create(
|
|
:category => "negative",
|
|
:body => "Lost approval privileges"
|
|
)
|
|
end
|
|
|
|
def promote!
|
|
update_attribute(:status, "inactive")
|
|
end
|
|
|
|
def demote!
|
|
user.can_approve_posts = false
|
|
user.save
|
|
update_attribute(:status, "inactive")
|
|
self.create_feedback
|
|
end
|
|
|
|
def active?
|
|
status == "active"
|
|
end
|
|
|
|
def inactive?
|
|
status == "inactive"
|
|
end
|
|
end
|