abce4d2551
Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
55 lines
1.6 KiB
Ruby
55 lines
1.6 KiB
Ruby
module PostArchiveTestHelper
|
|
def setup
|
|
super
|
|
|
|
mock_post_archive_service!
|
|
start_post_archive_transaction
|
|
end
|
|
|
|
def teardown
|
|
super
|
|
|
|
rollback_post_archive_transaction
|
|
end
|
|
|
|
def mock_post_archive_service!
|
|
mock_sqs_service = Class.new do
|
|
def send_message(msg, *options)
|
|
_, json = msg.split(/\n/)
|
|
json = JSON.parse(json)
|
|
json.delete("created_at")
|
|
json["version"] = 1 + PostArchive.where(post_id: json["post_id"]).count
|
|
prev = PostArchive.where(post_id: json["post_id"]).order("id desc").first
|
|
if prev
|
|
json["added_tags"] = json["tags"].scan(/\S+/) - prev.tags.scan(/\S+/)
|
|
json["removed_tags"] = prev.tags.scan(/\S+/) - json["tags"].scan(/\S+/)
|
|
else
|
|
json["added_tags"] = json["tags"].scan(/\S+/)
|
|
end
|
|
json["parent_changed"] = (prev.nil? || json.key?("parent_id") && prev.parent_id != json["parent_id"])
|
|
json["source_changed"] = (prev.nil? || json.key?("source") && prev.source != json["source"])
|
|
json["rating_changed"] = (prev.nil? || json.key?("rating") && prev.rating != json["rating"])
|
|
if merge?(prev, json)
|
|
prev.update_columns(json)
|
|
else
|
|
PostArchive.create(json)
|
|
end
|
|
end
|
|
|
|
def merge?(prev, json)
|
|
prev && (prev.updater_id == json["updater_id"]) && (prev.updated_at >= 1.hour.ago)
|
|
end
|
|
end
|
|
|
|
PostArchive.stubs(:sqs_service).returns(mock_sqs_service.new)
|
|
end
|
|
|
|
def start_post_archive_transaction
|
|
PostArchive.connection.begin_transaction joinable: false
|
|
end
|
|
|
|
def rollback_post_archive_transaction
|
|
PostArchive.connection.rollback_transaction
|
|
end
|
|
end
|