Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
46 lines
2.0 KiB
Ruby
46 lines
2.0 KiB
Ruby
require "test_helper"
|
|
|
|
module Downloads
|
|
class TwitterTest < ActiveSupport::TestCase
|
|
context "downloading a 'https://twitter.com/:user/status/:id' url containing a video" do
|
|
should "download the largest video" do
|
|
skip "Twitter key is not set" unless Danbooru.config.twitter_api_key
|
|
@source = "https://twitter.com/CincinnatiZoo/status/859073537713328129"
|
|
@rewrite = "https://video.twimg.com/ext_tw_video/859073467769126913/pu/vid/1280x720/cPGgVROXHy3yrK6u.mp4"
|
|
assert_rewritten(@rewrite, @source)
|
|
assert_downloaded(8_602_983, @source)
|
|
end
|
|
end
|
|
|
|
context "downloading a 'https://twitter.com/:user/status/:id/photo/:n' card url" do
|
|
should "download the orig file" do
|
|
skip "Twitter key is not set" unless Danbooru.config.twitter_api_key
|
|
@source = "https://twitter.com/masayasuf/status/870734961778630656/photo/1"
|
|
@rewrite = "https://pbs.twimg.com/media/DBV40M2UIAAHYlt.jpg:orig"
|
|
assert_rewritten(@rewrite, @source)
|
|
assert_downloaded(788_206, @source)
|
|
end
|
|
end
|
|
|
|
context "downloading a 'https://mobile.twitter.com/:user/status/:id/photo/:n' mobile url" do
|
|
should "download the orig file" do
|
|
skip "Twitter key is not set" unless Danbooru.config.twitter_api_key
|
|
@source = "https://mobile.twitter.com/Strangestone/status/556440271961858051"
|
|
@rewrite = "https://pbs.twimg.com/media/B7jfc1JCcAEyeJh.png:orig"
|
|
assert_rewritten(@rewrite, @source)
|
|
assert_downloaded(280_150, @source)
|
|
end
|
|
end
|
|
|
|
context "downloading a 'https://pbs.twimg.com/media/*:large' url" do
|
|
should "download the orig file" do
|
|
skip "Twitter key is not set" unless Danbooru.config.twitter_api_key
|
|
@source = "https://pbs.twimg.com/media/B4HSEP5CUAA4xyu.png:large"
|
|
@rewrite = "https://pbs.twimg.com/media/B4HSEP5CUAA4xyu.png:orig"
|
|
assert_rewritten(@rewrite, @source)
|
|
assert_downloaded(9800, @source)
|
|
end
|
|
end
|
|
end
|
|
end
|