abce4d2551
Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
90 lines
2.2 KiB
Ruby
90 lines
2.2 KiB
Ruby
require 'test_helper'
|
|
|
|
class PostViewCountServiceTest < ActiveSupport::TestCase
|
|
def setup
|
|
super
|
|
|
|
CurrentUser.user = FactoryBot.create(:user)
|
|
CurrentUser.ip_addr = "127.0.0.1"
|
|
|
|
PostViewCountService.stubs(:enabled?).returns(true)
|
|
Danbooru.config.stubs(:reportbooru_server).returns("http://localhost:1234")
|
|
@post = FactoryBot.create(:post)
|
|
end
|
|
|
|
def teardown
|
|
super
|
|
CurrentUser.user = nil
|
|
CurrentUser.ip_addr = nil
|
|
end
|
|
|
|
subject { PostViewCountService.new }
|
|
|
|
context "#popular_posts" do
|
|
setup do
|
|
subject.stubs(:fetch_rank).returns([[@post.id, 1]])
|
|
end
|
|
|
|
should "return the posts" do
|
|
posts = subject.popular_posts
|
|
assert_equal(@post.id, posts[0].id)
|
|
end
|
|
end
|
|
|
|
context "#fetch_rank" do
|
|
context "success" do
|
|
setup do
|
|
@date = "2000-01-01"
|
|
@body = "[[1,1.0],[2,2.0]]"
|
|
stub_request(:get, "localhost:1234/post_views/rank").with(query: {"date" => @date}).to_return(body: @body)
|
|
end
|
|
|
|
should "return a list" do
|
|
json = subject.fetch_rank(@date)
|
|
assert(json.is_a?(Array))
|
|
assert_equal(1, json[0][0])
|
|
assert_equal(2, json[1][0])
|
|
end
|
|
end
|
|
|
|
context "failure" do
|
|
setup do
|
|
@date = "2000-01-01"
|
|
stub_request(:get, "localhost:1234/post_views/rank").with(query: {"date" => @date}).to_return(body: "", status: 400)
|
|
end
|
|
|
|
should "return nil" do
|
|
json = subject.fetch_rank(@date)
|
|
assert_nil(json)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "#fetch_count" do
|
|
context "success" do
|
|
setup do
|
|
@body = "[[1,5],[2,20]]"
|
|
stub_request(:get, "localhost:1234/post_views/#{@post.id}").to_return(body: @body)
|
|
end
|
|
|
|
should "return a list" do
|
|
json = subject.fetch_count(@post.id)
|
|
assert(json.is_a?(Array))
|
|
assert_equal(1, json[0][0])
|
|
assert_equal(2, json[1][0])
|
|
end
|
|
end
|
|
|
|
context "failure" do
|
|
setup do
|
|
stub_request(:get, "localhost:1234/post_views/#{@post.id}").to_return(body: "", status: 400)
|
|
end
|
|
|
|
should "return nil" do
|
|
json = subject.fetch_count(@post.id)
|
|
assert_nil(json)
|
|
end
|
|
end
|
|
end
|
|
end
|