Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
137 lines
4.1 KiB
Ruby
137 lines
4.1 KiB
Ruby
require 'test_helper'
|
|
|
|
class SavedSearchTest < ActiveSupport::TestCase
|
|
def setup
|
|
super
|
|
@user = FactoryBot.create(:user)
|
|
CurrentUser.user = @user
|
|
CurrentUser.ip_addr = "127.0.0.1"
|
|
mock_saved_search_service!
|
|
end
|
|
|
|
def teardown
|
|
super
|
|
CurrentUser.user = nil
|
|
CurrentUser.ip_addr = nil
|
|
end
|
|
|
|
context ".labels_for" do
|
|
setup do
|
|
FactoryBot.create(:saved_search, user: @user, label_string: "blah", query: "blah")
|
|
FactoryBot.create(:saved_search, user: @user, label_string: "zah", query: "blah")
|
|
end
|
|
|
|
should "fetch the labels used by a user" do
|
|
assert_equal(%w(blah zah), SavedSearch.labels_for(@user.id))
|
|
end
|
|
|
|
should "expire when a search is updated" do
|
|
Cache.expects(:delete).once
|
|
FactoryBot.create(:saved_search, user: @user, query: "blah")
|
|
end
|
|
end
|
|
|
|
context ".queries_for" do
|
|
setup do
|
|
FactoryBot.create(:tag_alias, antecedent_name: "bbb", consequent_name: "ccc", creator: @user)
|
|
FactoryBot.create(:saved_search, user: @user, label_string: "blah", query: "aaa")
|
|
FactoryBot.create(:saved_search, user: @user, label_string: "zah", query: "CCC BBB AAA")
|
|
FactoryBot.create(:saved_search, user: @user, label_string: "qux", query: " aaa bbb ccc ")
|
|
end
|
|
|
|
should "fetch the queries used by a user for a label" do
|
|
assert_equal(%w(aaa), SavedSearch.queries_for(@user.id, "blah"))
|
|
end
|
|
|
|
should "return fully normalized queries" do
|
|
assert_equal(["aaa", "aaa ccc"], SavedSearch.queries_for(@user.id))
|
|
end
|
|
end
|
|
|
|
context "Fetching the post ids for a search" do
|
|
context "with a label" do
|
|
setup do
|
|
SavedSearch.expects(:queries_for).with(1, "blah").returns(%w(a b c))
|
|
stub_request(:post, "http://localhost:3001/v2/search").to_return(:body => "1 2 3 4")
|
|
end
|
|
|
|
should "return a list of ids" do
|
|
post_ids = SavedSearch.post_ids(1, "blah")
|
|
assert_equal([1,2,3,4], post_ids)
|
|
end
|
|
end
|
|
|
|
context "without a label" do
|
|
setup do
|
|
SavedSearch.expects(:queries_for).with(1, nil).returns(%w(a b c))
|
|
stub_request(:post, "http://localhost:3001/v2/search").to_return(:body => "1 2 3 4")
|
|
end
|
|
|
|
should "return a list of ids" do
|
|
post_ids = SavedSearch.post_ids(1)
|
|
assert_equal([1,2,3,4], post_ids)
|
|
end
|
|
end
|
|
|
|
context "with a nonexistent label" do
|
|
setup do
|
|
SavedSearch.expects(:queries_for).with(1, "empty").returns([])
|
|
end
|
|
|
|
should "return an empty list of ids" do
|
|
post_ids = SavedSearch.post_ids(1, "empty")
|
|
assert_equal([], post_ids)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "Creating a saved search" do
|
|
setup do
|
|
FactoryBot.create(:tag_alias, antecedent_name: "zzz", consequent_name: "yyy", creator: @user)
|
|
@saved_search = @user.saved_searches.create(:query => " ZZZ xxx ")
|
|
end
|
|
|
|
should "update the bitpref on the user" do
|
|
@user.reload
|
|
assert(@user.has_saved_searches?, "should have saved_searches bitpref set")
|
|
end
|
|
|
|
should "normalize the query aside from the order" do
|
|
assert_equal("yyy xxx", @saved_search.query)
|
|
end
|
|
|
|
should "normalize the label string" do
|
|
@saved_search.label_string = "Foo Bar"
|
|
assert_equal(%w[foo bar], @saved_search.labels)
|
|
|
|
@saved_search.labels = ["Artist 1", "Artist 2"]
|
|
assert_equal(%w[artist_1 artist_2], @saved_search.labels)
|
|
end
|
|
end
|
|
|
|
context "Destroying a saved search" do
|
|
setup do
|
|
@saved_search = @user.saved_searches.create(query: "xxx")
|
|
@saved_search.destroy
|
|
end
|
|
|
|
should "update the bitpref on the user" do
|
|
@user.reload
|
|
assert(!@user.has_saved_searches?, "should not have the saved_searches bitpref set")
|
|
end
|
|
end
|
|
|
|
context "A user with max saved searches" do
|
|
setup do
|
|
@user = FactoryBot.create(:gold_user)
|
|
CurrentUser.user = @user
|
|
User.any_instance.stubs(:max_saved_searches).returns(0)
|
|
@saved_search = @user.saved_searches.create(:query => "xxx")
|
|
end
|
|
|
|
should "not be able to create another saved search" do
|
|
assert_equal(["You can only have up to 0 saved searches"], @saved_search.errors.full_messages)
|
|
end
|
|
end
|
|
end
|