abce4d2551
Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
37 lines
1.4 KiB
Ruby
37 lines
1.4 KiB
Ruby
class Favorite < ApplicationRecord
|
|
belongs_to :post
|
|
belongs_to :user
|
|
scope :for_user, lambda {|user_id| where("user_id % 100 = #{user_id.to_i % 100} and user_id = #{user_id.to_i}")}
|
|
|
|
def self.add(post:, user:)
|
|
Favorite.transaction do
|
|
User.where(:id => user.id).select("id").lock("FOR UPDATE NOWAIT").first
|
|
|
|
return if Favorite.for_user(user.id).where(:user_id => user.id, :post_id => post.id).exists?
|
|
Favorite.create!(:user_id => user.id, :post_id => post.id)
|
|
Post.where(:id => post.id).update_all("fav_count = fav_count + 1")
|
|
post.append_user_to_fav_string(user.id)
|
|
User.where(:id => user.id).update_all("favorite_count = favorite_count + 1")
|
|
user.favorite_count += 1
|
|
end
|
|
end
|
|
|
|
def self.remove(user:, post: nil, post_id: nil)
|
|
Favorite.transaction do
|
|
if post && post_id.nil?
|
|
post_id = post.id
|
|
end
|
|
|
|
User.where(:id => user.id).select("id").lock("FOR UPDATE NOWAIT").first
|
|
|
|
return unless Favorite.for_user(user.id).where(:user_id => user.id, :post_id => post_id).exists?
|
|
Favorite.for_user(user.id).where(post_id: post_id).delete_all
|
|
Post.where(:id => post_id).update_all("fav_count = fav_count - 1")
|
|
post.delete_user_from_fav_string(user.id) if post
|
|
User.where(:id => user.id).update_all("favorite_count = favorite_count - 1")
|
|
user.favorite_count -= 1
|
|
post.fav_count -= 1 if post
|
|
end
|
|
end
|
|
end
|