Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
119 lines
2.9 KiB
Ruby
119 lines
2.9 KiB
Ruby
class PostAppeal < ApplicationRecord
|
|
class Error < Exception ; end
|
|
|
|
belongs_to :creator, :class_name => "User"
|
|
belongs_to :post
|
|
validates_presence_of :post, :reason, :creator_id, :creator_ip_addr
|
|
validate :validate_post_is_inactive
|
|
validate :validate_creator_is_not_limited
|
|
before_validation :initialize_creator, :on => :create
|
|
validates_uniqueness_of :creator_id, :scope => :post_id, :message => "have already appealed this post"
|
|
|
|
module SearchMethods
|
|
def reason_matches(query)
|
|
if query =~ /\*/
|
|
where("post_appeals.reason ILIKE ? ESCAPE E'\\\\'", query.to_escaped_for_sql_like)
|
|
else
|
|
where("to_tsvector('english', post_appeals.reason) @@ plainto_tsquery(?)", query.to_escaped_for_tsquery)
|
|
end
|
|
end
|
|
|
|
def post_tags_match(query)
|
|
PostQueryBuilder.new(query).build(self.joins(:post))
|
|
end
|
|
|
|
def resolved
|
|
joins(:post).where("posts.is_deleted = false and posts.is_flagged = false")
|
|
end
|
|
|
|
def unresolved
|
|
joins(:post).where("posts.is_deleted = true or posts.is_flagged = true")
|
|
end
|
|
|
|
def for_user(user_id)
|
|
where("creator_id = ?", user_id)
|
|
end
|
|
|
|
def recent
|
|
where("created_at >= ?", 1.day.ago)
|
|
end
|
|
|
|
def for_creator(user_id)
|
|
where("creator_id = ?", user_id)
|
|
end
|
|
|
|
def search(params)
|
|
q = super
|
|
|
|
if params[:reason_matches].present?
|
|
q = q.reason_matches(params[:reason_matches])
|
|
end
|
|
|
|
if params[:creator_id].present?
|
|
q = q.where(creator_id: params[:creator_id].split(",").map(&:to_i))
|
|
end
|
|
|
|
if params[:creator_name].present?
|
|
q = q.where("creator_id = (select _.id from users _ where lower(_.name) = ?)", params[:creator_name].mb_chars.downcase.strip.tr(" ", "_"))
|
|
end
|
|
|
|
if params[:post_id].present?
|
|
q = q.where(post_id: params[:post_id].split(",").map(&:to_i))
|
|
end
|
|
|
|
if params[:post_tags_match].present?
|
|
q = q.post_tags_match(params[:post_tags_match])
|
|
end
|
|
|
|
if params[:is_resolved] == "true"
|
|
q = q.resolved
|
|
elsif params[:is_resolved] == "false"
|
|
q = q.unresolved
|
|
end
|
|
|
|
q.apply_default_order(params)
|
|
end
|
|
end
|
|
|
|
extend SearchMethods
|
|
|
|
def resolved?
|
|
post.present? && !post.is_deleted? && !post.is_flagged?
|
|
end
|
|
|
|
def is_resolved
|
|
resolved?
|
|
end
|
|
|
|
def validate_creator_is_not_limited
|
|
if appeal_count_for_creator >= Danbooru.config.max_appeals_per_day
|
|
errors[:creator] << "can appeal at most #{Danbooru.config.max_appeals_per_day} post a day"
|
|
false
|
|
else
|
|
true
|
|
end
|
|
end
|
|
|
|
def validate_post_is_inactive
|
|
if resolved?
|
|
errors[:post] << "is active"
|
|
false
|
|
else
|
|
true
|
|
end
|
|
end
|
|
|
|
def initialize_creator
|
|
self.creator_id = CurrentUser.id
|
|
self.creator_ip_addr = CurrentUser.ip_addr
|
|
end
|
|
|
|
def appeal_count_for_creator
|
|
PostAppeal.for_user(creator_id).recent.count
|
|
end
|
|
|
|
def method_attributes
|
|
super + [:is_resolved]
|
|
end
|
|
end
|