abce4d2551
Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
102 lines
3.6 KiB
Ruby
102 lines
3.6 KiB
Ruby
require 'test_helper'
|
|
|
|
class ArtistCommentaryTest < ActiveSupport::TestCase
|
|
setup do
|
|
user = FactoryBot.create(:user)
|
|
CurrentUser.user = user
|
|
CurrentUser.ip_addr = "127.0.0.1"
|
|
end
|
|
|
|
teardown do
|
|
CurrentUser.user = nil
|
|
CurrentUser.ip_addr = nil
|
|
end
|
|
|
|
should "A post should not have more than one commentary" do
|
|
post = FactoryBot.create(:post)
|
|
|
|
assert_raise(ActiveRecord::RecordInvalid) do
|
|
FactoryBot.create(:artist_commentary, post_id: post.id)
|
|
FactoryBot.create(:artist_commentary, post_id: post.id)
|
|
end
|
|
end
|
|
|
|
context "An artist commentary" do
|
|
context "when searched" do
|
|
setup do
|
|
@post1 = FactoryBot.create(:post, tag_string: "artcomm1")
|
|
@post2 = FactoryBot.create(:post, tag_string: "artcomm2")
|
|
@artcomm1 = FactoryBot.create(:artist_commentary, post_id: @post1.id, original_title: "foo", translated_title: "bar")
|
|
@artcomm2 = FactoryBot.create(:artist_commentary, post_id: @post2.id, original_title: "", original_description: "", translated_title: "", translated_description: "")
|
|
end
|
|
|
|
should "find the correct match" do
|
|
assert_equal([@artcomm1.id], ArtistCommentary.search(post_id: @post1.id.to_s).map(&:id))
|
|
assert_equal([@artcomm1.id], ArtistCommentary.search(text_matches: "foo").map(&:id))
|
|
assert_equal([@artcomm1.id], ArtistCommentary.search(text_matches: "f*").map(&:id))
|
|
assert_equal([@artcomm1.id], ArtistCommentary.search(post_tags_match: "artcomm1").map(&:id))
|
|
|
|
assert_equal([@artcomm1.id], ArtistCommentary.search(original_present: "yes").map(&:id))
|
|
assert_equal([@artcomm2.id], ArtistCommentary.search(original_present: "no").map(&:id))
|
|
|
|
assert_equal([@artcomm1.id], ArtistCommentary.search(translated_present: "yes").map(&:id))
|
|
assert_equal([@artcomm2.id], ArtistCommentary.search(translated_present: "no").map(&:id))
|
|
end
|
|
end
|
|
|
|
context "when created" do
|
|
should "create a new version" do
|
|
@artcomm = FactoryBot.create(:artist_commentary, original_title: "foo")
|
|
|
|
assert_equal(1, @artcomm.versions.size)
|
|
assert_equal("foo", @artcomm.versions.last.original_title)
|
|
end
|
|
end
|
|
|
|
context "when updated" do
|
|
setup do
|
|
@post = FactoryBot.create(:post)
|
|
@artcomm = FactoryBot.create(:artist_commentary, post_id: @post.id)
|
|
@artcomm.reload
|
|
end
|
|
|
|
should "not create new version if nothing changed" do
|
|
@artcomm.save
|
|
assert_equal(1, @post.artist_commentary.versions.size)
|
|
end
|
|
|
|
should "create a new version if outside merge window" do
|
|
travel_to(2.hours.from_now) do
|
|
@artcomm.update(original_title: "bar")
|
|
|
|
assert_equal(2, @post.artist_commentary.versions.size)
|
|
assert_equal("bar", @artcomm.versions.last.original_title)
|
|
end
|
|
end
|
|
|
|
should "merge with the previous version if inside merge window" do
|
|
@artcomm.update(original_title: "bar")
|
|
@artcomm.reload
|
|
|
|
assert_equal(1, @post.artist_commentary.versions.size)
|
|
assert_equal("bar", @artcomm.versions.last.original_title)
|
|
end
|
|
|
|
should "trim whitespace from all fields" do
|
|
# \u00A0 - nonbreaking space.
|
|
@artcomm.update(
|
|
original_title: " foo\u00A0\t\n",
|
|
original_description: " foo\u00A0\t\n",
|
|
translated_title: " foo\u00A0\t\n",
|
|
translated_description: " foo\u00A0\n",
|
|
)
|
|
|
|
assert_equal("foo", @artcomm.original_title)
|
|
assert_equal("foo", @artcomm.original_description)
|
|
assert_equal("foo", @artcomm.translated_title)
|
|
assert_equal("foo", @artcomm.translated_description)
|
|
end
|
|
end
|
|
end
|
|
end
|