Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
167 lines
4.2 KiB
Ruby
167 lines
4.2 KiB
Ruby
require 'test_helper'
|
|
require "danbooru/paginator/pagination_error"
|
|
|
|
module PostSets
|
|
class PostTest < ActiveSupport::TestCase
|
|
context "In all cases" do
|
|
setup do
|
|
@user = FactoryBot.create(:user)
|
|
CurrentUser.user = @user
|
|
CurrentUser.ip_addr = "127.0.0.1"
|
|
|
|
@post_1 = FactoryBot.create(:post, :tag_string => "a")
|
|
@post_2 = FactoryBot.create(:post, :tag_string => "b")
|
|
@post_3 = FactoryBot.create(:post, :tag_string => "c")
|
|
end
|
|
|
|
teardown do
|
|
CurrentUser.user = nil
|
|
CurrentUser.ip_addr = nil
|
|
end
|
|
|
|
context "a set for page 2" do
|
|
setup do
|
|
@set = PostSets::Post.new("", 2)
|
|
::Post.stubs(:records_per_page).returns(1)
|
|
end
|
|
|
|
should "return the second element" do
|
|
assert_equal(@post_2.id, @set.posts.first.id)
|
|
end
|
|
end
|
|
|
|
context "a set for the 'a' tag query" do
|
|
setup do
|
|
@post_4 = FactoryBot.create(:post, :tag_string => "a")
|
|
@post_5 = FactoryBot.create(:post, :tag_string => "a")
|
|
end
|
|
|
|
context "with no page" do
|
|
setup do
|
|
@set = PostSets::Post.new("a")
|
|
::Post.stubs(:records_per_page).returns(1)
|
|
end
|
|
|
|
should "return the first element" do
|
|
assert_equal(@post_5.id, @set.posts.first.id)
|
|
end
|
|
end
|
|
|
|
context "for before the first element" do
|
|
setup do
|
|
@set = PostSets::Post.new("a", "b#{@post_5.id}")
|
|
::Post.stubs(:records_per_page).returns(1)
|
|
end
|
|
|
|
should "return the second element" do
|
|
assert_equal(@post_4.id, @set.posts.first.id)
|
|
end
|
|
end
|
|
|
|
context "for after the second element" do
|
|
setup do
|
|
@set = PostSets::Post.new("a", "a#{@post_4.id}")
|
|
@set.stubs(:records_per_page).returns(1)
|
|
end
|
|
|
|
should "return the first element" do
|
|
assert_equal(@post_5.id, @set.posts.first.id)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "a set for the 'a b' tag query" do
|
|
setup do
|
|
@set = PostSets::Post.new("a b")
|
|
end
|
|
|
|
should "know it isn't a single tag" do
|
|
assert(!@set.is_single_tag?)
|
|
end
|
|
end
|
|
|
|
context "a set going to the 1,001st page" do
|
|
setup do
|
|
@set = PostSets::Post.new("a", 1_001)
|
|
end
|
|
|
|
should "fail" do
|
|
assert_raises(Danbooru::Paginator::PaginationError) do
|
|
@set.posts
|
|
end
|
|
end
|
|
end
|
|
|
|
context "a set for the 'a b c' tag query" do
|
|
setup do
|
|
@set = PostSets::Post.new("a b c")
|
|
end
|
|
|
|
context "for a non-gold user" do
|
|
should "fail" do
|
|
assert_raises(::Post::SearchError) do
|
|
@set.posts
|
|
end
|
|
end
|
|
end
|
|
|
|
context "for a gold user" do
|
|
setup do
|
|
CurrentUser.user = FactoryBot.create(:gold_user)
|
|
end
|
|
|
|
should "pass" do
|
|
assert_nothing_raised do
|
|
@set.posts
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context "a set for the 'a' tag query" do
|
|
setup do
|
|
@set = PostSets::Post.new("a")
|
|
end
|
|
|
|
should "know it is a single tag" do
|
|
assert(@set.is_single_tag?)
|
|
end
|
|
|
|
should "normalize its tag query" do
|
|
assert_equal("a", @set.tag_string)
|
|
end
|
|
|
|
should "know the count" do
|
|
assert_equal(1, @set.posts.total_count)
|
|
end
|
|
|
|
should "find the posts" do
|
|
assert_equal(@post_1.id, @set.posts.first.id)
|
|
end
|
|
|
|
context "that has a matching wiki page" do
|
|
setup do
|
|
@wiki_page = FactoryBot.create(:wiki_page, :title => "a")
|
|
end
|
|
|
|
should "find the wiki page" do
|
|
assert_not_nil(@set.wiki_page)
|
|
assert_equal(@wiki_page.id, @set.wiki_page.id)
|
|
end
|
|
end
|
|
|
|
context "that has a matching artist" do
|
|
setup do
|
|
@artist = FactoryBot.create(:artist, :name => "a")
|
|
end
|
|
|
|
should "find the artist" do
|
|
assert_not_nil(@set.artist)
|
|
assert_equal(@artist.id, @set.artist.id)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|