abce4d2551
Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
58 lines
1.3 KiB
Ruby
58 lines
1.3 KiB
Ruby
class CommentVote < ApplicationRecord
|
|
class Error < Exception ; end
|
|
|
|
belongs_to :comment
|
|
belongs_to :user
|
|
before_validation :initialize_user, :on => :create
|
|
validates_presence_of :user_id, :comment_id, :score
|
|
validates_uniqueness_of :user_id, :scope => :comment_id, :message => "have already voted for this comment"
|
|
validate :validate_user_can_vote
|
|
validate :validate_comment_can_be_down_voted
|
|
validates_inclusion_of :score, :in => [-1, 1], :message => "must be 1 or -1"
|
|
|
|
def self.prune!
|
|
where("created_at < ?", 14.days.ago).delete_all
|
|
end
|
|
|
|
def self.search(params)
|
|
q = where("true")
|
|
return q if params.blank?
|
|
|
|
if params[:comment_id]
|
|
q = q.where("comment_id = ?", params[:comment_id].to_i)
|
|
end
|
|
|
|
q
|
|
end
|
|
|
|
def validate_user_can_vote
|
|
if !user.can_comment_vote?
|
|
errors.add :base, "You cannot vote on more than 10 comments per hour"
|
|
false
|
|
else
|
|
true
|
|
end
|
|
end
|
|
|
|
def validate_comment_can_be_down_voted
|
|
if is_positive? && comment.creator == CurrentUser.user
|
|
errors.add :base, "You cannot upvote your own comments"
|
|
false
|
|
else
|
|
true
|
|
end
|
|
end
|
|
|
|
def is_positive?
|
|
score == 1
|
|
end
|
|
|
|
def is_negative?
|
|
score == -1
|
|
end
|
|
|
|
def initialize_user
|
|
self.user_id = CurrentUser.user.id
|
|
end
|
|
end
|