3aa5cab2aa
`normalize_for_source` was used to convert image URLs to page URLs when displaying sources on the post show page. Move all the code for converting image URLs to page URLs from `Sources::Strategies#normalize_for_source` to `Source::URL#page_url`. Before we had to be very careful in source strategies not to make any network calls in `normalize_for_source`, since it was used in the view for the post show page. Now all the code for generating page URLs is isolated in Source::URL, which makes source strategies simpler. It also makes it easier to check if a source is an image URL or page URL, and if the image URL is convertible to a page URL, which will make autotagging bad_link or bad_source feasible. Finally, this fixes it to generate better page URLs in a handful of cases: * https://www.artstation.com/artwork/qPVGP instead of https://anubis1982918.artstation.com/projects/qPVGP * https://yande.re/post/show?md5=b4b1d11facd1700544554e4805d47bb6s instead of https://yande.re/post?tags=md5:b4b1d11facd1700544554e4805d47bb6 * http://gallery.minitokyo.net/view/365677 instead of http://gallery.minitokyo.net/download/365677 * https://valkyriecrusade.fandom.com/wiki/File:Crimson_Hatsune_H.png instead of https://valkyriecrusade.wikia.com/wiki/File:Crimson_Hatsune_H.png * https://rule34.paheal.net/post/view/852405 instead of https://rule34.paheal.net/post/list/md5:854806addcd3b1246424e7cea49afe31/1
40 lines
986 B
Ruby
40 lines
986 B
Ruby
# frozen_string_literal: true
|
|
|
|
module Sources
|
|
module Strategies
|
|
def self.all
|
|
[
|
|
Strategies::Pixiv,
|
|
Strategies::Twitter,
|
|
Strategies::Tumblr,
|
|
Strategies::NicoSeiga,
|
|
Strategies::DeviantArt,
|
|
Strategies::Moebooru,
|
|
Strategies::Nijie,
|
|
Strategies::ArtStation,
|
|
Strategies::HentaiFoundry,
|
|
Strategies::Fanbox,
|
|
Strategies::Mastodon,
|
|
Strategies::PixivSketch,
|
|
Strategies::Weibo,
|
|
Strategies::Newgrounds,
|
|
Strategies::Skeb,
|
|
Strategies::Lofter,
|
|
Strategies::Foundation,
|
|
Strategies::Plurk,
|
|
Strategies::Tinami,
|
|
Strategies::Fantia,
|
|
]
|
|
end
|
|
|
|
def self.find(url, referer = nil, default: Strategies::Null)
|
|
strategy = all.lazy.map { |s| s.new(url, referer) }.detect(&:match?)
|
|
strategy || default&.new(url, referer)
|
|
end
|
|
|
|
def self.canonical(url, referer)
|
|
find(url, referer).canonical_url
|
|
end
|
|
end
|
|
end
|