3aa5cab2aa
`normalize_for_source` was used to convert image URLs to page URLs when displaying sources on the post show page. Move all the code for converting image URLs to page URLs from `Sources::Strategies#normalize_for_source` to `Source::URL#page_url`. Before we had to be very careful in source strategies not to make any network calls in `normalize_for_source`, since it was used in the view for the post show page. Now all the code for generating page URLs is isolated in Source::URL, which makes source strategies simpler. It also makes it easier to check if a source is an image URL or page URL, and if the image URL is convertible to a page URL, which will make autotagging bad_link or bad_source feasible. Finally, this fixes it to generate better page URLs in a handful of cases: * https://www.artstation.com/artwork/qPVGP instead of https://anubis1982918.artstation.com/projects/qPVGP * https://yande.re/post/show?md5=b4b1d11facd1700544554e4805d47bb6s instead of https://yande.re/post?tags=md5:b4b1d11facd1700544554e4805d47bb6 * http://gallery.minitokyo.net/view/365677 instead of http://gallery.minitokyo.net/download/365677 * https://valkyriecrusade.fandom.com/wiki/File:Crimson_Hatsune_H.png instead of https://valkyriecrusade.wikia.com/wiki/File:Crimson_Hatsune_H.png * https://rule34.paheal.net/post/view/852405 instead of https://rule34.paheal.net/post/list/md5:854806addcd3b1246424e7cea49afe31/1
106 lines
4.4 KiB
Ruby
106 lines
4.4 KiB
Ruby
require 'test_helper'
|
|
|
|
module Sources
|
|
class HentaiFoundryTest < ActiveSupport::TestCase
|
|
context "The source for a hentai foundry picture" do
|
|
setup do
|
|
@image_1 = Sources::Strategies.find("https://www.hentai-foundry.com/pictures/user/Afrobull/795025/kuroeda")
|
|
@image_2 = Sources::Strategies.find("https://pictures.hentai-foundry.com/a/Afrobull/795025/Afrobull-795025-kuroeda.png")
|
|
end
|
|
|
|
should "get the illustration id" do
|
|
assert_equal("795025", @image_1.illust_id)
|
|
assert_equal("795025", @image_2.illust_id)
|
|
end
|
|
|
|
should "get the artist name" do
|
|
assert_equal("Afrobull", @image_1.artist_name)
|
|
assert_equal("Afrobull", @image_2.artist_name)
|
|
end
|
|
|
|
should "get the artist commentary title" do
|
|
assert_equal("kuroeda", @image_1.artist_commentary_title)
|
|
assert_equal("kuroeda", @image_2.artist_commentary_title)
|
|
end
|
|
|
|
should "get profile url" do
|
|
assert_equal("https://www.hentai-foundry.com/user/Afrobull", @image_1.profile_url)
|
|
assert_equal("https://www.hentai-foundry.com/user/Afrobull", @image_2.profile_url)
|
|
end
|
|
|
|
should "get the image url" do
|
|
assert_equal(["https://pictures.hentai-foundry.com/a/Afrobull/795025/Afrobull-795025-kuroeda.png"], @image_1.image_urls)
|
|
assert_equal(["https://pictures.hentai-foundry.com/a/Afrobull/795025/Afrobull-795025-kuroeda.png"], @image_2.image_urls)
|
|
end
|
|
|
|
should "get the canonical url" do
|
|
assert_equal("https://pictures.hentai-foundry.com/a/Afrobull/795025/Afrobull-795025-kuroeda.png", @image_1.canonical_url)
|
|
assert_equal("https://pictures.hentai-foundry.com/a/Afrobull/795025/Afrobull-795025-kuroeda.png", @image_2.canonical_url)
|
|
end
|
|
|
|
should "download an image" do
|
|
assert_downloaded(1_349_887, @image_1.image_urls.sole)
|
|
assert_downloaded(1_349_887, @image_2.image_urls.sole)
|
|
end
|
|
|
|
should "get the tags" do
|
|
assert_equal([["elf", "https://www.hentai-foundry.com/search/index?query=elf&search_in=keywords"]], @image_1.tags)
|
|
assert_equal([["elf", "https://www.hentai-foundry.com/search/index?query=elf&search_in=keywords"]], @image_2.tags)
|
|
end
|
|
|
|
should "find the correct artist" do
|
|
@artist = FactoryBot.create(:artist, name: "Afrobull", url_string: @image_1.url)
|
|
assert_equal([@artist], @image_1.artists)
|
|
assert_equal([@artist], @image_2.artists)
|
|
end
|
|
end
|
|
|
|
context "An artist profile url" do
|
|
setup do
|
|
@site = Sources::Strategies.find("https://www.hentai-foundry.com/user/Afrobull/profile")
|
|
end
|
|
|
|
should "get the profile url" do
|
|
assert_equal("https://www.hentai-foundry.com/user/Afrobull", @site.profile_url)
|
|
end
|
|
|
|
should "get the artist name" do
|
|
assert_equal("Afrobull", @site.artist_name)
|
|
end
|
|
end
|
|
|
|
context "A deleted picture" do
|
|
setup do
|
|
@image = Sources::Strategies.find("https://www.hentai-foundry.com/pictures/user/faustsketcher/279498")
|
|
@artist = FactoryBot.create(:artist, name: "faustsketcher", url_string: @image.url)
|
|
end
|
|
|
|
should "still find the artist name" do
|
|
assert_equal("faustsketcher", @image.artist_name)
|
|
assert_equal("https://www.hentai-foundry.com/user/faustsketcher", @image.profile_url)
|
|
assert_equal([@artist], @image.artists)
|
|
end
|
|
end
|
|
|
|
context "generating page urls" do
|
|
should "work" do
|
|
source1 = "http://pictures.hentai-foundry.com//a/AnimeFlux/219123.jpg"
|
|
source2 = "http://pictures.hentai-foundry.com/a/AnimeFlux/219123/Mobile-Suit-Equestria-rainbow-run.jpg"
|
|
source3 = "http://www.hentai-foundry.com/pictures/user/Ganassa/457176/LOL-Swimsuit---Caitlyn-reworked-nude-ver."
|
|
|
|
assert_equal("https://www.hentai-foundry.com/pictures/user/AnimeFlux/219123", Source::URL.page_url(source1))
|
|
assert_equal("https://www.hentai-foundry.com/pictures/user/AnimeFlux/219123", Source::URL.page_url(source2))
|
|
assert_equal("https://www.hentai-foundry.com/pictures/user/Ganassa/457176", Source::URL.page_url(source3))
|
|
assert_nil(Source::URL.page_url("https://pictures.hentai-foundry.com/a/AnimeFlux"))
|
|
end
|
|
end
|
|
|
|
context "a post with a deeply nested commentary" do
|
|
should "work" do
|
|
@source = Sources::Strategies.find("https://hentai-foundry.com/pictures/user/LumiNyu/867562/Mona-patreon-winner")
|
|
assert_nothing_raised { @source.to_h }
|
|
end
|
|
end
|
|
end
|
|
end
|