b4ce2d83a6
The belongs_to_creator macro was used to initialize the creator_id field to the CurrentUser. This made tests complicated because it meant you had to create and set the current user every time you wanted to create an object, when lead to the current user being set over and over again. It also meant you had to constantly be aware of what the CurrentUser was in many different contexts, which was often confusing. Setting creators explicitly simplifies everything greatly.
34 lines
1.3 KiB
Ruby
34 lines
1.3 KiB
Ruby
module ApproverPruner
|
|
module_function
|
|
|
|
APPROVAL_PERIOD = 45.days
|
|
MINIMUM_APPROVALS = 30
|
|
|
|
def inactive_approvers
|
|
approvers = User.bit_prefs_match(:can_approve_posts, true)
|
|
approvers = approvers.where("level < ?", User::Levels::MODERATOR)
|
|
|
|
recently_promoted_approvers = UserFeedback.where("created_at >= ?", APPROVAL_PERIOD.ago).where_like(:body, "*You gained the ability to approve posts*").select(:user_id)
|
|
approvers = approvers.where.not(id: recently_promoted_approvers)
|
|
|
|
approvers.select do |approver|
|
|
approver.post_approvals.where("created_at >= ?", APPROVAL_PERIOD.ago).count < MINIMUM_APPROVALS
|
|
end
|
|
end
|
|
|
|
def prune!
|
|
inactive_approvers.each do |user|
|
|
CurrentUser.scoped(User.system, "127.0.0.1") do
|
|
user.update!(can_approve_posts: false)
|
|
user.feedback.create(category: "neutral", body: "Lost approval privileges", creator: User.system)
|
|
|
|
Dmail.create_automated(
|
|
to_id: user.id,
|
|
title: "Approver inactivity",
|
|
body: "You've approved fewer than #{MINIMUM_APPROVALS} posts in the past #{APPROVAL_PERIOD.inspect}. In order to make sure the list of active approvers is up-to-date, you have lost your approval privileges. If you wish to dispute this, you can message an admin to have your permission reinstated."
|
|
)
|
|
end
|
|
end
|
|
end
|
|
end
|