jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

related tags: fix wiki link adding "undefined" tag

Browse Source 
Fix #5154
Only add `toggle_tag` listener to links with the `search-tag` class,
add `target="_blank"` to wiki links to prevent accidentally leaving the
edit form.
This commit is contained in:
NamelessContributor
2022-05-05 12:39:23 +02:00
parent 34038d71ae
commit 1fd6abe047
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/javascript/src/javascripts/related_tag.js
View File

@@ -6,7 +6,7 @@ let RelatedTag = {};
RelatedTag.initialize_all = function() {
$(document).on("click.danbooru", ".related-tags-button", RelatedTag.on_click_related_tags_button);
$(document).on("change.danbooru", ".related-tags input", RelatedTag.toggle_tag);
$(document).on("click.danbooru", ".related-tags a", RelatedTag.toggle_tag);
$(document).on("click.danbooru", ".related-tags a.search-tag", RelatedTag.toggle_tag);
$(document).on("click.danbooru", "#show-related-tags-link", RelatedTag.show);
$(document).on("click.danbooru", "#hide-related-tags-link", RelatedTag.hide);
$(document).on("keyup.danbooru.relatedTags", "#post_tag_string", RelatedTag.update_selected);

4
app/views/related_tags/_current_tags.html.erb
View File

@@ -1,10 +1,10 @@
<div class="current-related-tags-columns space-y-4 md:space-y-0 md:flex md:space-x-4">
<% if related_tags.present? %>
<%= render "related_tags/tag_column", tags: related_tags.tags.map(&:name), class: "general-related-tags-column", title: related_tags.pretty_name %>
<%= render "related_tags/tag_column", tags: related_tags.wiki_page_tags, class: "wiki-related-tags-column", title: link_to_wiki("wiki:#{related_tags.pretty_name}", related_tags.query) %>
<%= render "related_tags/tag_column", tags: related_tags.wiki_page_tags, class: "wiki-related-tags-column", title: link_to_wiki("wiki:#{related_tags.pretty_name}", related_tags.query, target: "_blank") %>
<% related_tags.other_wiki_pages.each do |wiki| %>
<%= render "related_tags/tag_column", tags: wiki.tags, class: "other-wiki-related-tags-column", title: link_to_wiki("wiki:#{wiki.pretty_title}", wiki.title) %>
<%= render "related_tags/tag_column", tags: wiki.tags, class: "other-wiki-related-tags-column", title: link_to_wiki("wiki:#{wiki.pretty_title}", wiki.title, target: "_blank") %>
<% end %>
<% end %>
</div>