api: remove available_includes dependent on current user.

This is to avoid specifying permissions in multiple disjoint places and
because most API users shouldn't need these fields.
This commit is contained in:
evazion
2020-02-16 19:58:14 -06:00
parent 9ef80d7344
commit 207861fd40
6 changed files with 6 additions and 19 deletions

View File

@@ -166,8 +166,6 @@ class Comment < ApplicationRecord
end
def self.available_includes
includes_array = [:post, :creator, :updater]
includes_array << :moderation_reports if CurrentUser.is_moderator?
includes_array
[:post, :creator, :updater]
end
end

View File

@@ -197,8 +197,6 @@ class Dmail < ApplicationRecord
end
def self.available_includes
includes_array = [:owner, :to, :from]
includes_array << :moderation_reports if CurrentUser.is_moderator?
includes_array
[:owner, :to, :from]
end
end

View File

@@ -225,8 +225,6 @@ class ForumPost < ApplicationRecord
end
def self.available_includes
includes_array = [:creator, :updater, :topic, :dtext_links, :votes, :tag_alias, :tag_implication, :bulk_update_request]
includes_array << :moderation_reports if CurrentUser.is_moderator?
includes_array
[:creator, :updater, :topic, :dtext_links, :votes, :tag_alias, :tag_implication, :bulk_update_request]
end
end

View File

@@ -179,8 +179,6 @@ class ForumTopic < ApplicationRecord
end
def self.available_includes
includes_array = [:creator, :updater, :original_post]
includes_array << :moderation_reports if CurrentUser.is_moderator?
includes_array
[:creator, :updater, :original_post]
end
end

View File

@@ -1768,9 +1768,6 @@ class Post < ApplicationRecord
end
def self.available_includes
includes_array = [:uploader, :updater, :approver, :parent, :upload, :artist_commentary, :flags, :appeals, :notes, :comments, :children, :approvals, :replacements]
includes_array << :moderation_reports if CurrentUser.is_moderator?
includes_array << :disapprovals if CurrentUser.user.is_approver?
includes_array
[:uploader, :updater, :approver, :parent, :upload, :artist_commentary, :flags, :appeals, :notes, :comments, :children, :approvals, :replacements]
end
end

View File

@@ -163,8 +163,6 @@ class PostFlag < ApplicationRecord
end
def self.available_includes
includes_array = [:post]
includes_array << :creator if CurrentUser.user.is_moderator?
includes_array
[:post]
end
end